Skip to contentSkip to conversation

perf symbols: Add 'intel_idle_ibrs' to the list of idle symbols

PATCH Applied Arnaldo Carvalho de Melo 2 participants 3 messages Oct 5, 2023 – Oct 12, 2023 perf events

lore
Share & tools
lore

Arnaldo Carvalho de Melo

author maintainer
#0 lore raw

PATCH 1/1 perf symbols: Add 'intel_idle_ibrs' to the list of idle symbols

From: Arnaldo Carvalho de Melo <[email protected]>

This is a longstanding to do list entry: we need a way to see that a sample took place while in idle state, as the current way to do it is to infer that by the name of the functions that in such state have more samples, IOW: a hack.

Maybe we can do flip a bit in samples that take place inside the enter/exit idle section in do_idle()?

But till then, add one more :-\

Cc Adrian Hunter <[email protected]>
cc Frédéric Weisbecker <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Ingo Molnar <[email protected]>,
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
---
 tools/perf/util/symbol.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/util/symbol.c +1 -0
index 5b54d2639df4740e..3c7f483bf85bbdaf 100644
@@ -718,6 +718,7 @@ static bool symbol__is_idle(const char *name)
 		"cpu_startup_entry",
 		"idle_cpu",
 		"intel_idle",
+		"intel_idle_ibrs",
 		"default_idle",
 		"native_safe_halt",
 		"enter_idle",
Signature · 1 line
2.41.0
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Arnaldo,

Quoted 13 lines · Arnaldo Carvalho de Melo

From: Arnaldo Carvalho de Melo <[email protected]>

This is a longstanding to do list entry: we need a way to see that a sample took place while in idle state, as the current way to do it is to infer that by the name of the functions that in such state have more samples, IOW: a hack.

Maybe we can do flip a bit in samples that take place inside the enter/exit idle section in do_idle()?

But till then, add one more :-\

Quoted 8 lines
Cc Adrian Hunter <[email protected]>
cc Frédéric Weisbecker <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Ingo Molnar <[email protected]>,
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>

Thanks,
Namhyung

Quoted 19 lines
---
 tools/perf/util/symbol.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/util/symbol.c +1 -1
index 5b54d2639df4740e..3c7f483bf85bbdaf 100644
@@ -718,6 +718,7 @@ static bool symbol__is_idle(const char *name)
                "cpu_startup_entry",
                "idle_cpu",
                "intel_idle",
+               "intel_idle_ibrs",
                "default_idle",
                "native_safe_halt",
                "enter_idle",
--

2.41.0

maintainer Applied
#2 lore raw
Quoted 26 lines · Namhyung Kim

Hi Arnaldo,

Quoted 13 lines · Arnaldo Carvalho de Melo

From: Arnaldo Carvalho de Melo <[email protected]>

This is a longstanding to do list entry: we need a way to see that a sample took place while in idle state, as the current way to do it is to infer that by the name of the functions that in such state have more samples, IOW: a hack.

Maybe we can do flip a bit in samples that take place inside the enter/exit idle section in do_idle()?

But till then, add one more :-\

Quoted 8 lines
Cc Adrian Hunter <[email protected]>
cc Frédéric Weisbecker <[email protected]>
Cc Ian Rogers <[email protected]>
Cc Ingo Molnar <[email protected]>,
Cc Jiri Olsa <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Quoted 1 line

Applied to perf-tools-next, thanks!