Skip to contentSkip to conversation

staging: wlan-ng: replace strncpy() with strscpy()

PATCH In review Calvince Otieno 3 participants 3 messages Oct 13, 2023 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 staging: wlan-ng: replace strncpy() with strscpy()

Checkpatch suggests the use of strscpy() instead of strncpy(). The advantages are that it always adds a NUL terminator and it prevents a read overflow if the src string is not properly terminated. One potential disadvantage is that it doesn't zero pad the string like strncpy() does.
In this code, strscpy() and strncpy() are equivalent and it does not affect runtime behavior. The string is zeroed on the line before using memset(). The resulting string was always NUL terminated and PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL terminated.
However, even though using strscpy() does not fix any bugs, it's still nicer and makes checkpatch happy.

---

Patch version v6:
Remove extra whitespaces on the patch description text

Patch version v5:
Removed v1 patch details from the revsion history

Patch version v4:
Provide a valid description of the patch

Patch version v3:
Correct the patch subject headline.
staging: wlan-ng: remove strncpy() use in favor of strscpy()

Patch version v2 :
Correct implementation of the strscpy()

drivers/staging/wlan-ng/prism2fw.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wlan-ng/prism2fw.c +1 -1
index 5d03b2b9aab4..3ccd11041646 100644
@@ -725,7 +725,7 @@ static int plugimage(struct imgchunk *fchunk, unsigned int nfchunks,
 
                if (j == -1) {  /* plug the filename */
                        memset(dest, 0, s3plug[i].len);
-                       strncpy(dest, PRISM2_USB_FWFILE, s3plug[i].len - 1);
+                       strscpy(dest, PRISM2_USB_FWFILE, s3plug[i].len);
                } else {	/* plug a PDR */
                        memcpy(dest, &pda->rec[j]->data, s3plug[i].len);
                }

--
Calvince Otieno

#1 lore raw
Quoted 13 lines · Calvince Otieno

Checkpatch suggests the use of strscpy() instead of strncpy(). The advantages are that it always adds a NUL terminator and it prevents a read overflow if the src string is not properly terminated. One potential disadvantage is that it doesn't zero pad the string like strncpy() does.
In this code, strscpy() and strncpy() are equivalent and it does not affect runtime behavior. The string is zeroed on the line before using memset(). The resulting string was always NUL terminated and PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL terminated.
However, even though using strscpy() does not fix any bugs, it's still nicer and makes checkpatch happy.

Quoted 2 lines

---

It's still white space damaged and can't apply. :/ Try save the email and do cat raw_email.txt | patch -p1.

regards,
dan carpenter

#2 lore raw
Quoted 14 lines · Dan Carpenter
Quoted 13 lines · Calvince Otieno

Checkpatch suggests the use of strscpy() instead of strncpy(). The advantages are that it always adds a NUL terminator and it prevents a read overflow if the src string is not properly terminated. One potential disadvantage is that it doesn't zero pad the string like strncpy() does.
In this code, strscpy() and strncpy() are equivalent and it does not affect runtime behavior. The string is zeroed on the line before using memset(). The resulting string was always NUL terminated and PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL terminated.
However, even though using strscpy() does not fix any bugs, it's still nicer and makes checkpatch happy.

Quoted 6 lines
Quoted 2 lines

---

It's still white space damaged and can't apply. :/ Try save the email and do cat raw_email.txt | patch -p1.

And better yet, use git-send-email(1) to send patches. But don't rush, as you have sent five versions of this patch today. Please wait for a day to a week and then reroll.

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara