staging: vme_user: replace strcpy with strscpy
PATCH v3 1/1 staging: vme_user: replace strcpy with strscpy
Checkpatch suggests using strscpy() instead of strcpy().
The advantages of strscpy() are that it always adds a NUL terminator and prevents read/write overflows if the source string is not properly terminated.
strcpy() lacks built-in bounds checking for the destination buffer, making it susceptible to buffer overflows. These overflows can lead to various unpredictable behaviors.
In this specific context, both strscpy and strcpy performs the same operation without any functional difference.
The reason for this equivalence is that the driver_name string "vme_fake" is shorter than the size of the fake_bridge->name array which is defined as 16 characters (struct vme_bridge {char name[VMENAMSIZ];...}). Thus, there is no risk of buffer overflow in either case. VMENAMSIZ variable holds a constant value of 16 (#define VMENAMSIZ 16)
The null-terminated "vme_fake" string
(static const char driver_name[] = "vme_fake";) can be safely copied into fake_bridge->name using either strscpy or strcpy.
While using strscpy() does not address any bugs, it is considered a better practice and aligns with checkpatch recommendations.
---
Changes in v3:
- Rewrote the commit message
---
Changes in v2:
- Make the commit message more clearer.
- Remove the incident extra line change.
drivers/staging/vme_user/vme_fake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vme_user/vme_fake.c +1 -1
@@ -1091,7 +1091,7 @@ static int __init fake_init(void)tasklet_init (&fake_device->int_tasklet, fake_VIRQ_tasklet, (unsigned long )fake_bridge); -strcpy (fake_bridge->name, driver_name); +strscpy (fake_bridge->name, driver_name,sizeof (fake_bridge->name)) /* Add master windows to list */INIT_LIST_HEAD (&fake_bridge->master_resources);
Signature · 1 line
2.34.1
Quoted 23 lines · Calvince Otieno
Checkpatch suggests using
strscpy()instead ofstrcpy().The advantages of
strscpy()are that it always adds a NUL terminator and prevents read/write overflows if the source string is not properly terminated.
strcpy()lacks built-in bounds checking for the destination buffer, making it susceptible to buffer overflows. These overflows can lead to various unpredictable behaviors.In this specific context, both strscpy and strcpy performs the same operation without any functional difference.
The reason for this equivalence is that the
driver_namestring "vme_fake" is shorter than the size of thefake_bridge->namearray which is defined as 16 characters (structvme_bridge{char name[VMENAMSIZ];...}). Thus, there is no risk of buffer overflow in either case. VMENAMSIZ variable holds a constant value of 16 (#define VMENAMSIZ 16)The null-terminated "
vme_fake" string
(static const char driver_name[] = "vme_fake";) can be safely copied intofake_bridge->nameusing either strscpy or strcpy.
Quoted 5 lines
While using
strscpy()does not address any bugs, it is considered a better practice and aligns with checkpatch recommendations.Signed-off-by Calvince Otieno <[email protected]>---
Thanks!
regards,
dan carpenter