Improper Handling for Messages That Do Not Specify Source/Address Port
Hi
While running ofono in debug mode, I discovered that there are certain types of sms-like messages that arrive in ofono core, but are discarded without being sent to the client. For these, the ofono log shows a lot of:
ofonod[3424627]: Got an 8-bit encoded message, however no valid src/address port, ignore
These messages are valid, and ofono should not discard them. In my case, for example, the messages come in while connected to mobile data. They are sent by the carrier periodically to notify me about the credit that has been deducted from my prepaid plan.
At first, I thought the issue was on the isimodem driver, but I later found the same log on my laptop, whose modem uses plugin/ericsson-mbm.
I am currently working on other issues that I have with ofono on my platform (isimodem), otherwise I would try to work on it.
Hope the report is clear enough. I can provide more information if needed.
Sincerely
Sicelo
Hi Sicelo,
Quoted 9 lines · Sicelo
Hi
While running ofono in debug mode, I discovered that there are certain types of sms-like messages that arrive in ofono core, but are discarded without being sent to the client. For these, the ofono log shows a lot of:
ofonod[3424627]: Got an 8-bit encoded message, however no valid src/address port, ignore
When that code was written, this was what the spec wanted. There was no way to identify the 8-bit character set of SMS messages, any 8-bit messages had to be a binary SMS with port/destination provided.
Maybe this has changed since, but I'd need some link / document to refer to ...
Quoted 4 lines
These messages are valid, and ofono should not discard them. In my case, for example, the messages come in while connected to mobile data. They are sent by the carrier periodically to notify me about the credit that has been deducted from my prepaid plan.
Sure, so how does oFono interpret these? ASCII? Latin1? UTF8?
Regards,
-Denis
Hi Denis
Quoted 10 lines · Denis Kenzior
Hi Sicelo,
Quoted 7 lines · Sicelo
Hi
While running ofono in debug mode, I discovered that there are certain types of sms-like messages that arrive in ofono core, but are discarded without being sent to the client. For these, the ofono log shows a lot of:
Quoted 8 lines
Quoted 2 lines
ofonod[3424627]: Got an 8-bit encoded message, however no valid src/address port, ignore
When that code was written, this was what the spec wanted. There was no way to identify the 8-bit character set of SMS messages, any 8-bit messages had to be a binary SMS with port/destination provided.
Maybe this has changed since, but I'd need some link / document to refer to ...
I am also not sure, but on an Android phone, for example, it shows up somewhat similar to what most of us call flash messages.
Quoted 6 lines
Quoted 4 lines
These messages are valid, and ofono should not discard them. In my case, for example, the messages come in while connected to mobile data. They are sent by the carrier periodically to notify me about the credit that has been deducted from my prepaid plan.
Sure, so how does oFono interpret these? ASCII? Latin1? UTF8?
From tracing on isimodem on the Nokia N900, it seemed to be plain ASCII, i.e. one byte-per-character. Unfortunately this message is carrier initiated, so I don't have an easy way to get them to send it at will.
When I eventually get to it, I guess I will start by testing with commenting out the code that checks for the src/dst port, and see where things go.
Sicelo
Quoted 30 lines · Sicelo
Hi Denis
Quoted 10 lines · Denis Kenzior
Hi Sicelo,
Quoted 7 lines · Sicelo
Hi
While running ofono in debug mode, I discovered that there are certain types of sms-like messages that arrive in ofono core, but are discarded without being sent to the client. For these, the ofono log shows a lot of:
Quoted 8 lines
Quoted 2 lines
ofonod[3424627]: Got an 8-bit encoded message, however no valid src/address port, ignore
When that code was written, this was what the spec wanted. There was no way to identify the 8-bit character set of SMS messages, any 8-bit messages had to be a binary SMS with port/destination provided.
Maybe this has changed since, but I'd need some link / document to refer to ...
I am also not sure, but on an Android phone, for example, it shows up somewhat similar to what most of us call flash messages.
Quoted 5 lines
Quoted 4 lines
These messages are valid, and ofono should not discard them. In my case, for example, the messages come in while connected to mobile data. They are sent by the carrier periodically to notify me about the credit that has been deducted from my prepaid plan.
Quoted 6 lines
Quoted 1 line
Sure, so how does oFono interpret these? ASCII? Latin1? UTF8?
From tracing on isimodem on the Nokia N900, it seemed to be plain ASCII, i.e. one byte-per-character. Unfortunately this message is carrier initiated, so I don't have an easy way to get them to send it at will.
Today I got a sample, while working on the phonet patch:
ofonod[3912]: PN_SMS (0x02): SMS_PP_ROUTING_NTF [id=0x08 utid=0x03 len=136]:
ofonod[3912]: * 03 08 00 01 11 84 00 02 82 0C 02 08 07 91 62 78 : ...............bx ofonod[3912]: * 09 00 00 F5 80 74 6D 00 04 14 D0 C5 F9 1D 04 6A : .....tm........j ofonod[3912]: * BE C5 69 76 19 00 14 42 01 62 41 51 81 80 56 48 : ..iv...B.bAQ..VH ofonod[3912]: * 65 6C 6C 6F 20 32 36 38 37 39 39 30 30 34 35 32 : ello.26879900452 ofonod[3912]: * 20 79 6F 75 20 68 61 76 65 20 62 65 65 6E 20 63 : .you.have.been.c ofonod[3912]: * 68 61 72 67 65 64 20 45 30 20 66 6F 72 20 30 20 : harged.E0.for.0. ofonod[3912]: * 4D 42 2E 47 65 74 20 6D 6F 72 65 20 66 72 6F 6D : MB.Get.more.from ofonod[3912]: * 20 6F 75 72 20 62 75 6E 64 6C 65 73 20 6F 6E 20 : .our.bundles.on. ofonod[3912]: * 6F 66 66 65 72 00 00 00 : offer...
ofonod[3912]: gisi: No error information NTF to 0x63fa40 [res=0x02, id=0x08, utid=0x03] ofonod[3912]: src/sms.c:ofono_sms_deliver_notify() len 117 tpdu len 109 ofonod[3912]: src/sms.c:handle_deliver()
ofonod[3912]: src/sms.c:sms_dispatch()
ofonod[3912]: src/sms.c:sms_dispatch() dst -1 src -1
ofonod[3912]: Got an 8-bit encoded message, however no valid src/address port, ignore ofonod[3912]: PN_SMS (0x02): SMS_GSM_RECEIVED_PP_REPORT_REQ [id=0x09 utid=0x05 len=16]:
ofonod[3912]: * 05 09 00 00 00 00 00 01 06 08 00 00 00 00 00 00 : .................
ofonod[3912]: PN_SMS (0x02): SMS_GSM_RECEIVED_PP_REPORT_RESP [id=0x0A utid=0x05 len=4]:
ofonod[3912]: * 05 0A 00 00 : .....
ofonod[3912]: gisi: normal RESP to 0xb6d106e0 [res=0x02, id=0x0A, utid=0x05]
So yes, this particular message is ASCII
Hi Sicelo,
Quoted 25 lines
Today I got a sample, while working on the phonet patch:
ofonod[3912]:
PN_SMS(0x02):SMS_PP_ROUTING_NTF[id=0x08 utid=0x03 len=136]:ofonod[3912]: * 03 08 00 01 11 84 00 02 82 0C 02 08 07 91 62 78 : ...............bx ofonod[3912]: * 09 00 00 F5 80 74 6D 00 04 14 D0 C5 F9 1D 04 6A : .....tm........j ofonod[3912]: * BE C5 69 76 19 00 14 42 01 62 41 51 81 80 56 48 : ..iv...B.bAQ..VH ofonod[3912]: * 65 6C 6C 6F 20 32 36 38 37 39 39 30 30 34 35 32 : ello.26879900452 ofonod[3912]: * 20 79 6F 75 20 68 61 76 65 20 62 65 65 6E 20 63 : .you.have.been.c ofonod[3912]: * 68 61 72 67 65 64 20 45 30 20 66 6F 72 20 30 20 : harged.E0.for.0. ofonod[3912]: * 4D 42 2E 47 65 74 20 6D 6F 72 65 20 66 72 6F 6D : MB.Get.more.from ofonod[3912]: * 20 6F 75 72 20 62 75 6E 64 6C 65 73 20 6F 6E 20 : .our.bundles.on. ofonod[3912]: * 6F 66 66 65 72 00 00 00 : offer...ofonod[3912]: gisi: No error information NTF to
0x63fa40[res=0x02, id=0x08, utid=0x03] ofonod[3912]: src/sms.c:ofono_sms_deliver_notify() len 117 tpdu len 109 ofonod[3912]: src/sms.c:handle_deliver()
ofonod[3912]: src/sms.c:sms_dispatch()
ofonod[3912]: src/sms.c:sms_dispatch() dst -1 src -1
ofonod[3912]: Got an 8-bit encoded message, however no valid src/address port, ignore ofonod[3912]:PN_SMS(0x02):SMS_GSM_RECEIVED_PP_REPORT_REQ[id=0x09 utid=0x05 len=16]:
ofonod[3912]: * 05 09 00 00 00 00 00 01 06 08 00 00 00 00 00 00 : .................
ofonod[3912]:PN_SMS(0x02):SMS_GSM_RECEIVED_PP_REPORT_RESP[id=0x0A utid=0x05 len=4]:
ofonod[3912]: * 05 0A 00 00 : .....
ofonod[3912]: gisi: normal RESP to0xb6d106e0[res=0x02, id=0x0A, utid=0x05]
Quoted 1 line
So yes, this particular message is ASCII
Do you want to send a patch? I'm still not sure how oFono would know that this is a flash message? I suppose we can check whether it is valid utf8 and treat it as a text message.
Regards,
-Denis
Hi
Quoted 16 lines · Denis Kenzior
Quoted 16 lines
ofonod[3912]:
PN_SMS(0x02):SMS_PP_ROUTING_NTF[id=0x08 utid=0x03 len=136]:ofonod[3912]: * 03 08 00 01 11 84 00 02 82 0C 02 08 07 91 62 78 : ...............bx ofonod[3912]: * 09 00 00 F5 80 74 6D 00 04 14 D0 C5 F9 1D 04 6A : .....tm........j ofonod[3912]: * BE C5 69 76 19 00 14 42 01 62 41 51 81 80 56 48 : ..iv...B.bAQ..VH ofonod[3912]: * 65 6C 6C 6F 20 32 36 38 37 39 39 30 30 34 35 32 : ello.26879900452 ofonod[3912]: * 20 79 6F 75 20 68 61 76 65 20 62 65 65 6E 20 63 : .you.have.been.c ofonod[3912]: * 68 61 72 67 65 64 20 45 30 20 66 6F 72 20 30 20 : harged.E0.for.0. ofonod[3912]: * 4D 42 2E 47 65 74 20 6D 6F 72 65 20 66 72 6F 6D : MB.Get.more.from ofonod[3912]: * 20 6F 75 72 20 62 75 6E 64 6C 65 73 20 6F 6E 20 : .our.bundles.on. ofonod[3912]: * 6F 66 66 65 72 00 00 00 : offer...ofonod[3912]: gisi: No error information NTF to
0x63fa40[res=0x02, id=0x08, utid=0x03] ofonod[3912]: src/sms.c:ofono_sms_deliver_notify() len 117 tpdu len 109 ofonod[3912]: src/sms.c:handle_deliver()
ofonod[3912]: src/sms.c:sms_dispatch()
ofonod[3912]: src/sms.c:sms_dispatch() dst -1 src -1
Quoted 5 lines
Quoted 1 line
So yes, this particular message is ASCII
Do you want to send a patch? I'm still not sure how oFono would know that this is a flash message? I suppose we can check whether it is valid utf8 and treat it as a text message.
I also have no clue at this point, so not sure what to do in the code. However I will see if I can find any information, and maybe find relevant code in Android for more clues.
Regards
Sicelo