Skip to contentSkip to conversation

bcachefs: Remove obsolete comment about zstd

PATCH Superseded Richard Davies 1 participant 2 messages Dec 3, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: Remove obsolete comment about zstd

Remove obsolete comment about zstd, since approach changed during development of commit bbc3a46065d08f9ab3412b1f26bbfa778c444833

---
 fs/bcachefs/compress.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
fs/bcachefs/compress.c +0 -4
index 51af8ea..33df8cf 100644
@@ -572,10 +572,6 @@ static int __bch2_fs_compress_init(struct bch_fs *c, u64 features)
 	ZSTD_parameters params = zstd_get_params(zstd_max_clevel(),
 						 c->opts.encoded_extent_max);
-	/*
-	 * ZSTD is lying: if we allocate the size of the workspace it says it
-	 * requires, it returns memory allocation errors
-	 */
 	c->zstd_workspace_size = zstd_cctx_workspace_bound(&params.cParams);
 	struct {
Signature · 1 line
1.7.0.3
#1 lore raw

Sorry, broken whitespace context in this version.

I've sent a v2 with git send-email, not my mail client...

Quoted 23 lines · Richard Davies

Remove obsolete comment about zstd, since approach changed during development of commit bbc3a46065d08f9ab3412b1f26bbfa778c444833

---
 fs/bcachefs/compress.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
fs/bcachefs/compress.c +0 -4
index 51af8ea..33df8cf 100644
@@ -572,10 +572,6 @@ static int __bch2_fs_compress_init(struct bch_fs *c, u64 features)
 	ZSTD_parameters params = zstd_get_params(zstd_max_clevel(),
 						 c->opts.encoded_extent_max);
-	/*
-	 * ZSTD is lying: if we allocate the size of the workspace it says it
-	 * requires, it returns memory allocation errors
-	 */
 	c->zstd_workspace_size = zstd_cctx_workspace_bound(&params.cParams);
 	struct {
Signature · 1 line
1.7.0.3