Skip to contentSkip to conversation

ASoC: tas2781: Add tas2563 into header file for DSP mode

PATCH Andy Shevchenko 1 participant 1 message Dec 27, 2023 Sound

lore
Share & tools
lore
#0 lore raw

Review

Quoted 13 lines · Shenghao Ding

Move tas2563 from tas2562 header file to tas2781 header file, because tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to enable DSP mode for tas2563, it has been moved to tas2781 driver. As to the hardware part, such as register setting and DSP firmware, all these are stored in the binary firmware. What tas2781 drivder dooes is to parse the firmware and download them to the tas2781 or tas2563, then power on tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。 Only attention will be paid to downloading corresponding firmware.

enum audio_device {

(quoted diff) +1 -0
 	TAS2781	= 0,
+	TAS2563
 };

Please, make it ordered, it doesn't seem to be an ABI.

enum audio_device {
	TAS2563,
	TAS2781,
};

Yes, and leave comma as the last entry is _not_ a terminator.

Signature · 2 lines
With Best Regards,
Andy Shevchenko