drm/udl: Set error code in udl_init()
PATCH 1/1 drm/udl: Set error code in udl_init()
Return -ENOMEM if udl_alloc_urb_list() fails. Don't return success.
Fixes fb10144ba426 ("drm/udl: Support adapters without firmware descriptor")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/udl/udl_main.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/udl/udl_main.c +1 -0
@@ -361,6 +361,7 @@ int udl_init(struct udl_device *udl)if (!udl_alloc_urb_list (udl,WRITES_IN_FLIGHT ,MAX_TRANSFER )) {DRM_ERROR ("udl_alloc_urb_list failed\n" ); + ret = -ENOMEM ; goto err; }
Signature · 1 line
2.47.2
Hi,
thanks for the fix.
Am 16.04.25 um 13:09 schrieb Dan Carpenter:
Quoted 4 lines
Return
-ENOMEMifudl_alloc_urb_list()fails. Don't return success.Fixes fb10144ba426 ("drm/udl: Support adapters without firmware descriptor")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Thomas Zimmermann <[email protected]>
Quoted 16 lines
--- drivers/gpu/drm/udl/udl_main.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/udl/udl_main.c +1
-0@@ -361,6 +361,7 @@ int udl_init(struct udl_device *udl)if (!udl_alloc_urb_list (udl,WRITES_IN_FLIGHT ,MAX_TRANSFER )) {DRM_ERROR ("udl_alloc_urb_list failed\n" ); + ret = -ENOMEM ; goto err; }
Signature · 7 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)