ASoC: qcom: qdsp6: Set error code in q6usb_hw_params()
Subsystems (5)
PATCH 1/1 ASoC: qcom: qdsp6: Set error code in q6usb_hw_params()
Propagate the error code if q6afe_port_get_from_id() fails. Don't return success.
Fixes 72b0b8b29980 ("ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6")
Signed-off-by Dan Carpenter <[email protected]>
--- sound/soc/qcom/qdsp6/q6usb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/qcom/qdsp6/q6usb.c +3 -1
@@ -74,8 +74,10 @@ static int q6usb_hw_params(struct snd_pcm_substream *substream, goto out; q6usb_afe =q6afe_port_get_from_id (cpu_dai->dev,USB_RX ); -if (IS_ERR (q6usb_afe)) +if (IS_ERR (q6usb_afe)) { + ret =PTR_ERR (q6usb_afe); goto out; + }/* Notify audio DSP about the devices being offloaded */ ret = afe_port_send_usb_dev_param(q6usb_afe, sdev->card_idx,
Signature · 1 line
2.47.2
Quoted 9 lines · Dan Carpenter
Propagate the error code if
q6afe_port_get_from_id()fails. Don't return success.Fixes 72b0b8b29980 ("ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6")Signed-off-by Dan Carpenter <[email protected]>--- sound/soc/qcom/qdsp6/q6usb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by Dmitry Baryshkov <[email protected]>
Signature · 2 lines
With best wishes Dmitry
Quoted 2 lines · Dan Carpenter
Propagate the error code if
q6afe_port_get_from_id()fails. Don't return success.
Acked-by Mark Brown <[email protected]>