Skip to contentSkip to conversation

ACPICA compilation error on x86_64_defconfig (W=1 build)

DISCUSSION Andy Shevchenko 2 participants 7 messages Apr 7, 2025 – Apr 9, 2025 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v6.15-rc1 (but seems older should also be problematic) fails to compile by Clang 19 with make W=1.

CC drivers/acpi/acpica/nsaccess.o
drivers/acpi/acpica/nsaccess.c:295:6: error: variable 'num_carats' set but not used [-Werror,-Wunused-but-set-variable]

    295 |         u32 num_carats;
        |             ^

1 error generated.

I looked briefly in the code and I have no idea how to fix this, as probably __maybe_unused not an option for ACPICA. Hence this report.

Note, the in-tree defconfig is in use:

	git checkout v6.15-rc1
	make x86_64_defconfig
	make W=1

should trigger it.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#1 lore raw

+Saket

Quoted 22 lines · Andy Shevchenko

v6.15-rc1 (but seems older should also be problematic) fails to compile by Clang 19 with make W=1.

CC drivers/acpi/acpica/nsaccess.o
drivers/acpi/acpica/nsaccess.c:295:6: error: variable 'num_carats' set but not used [-Werror,-Wunused-but-set-variable]

    295 |         u32 num_carats;
        |             ^

1 error generated.

I looked briefly in the code and I have no idea how to fix this, as probably __maybe_unused not an option for ACPICA. Hence this report.

Note, the in-tree defconfig is in use:

        git checkout v6.15-rc1
        make x86_64_defconfig
        make W=1

should trigger it.

--

#2 lore raw
Quoted 15 lines · Rafael J. Wysocki
Quoted 13 lines · Andy Shevchenko

v6.15-rc1 (but seems older should also be problematic) fails to compile by Clang 19 with make W=1.

CC drivers/acpi/acpica/nsaccess.o
drivers/acpi/acpica/nsaccess.c:295:6: error: variable 'num_carats' set but not used [-Werror,-Wunused-but-set-variable]

    295 |         u32 num_carats;
        |             ^

1 error generated.

I looked briefly in the code and I have no idea how to fix this, as probably __maybe_unused not an option for ACPICA. Hence this report.

Quoted 6 lines
Quoted 6 lines

Note, the in-tree defconfig is in use:

        git checkout v6.15-rc1
        make x86_64_defconfig

        make W=1

Since it's a clang, this should have also something like LLVM=1.

Quoted 1 line
Quoted 1 line

should trigger it.

Signature · 2 lines
With Best Regards,
Andy Shevchenko

A message that is not in the archive (sent off-list or not yet received): LV8PR11MB86980990221C597E01BAEB7980B52@LV8PR11MB8698.namprd11.prod.outlook.com

A message that is not in the archive (sent off-list or not yet received): LV8PR11MB8698978FFF89ACBEF253667680B52@LV8PR11MB8698.namprd11.prod.outlook.com

#5 lore raw

GCC should ignore all clang specific pragmas as far as I know.

But this seems to me the not the best solution either. What code needs is to have some refactoring to make sure the variable is used or not defined and used at all. Unfortunately, I am not familiar with ACPICA to propose anything right now, though.

Quoted 97 lines · Saket

I am not sure about the Linux environment specifics like Andy described in the previous conversation, but if GCC or some other compiler throws an error in the code with #pragma for clang, then may I suggest using this instead:

#pragma clang diagnostic push
#if defined(__clang__) && __clang__ >= n (replace n with the least version number which introduces this new warning type)
#pragma clang diagnostic ignored "-Wunused-but-set-variable" #endif
u32 num_carats;
#pragma clang diagnostic pop

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
From: Dumbre, Saket <[email protected]>
Sent: Tuesday, April 8, 2025 11:11 AM
To: Shevchenko, Andriy <[email protected]>; Rafael J. Wysocki <[email protected]>
Cc: Moore, Robert <[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: ACPICA compilation error on x86_64_defconfig (W=1 build)

Hi Andy and Rafael,

This issue is a duplication of an Apple ecosystem-based (ARM + M-series micro architecture) ACPICA GitHub Issue, which I was waiting on a response from the contributor/submitter to move ahead to resolve it:
https://github.com/acpica/acpica/issues/973

I don't see a platform specific file for Clang/LLVM in ACPICA (only for GCC and MSVC), so I think the worst-case untidy solution would be to locally patch this warning-turned-error by suppressing this warning type if the compiler is Clang/ LLVM.

It would look somewhat better to move that line all the way down after all the other definitions/declarations just before any execution line and wrap it with a #pragma something along the lines:

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-but-set-variable" u32 num_carats;
#pragma clang diagnostic pop

I am just not sure if this is the only place in the ACPICA code that generates this warning type and depending on the answer, this fix could be implemented at a wider/global scale, but please give this hacky fix a try and let me know if it resolves that. Thanks a lot!

Kind regards,

Saket Dumbre

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
From: Shevchenko, Andriy
Sent: Monday, April 7, 2025 11:51 AM
To: Rafael J. Wysocki
Cc: Dumbre, Saket; Moore, Robert; Wysocki, Rafael J; [email protected]; [email protected]
Subject: Re: ACPICA compilation error on x86_64_defconfig (W=1 build)

Quoted 8 lines · Rafael J. Wysocki
Quoted 6 lines · Andy Shevchenko

v6.15-rc1 (but seems older should also be problematic) fails to compile by Clang 19 with make W=1.

CC drivers/acpi/acpica/nsaccess.o
drivers/acpi/acpica/nsaccess.c:295:6: error: variable 'num_carats' set

but not used [-Werror,-Wunused-but-set-variable]

Quoted 5 lines
Quoted 5 lines
    295 |         u32 num_carats;
        |             ^

1 error generated.

I looked briefly in the code and I have no idea how to fix this, as

probably

Quoted 8 lines
Quoted 8 lines

__maybe_unused not an option for ACPICA. Hence this report.

Note, the in-tree defconfig is in use:

        git checkout v6.15-rc1
        make x86_64_defconfig

        make W=1

Since it's a clang, this should have also something like LLVM=1.

Quoted 1 line
Quoted 1 line

should trigger it.

--
With Best Regards,
Andy Shevchenko

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw

Note, I have posted two much better solutions in that bug report thread. Please, choose one and fix, it prevents kernel from building...

Quoted 111 lines · Andriy

GCC should ignore all clang specific pragmas as far as I know.

But this seems to me the not the best solution either. What code needs is to have some refactoring to make sure the variable is used or not defined and used at all. Unfortunately, I am not familiar with ACPICA to propose anything right now, though.

Quoted 97 lines · Saket

I am not sure about the Linux environment specifics like Andy described in the previous conversation, but if GCC or some other compiler throws an error in the code with #pragma for clang, then may I suggest using this instead:

#pragma clang diagnostic push
#if defined(__clang__) && __clang__ >= n (replace n with the least version number which introduces this new warning type)
#pragma clang diagnostic ignored "-Wunused-but-set-variable" #endif
u32 num_carats;
#pragma clang diagnostic pop

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
From: Dumbre, Saket <[email protected]>
Sent: Tuesday, April 8, 2025 11:11 AM
To: Shevchenko, Andriy <[email protected]>; Rafael J. Wysocki <[email protected]>
Cc: Moore, Robert <[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: ACPICA compilation error on x86_64_defconfig (W=1 build)

Hi Andy and Rafael,

This issue is a duplication of an Apple ecosystem-based (ARM + M-series micro architecture) ACPICA GitHub Issue, which I was waiting on a response from the contributor/submitter to move ahead to resolve it:
https://github.com/acpica/acpica/issues/973

I don't see a platform specific file for Clang/LLVM in ACPICA (only for GCC and MSVC), so I think the worst-case untidy solution would be to locally patch this warning-turned-error by suppressing this warning type if the compiler is Clang/ LLVM.

It would look somewhat better to move that line all the way down after all the other definitions/declarations just before any execution line and wrap it with a #pragma something along the lines:

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-but-set-variable" u32 num_carats;
#pragma clang diagnostic pop

I am just not sure if this is the only place in the ACPICA code that generates this warning type and depending on the answer, this fix could be implemented at a wider/global scale, but please give this hacky fix a try and let me know if it resolves that. Thanks a lot!

Kind regards,

Saket Dumbre

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
From: Shevchenko, Andriy
Sent: Monday, April 7, 2025 11:51 AM
To: Rafael J. Wysocki
Cc: Dumbre, Saket; Moore, Robert; Wysocki, Rafael J; [email protected]; [email protected]
Subject: Re: ACPICA compilation error on x86_64_defconfig (W=1 build)

Quoted 8 lines · Rafael J. Wysocki
Quoted 6 lines · Andy Shevchenko

v6.15-rc1 (but seems older should also be problematic) fails to compile by Clang 19 with make W=1.

CC drivers/acpi/acpica/nsaccess.o
drivers/acpi/acpica/nsaccess.c:295:6: error: variable 'num_carats' set

but not used [-Werror,-Wunused-but-set-variable]

Quoted 5 lines
Quoted 5 lines
    295 |         u32 num_carats;
        |             ^

1 error generated.

I looked briefly in the code and I have no idea how to fix this, as

probably

Quoted 8 lines
Quoted 8 lines

__maybe_unused not an option for ACPICA. Hence this report.

Note, the in-tree defconfig is in use:

        git checkout v6.15-rc1
        make x86_64_defconfig

        make W=1

Since it's a clang, this should have also something like LLVM=1.

Quoted 1 line
Quoted 1 line

should trigger it.

--
With Best Regards,
Andy Shevchenko

Signature · 2 lines
With Best Regards,
Andy Shevchenko
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw
Quoted 2 lines · Andriy

Note, I have posted two much better solutions in that bug report thread.

Which bug report thread do you mean?

Quoted 1 line

Please, choose one and fix, it prevents kernel from building...

With Clang-19 and 'make W=1' that is.

Quoted 119 lines · Andriy
Quoted 106 lines

GCC should ignore all clang specific pragmas as far as I know.

But this seems to me the not the best solution either. What code needs is to have some refactoring to make sure the variable is used or not defined and used at all. Unfortunately, I am not familiar with ACPICA to propose anything right now, though.

Quoted 88 lines · Saket

I am not sure about the Linux environment specifics like Andy described in the previous conversation, but if GCC or some other compiler throws an error in the code with #pragma for clang, then may I suggest using this instead:

#pragma clang diagnostic push
#if defined(__clang__) && __clang__ >= n (replace n with the least version number which introduces this new warning type)
#pragma clang diagnostic ignored "-Wunused-but-set-variable" #endif
u32 num_carats;
#pragma clang diagnostic pop

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
From: Dumbre, Saket <[email protected]>
Sent: Tuesday, April 8, 2025 11:11 AM
To: Shevchenko, Andriy <[email protected]>; Rafael J. Wysocki <[email protected]>
Cc: Moore, Robert <[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: ACPICA compilation error on x86_64_defconfig (W=1 build)

Hi Andy and Rafael,

This issue is a duplication of an Apple ecosystem-based (ARM + M-series micro architecture) ACPICA GitHub Issue, which I was waiting on a response from the contributor/submitter to move ahead to resolve it:
https://github.com/acpica/acpica/issues/973

I don't see a platform specific file for Clang/LLVM in ACPICA (only for GCC and MSVC), so I think the worst-case untidy solution would be to locally patch this warning-turned-error by suppressing this warning type if the compiler is Clang/ LLVM.

It would look somewhat better to move that line all the way down after all the other definitions/declarations just before any execution line and wrap it with a #pragma something along the lines:

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-but-set-variable" u32 num_carats;
#pragma clang diagnostic pop

I am just not sure if this is the only place in the ACPICA code that generates this warning type and depending on the answer, this fix could be implemented at a wider/global scale, but please give this hacky fix a try and let me know if it resolves that. Thanks a lot!

Kind regards,

Saket Dumbre

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
From: Shevchenko, Andriy
Sent: Monday, April 7, 2025 11:51 AM
To: Rafael J. Wysocki
Cc: Dumbre, Saket; Moore, Robert; Wysocki, Rafael J; [email protected]; [email protected]
Subject: Re: ACPICA compilation error on x86_64_defconfig (W=1 build)

Quoted 8 lines · Rafael J. Wysocki
Quoted 6 lines · Andy Shevchenko

v6.15-rc1 (but seems older should also be problematic) fails to compile by Clang 19 with make W=1.

CC drivers/acpi/acpica/nsaccess.o
drivers/acpi/acpica/nsaccess.c:295:6: error: variable 'num_carats' set

but not used [-Werror,-Wunused-but-set-variable]

Quoted 5 lines
Quoted 5 lines
    295 |         u32 num_carats;
        |             ^

1 error generated.

I looked briefly in the code and I have no idea how to fix this, as

probably

Quoted 8 lines
Quoted 8 lines

__maybe_unused not an option for ACPICA. Hence this report.

Note, the in-tree defconfig is in use:

        git checkout v6.15-rc1
        make x86_64_defconfig

        make W=1
Quoted 9 lines

Since it's a clang, this should have also something like LLVM=1.

Quoted 1 line
Quoted 1 line

should trigger it.

--
With Best Regards,
Andy Shevchenko

Quoted 5 lines

--
With Best Regards,
Andy Shevchenko

--
With Best Regards,
Andy Shevchenko

#8 lore raw
Quoted 6 lines · Rafael J. Wysocki
Quoted 2 lines · Andriy

Note, I have posted two much better solutions in that bug report thread.

Which bug report thread do you mean?

https://github.com/acpica/acpica/issues/973

Quoted 3 lines
Quoted 1 line

Please, choose one and fix, it prevents kernel from building...

With Clang-19 and 'make W=1' that is.

Yes. it is not *that* critical, sure.

Quoted 119 lines
Quoted 119 lines · Andriy
Quoted 106 lines

GCC should ignore all clang specific pragmas as far as I know.

But this seems to me the not the best solution either. What code needs is to have some refactoring to make sure the variable is used or not defined and used at all. Unfortunately, I am not familiar with ACPICA to propose anything right now, though.

Quoted 88 lines · Saket

I am not sure about the Linux environment specifics like Andy described in the previous conversation, but if GCC or some other compiler throws an error in the code with #pragma for clang, then may I suggest using this instead:

#pragma clang diagnostic push
#if defined(__clang__) && __clang__ >= n (replace n with the least version number which introduces this new warning type)
#pragma clang diagnostic ignored "-Wunused-but-set-variable" #endif
u32 num_carats;
#pragma clang diagnostic pop

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
From: Dumbre, Saket <[email protected]>
Sent: Tuesday, April 8, 2025 11:11 AM
To: Shevchenko, Andriy <[email protected]>; Rafael J. Wysocki <[email protected]>
Cc: Moore, Robert <[email protected]>; Wysocki, Rafael J <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: ACPICA compilation error on x86_64_defconfig (W=1 build)

Hi Andy and Rafael,

This issue is a duplication of an Apple ecosystem-based (ARM + M-series micro architecture) ACPICA GitHub Issue, which I was waiting on a response from the contributor/submitter to move ahead to resolve it:
https://github.com/acpica/acpica/issues/973

I don't see a platform specific file for Clang/LLVM in ACPICA (only for GCC and MSVC), so I think the worst-case untidy solution would be to locally patch this warning-turned-error by suppressing this warning type if the compiler is Clang/ LLVM.

It would look somewhat better to move that line all the way down after all the other definitions/declarations just before any execution line and wrap it with a #pragma something along the lines:

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-but-set-variable" u32 num_carats;
#pragma clang diagnostic pop

I am just not sure if this is the only place in the ACPICA code that generates this warning type and depending on the answer, this fix could be implemented at a wider/global scale, but please give this hacky fix a try and let me know if it resolves that. Thanks a lot!

Kind regards,

Saket Dumbre

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
From: Shevchenko, Andriy
Sent: Monday, April 7, 2025 11:51 AM
To: Rafael J. Wysocki
Cc: Dumbre, Saket; Moore, Robert; Wysocki, Rafael J; [email protected]; [email protected]
Subject: Re: ACPICA compilation error on x86_64_defconfig (W=1 build)

Quoted 8 lines · Rafael J. Wysocki
Quoted 6 lines · Andy Shevchenko

v6.15-rc1 (but seems older should also be problematic) fails to compile by Clang 19 with make W=1.

CC drivers/acpi/acpica/nsaccess.o
drivers/acpi/acpica/nsaccess.c:295:6: error: variable 'num_carats' set

but not used [-Werror,-Wunused-but-set-variable]

Quoted 5 lines
Quoted 5 lines
    295 |         u32 num_carats;
        |             ^

1 error generated.

I looked briefly in the code and I have no idea how to fix this, as

probably

Quoted 8 lines
Quoted 8 lines

__maybe_unused not an option for ACPICA. Hence this report.

Note, the in-tree defconfig is in use:

        git checkout v6.15-rc1
        make x86_64_defconfig

        make W=1
Quoted 9 lines

Since it's a clang, this should have also something like LLVM=1.

Quoted 1 line
Quoted 1 line

should trigger it.

--
With Best Regards,
Andy Shevchenko

Quoted 5 lines

--
With Best Regards,
Andy Shevchenko

--
With Best Regards,
Andy Shevchenko

Signature · 2 lines
With Best Regards,
Andy Shevchenko