sched_ext: Remove cpu.weight / cpu.idle unimplemented warnings
Subsystems (2)
Tejun Heo
reviewerPATCH 1/1 sched_ext: Remove cpu.weight / cpu.idle unimplemented warnings
sched_ext generates warnings when cpu.weight / cpu.idle are set to non-default values if the BPF scheduler doesn't implement weight support. These warnings don't provide much value while adding constant annoyance. A BPF scheduler may not implement any particular behavior and there's nothing particularly special about missing cgroup weight support. Drop the warnings.
--- kernel/sched/ext.c | 40 +--------------------------------------- 1 file changed, 1 insertion(+), 39 deletions(-)
kernel/sched/ext.c +1 -39
@@ -3896,34 +3896,6 @@ bool scx_can_stop_tick(struct rq *rq)DEFINE_STATIC_PERCPU_RWSEM (scx_cgroup_rwsem);static bool scx_cgroup_enabled; -static bool cgroup_warned_missing_weight; -static bool cgroup_warned_missing_idle; - -static void scx_cgroup_warn_missing_weight (struct task_group *tg) -{ -if (scx_enable_state () ==SCX_DISABLED || cgroup_warned_missing_weight) -return ; - -if ((scx_ops.flags &SCX_OPS_HAS_CGROUP_WEIGHT ) || !tg->css.parent) -return ; - -pr_warn ("sched_ext: \"%s\" does not implement cgroup cpu.weight\n" , - scx_ops.name); - cgroup_warned_missing_weight = true; -} - -static void scx_cgroup_warn_missing_idle (struct task_group *tg) -{ -if (!scx_cgroup_enabled || cgroup_warned_missing_idle) -return ; - -if (!tg->idle) -return ; - -pr_warn ("sched_ext: \"%s\" does not implement cgroup cpu.idle\n" , - scx_ops.name); - cgroup_warned_missing_idle = true; -}int scx_tg_online (struct task_group *tg) {
@@ -3933,8 +3905,6 @@ int scx_tg_online(struct task_group *tg)percpu_down_read (&scx_cgroup_rwsem); -scx_cgroup_warn_missing_weight (tg); -if (scx_cgroup_enabled) {if (SCX_HAS_OP (cgroup_init)) { struct scx_cgroup_init_args args =
@@ -4072,9 +4042,7 @@ void scx_group_set_weight(struct task_grvoid scx_group_set_idle (struct task_group *tg,bool idle) { -percpu_down_read (&scx_cgroup_rwsem); -scx_cgroup_warn_missing_idle (tg); -percpu_up_read (&scx_cgroup_rwsem); +/* TODO: Implement ops->cgroup_set_idle() */ }static void scx_cgroup_lock (void )
@@ -4268,9 +4236,6 @@ static int scx_cgroup_init(void)percpu_rwsem_assert_held (&scx_cgroup_rwsem); - cgroup_warned_missing_weight = false; - cgroup_warned_missing_idle = false; -/* * scx_tg_on/offline() are excluded through scx_cgroup_rwsem. If we walk * cgroups and init, all online cgroups are initialized.
@@ -4280,9 +4245,6 @@ static int scx_cgroup_init(void)struct task_group *tg =css_tg (css);struct scx_cgroup_init_args args = { .weight = tg->scx_weight }; -scx_cgroup_warn_missing_weight (tg); -scx_cgroup_warn_missing_idle (tg); -if ((tg->scx_flags & (SCX_TG_ONLINE |SCX_TG_INITED )) !=SCX_TG_ONLINE )continue ;
Hi Tejun,
This makes sense to me.
Regards,
Changwoo Min
Quoted 89 lines · Tejun Heo
sched_extgenerates warnings when cpu.weight / cpu.idle are set to non-default values if the BPF scheduler doesn't implement weight support. These warnings don't provide much value while adding constant annoyance. A BPF scheduler may not implement any particular behavior and there's nothing particularly special about missing cgroup weight support. Drop the warnings.Signed-off-by Tejun Heo <[email protected]>--- kernel/sched/ext.c | 40 +--------------------------------------- 1 file changed, 1 insertion(+), 39 deletions(-)kernel/sched/ext.c +1
-39@@ -3896,34 +3896,6 @@ bool scx_can_stop_tick(struct rq *rq)DEFINE_STATIC_PERCPU_RWSEM (scx_cgroup_rwsem);static bool scx_cgroup_enabled; -static bool cgroup_warned_missing_weight; -static bool cgroup_warned_missing_idle; - -static void scx_cgroup_warn_missing_weight (struct task_group *tg) -{ -if (scx_enable_state () ==SCX_DISABLED || cgroup_warned_missing_weight) -return ; - -if ((scx_ops.flags &SCX_OPS_HAS_CGROUP_WEIGHT ) || !tg->css.parent) -return ; - -pr_warn ("sched_ext: \"%s\" does not implement cgroup cpu.weight\n" , - scx_ops.name); - cgroup_warned_missing_weight = true; -} - -static void scx_cgroup_warn_missing_idle (struct task_group *tg) -{ -if (!scx_cgroup_enabled || cgroup_warned_missing_idle) -return ; - -if (!tg->idle) -return ; - -pr_warn ("sched_ext: \"%s\" does not implement cgroup cpu.idle\n" , - scx_ops.name); - cgroup_warned_missing_idle = true; -}int scx_tg_online (struct task_group *tg) {@@ -3933,8 +3905,6 @@ int scx_tg_online(struct task_group *tg)percpu_down_read (&scx_cgroup_rwsem); -scx_cgroup_warn_missing_weight (tg); -if (scx_cgroup_enabled) {if (SCX_HAS_OP (cgroup_init)) { struct scx_cgroup_init_args args =@@ -4072,9 +4042,7 @@ void scx_group_set_weight(struct task_grvoid scx_group_set_idle (struct task_group *tg,bool idle) { -percpu_down_read (&scx_cgroup_rwsem); -scx_cgroup_warn_missing_idle (tg); -percpu_up_read (&scx_cgroup_rwsem); +/* TODO: Implement ops->cgroup_set_idle() */ }static void scx_cgroup_lock (void )@@ -4268,9 +4236,6 @@ static int scx_cgroup_init(void)percpu_rwsem_assert_held (&scx_cgroup_rwsem); - cgroup_warned_missing_weight = false; - cgroup_warned_missing_idle = false; -/* * scx_tg_on/offline() are excluded through scx_cgroup_rwsem. If we walk * cgroups and init, all online cgroups are initialized. @@ -4280,9 +4245,6 @@ static int scx_cgroup_init(void)struct task_group *tg =css_tg (css);struct scx_cgroup_init_args args = { .weight = tg->scx_weight }; -scx_cgroup_warn_missing_weight (tg); -scx_cgroup_warn_missing_idle (tg); -if ((tg->scx_flags & (SCX_TG_ONLINE |SCX_TG_INITED )) !=SCX_TG_ONLINE )continue ;
Hi Tejun,
Quoted 5 lines · Tejun Heo
sched_extgenerates warnings when cpu.weight / cpu.idle are set to non-default values if the BPF scheduler doesn't implement weight support. These warnings don't provide much value while adding constant annoyance. A BPF scheduler may not implement any particular behavior and there's nothing particularly special about missing cgroup weight support. Drop the warnings.
Thanks for dropping these warnings. :)
Should we also deprecate SCX_OPS_HAS_CGROUP_WEIGHT (not necessarily in this patch)? It's basically unused at this point.
Thanks,
-Andrea
Quoted 83 lines
Signed-off-by Tejun Heo <[email protected]>--- kernel/sched/ext.c | 40 +--------------------------------------- 1 file changed, 1 insertion(+), 39 deletions(-)kernel/sched/ext.c +1
-39@@ -3896,34 +3896,6 @@ bool scx_can_stop_tick(struct rq *rq)DEFINE_STATIC_PERCPU_RWSEM (scx_cgroup_rwsem);static bool scx_cgroup_enabled; -static bool cgroup_warned_missing_weight; -static bool cgroup_warned_missing_idle; - -static void scx_cgroup_warn_missing_weight (struct task_group *tg) -{ -if (scx_enable_state () ==SCX_DISABLED || cgroup_warned_missing_weight) -return ; - -if ((scx_ops.flags &SCX_OPS_HAS_CGROUP_WEIGHT ) || !tg->css.parent) -return ; - -pr_warn ("sched_ext: \"%s\" does not implement cgroup cpu.weight\n" , - scx_ops.name); - cgroup_warned_missing_weight = true; -} - -static void scx_cgroup_warn_missing_idle (struct task_group *tg) -{ -if (!scx_cgroup_enabled || cgroup_warned_missing_idle) -return ; - -if (!tg->idle) -return ; - -pr_warn ("sched_ext: \"%s\" does not implement cgroup cpu.idle\n" , - scx_ops.name); - cgroup_warned_missing_idle = true; -}int scx_tg_online (struct task_group *tg) {@@ -3933,8 +3905,6 @@ int scx_tg_online(struct task_group *tg)percpu_down_read (&scx_cgroup_rwsem); -scx_cgroup_warn_missing_weight (tg); -if (scx_cgroup_enabled) {if (SCX_HAS_OP (cgroup_init)) { struct scx_cgroup_init_args args =@@ -4072,9 +4042,7 @@ void scx_group_set_weight(struct task_grvoid scx_group_set_idle (struct task_group *tg,bool idle) { -percpu_down_read (&scx_cgroup_rwsem); -scx_cgroup_warn_missing_idle (tg); -percpu_up_read (&scx_cgroup_rwsem); +/* TODO: Implement ops->cgroup_set_idle() */ }static void scx_cgroup_lock (void )@@ -4268,9 +4236,6 @@ static int scx_cgroup_init(void)percpu_rwsem_assert_held (&scx_cgroup_rwsem); - cgroup_warned_missing_weight = false; - cgroup_warned_missing_idle = false; -/* * scx_tg_on/offline() are excluded through scx_cgroup_rwsem. If we walk * cgroups and init, all online cgroups are initialized. @@ -4280,9 +4245,6 @@ static int scx_cgroup_init(void)struct task_group *tg =css_tg (css);struct scx_cgroup_init_args args = { .weight = tg->scx_weight }; -scx_cgroup_warn_missing_weight (tg); -scx_cgroup_warn_missing_idle (tg); -if ((tg->scx_flags & (SCX_TG_ONLINE |SCX_TG_INITED )) !=SCX_TG_ONLINE )continue ;
Quoted 7 lines · Tejun Heo
sched_extgenerates warnings when cpu.weight / cpu.idle are set to non-default values if the BPF scheduler doesn't implement weight support. These warnings don't provide much value while adding constant annoyance. A BPF scheduler may not implement any particular behavior and there's nothing particularly special about missing cgroup weight support. Drop the warnings.Signed-off-by Tejun Heo <[email protected]>
Applied to sched_ext/for-6.16.
Thanks.
Signature · 1 line
tejun
Tejun Heo
reviewerQuoted 10 lines · Tejun Heo
Quoted 7 lines · Tejun Heo
sched_extgenerates warnings when cpu.weight / cpu.idle are set to non-default values if the BPF scheduler doesn't implement weight support. These warnings don't provide much value while adding constant annoyance. A BPF scheduler may not implement any particular behavior and there's nothing particularly special about missing cgroup weight support. Drop the warnings.Signed-off-by Tejun Heo <[email protected]>Applied to sched_ext/for-6.16.
Strike that. Applied to for-6.15-fixes instead. Better to get rid of it sooner than later.
Thanks.
Signature · 1 line
tejun
Tejun Heo
reviewerPATCH 1/1 sched_ext: Mark SCX_OPS_HAS_CGROUP_WEIGHT for deprecation
In reply to Andrea RighiSCX_OPS_HAS_CGROUP_WEIGHT was only used to suppress the missing cgroup weight support warnings. Now that the warnings are removed, the flag doesn't do anything. Mark it for deprecation and remove its usage from scx_flatcg.
--- kernel/sched/ext.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
kernel/sched/ext.c +4 -1
@@ -163,7 +163,7 @@ enum scx_ops_flags {/* * CPU cgroup support flags */ -SCX_OPS_HAS_CGROUP_WEIGHT =1LLU <<16 ,/* cpu.weight */ +SCX_OPS_HAS_CGROUP_WEIGHT =1LLU <<16 ,/* DEPRECATED, will be removed on 6.18 */ SCX_OPS_ALL_FLAGS =SCX_OPS_KEEP_BUILTIN_IDLE | SCX_OPS_ENQ_LAST |
@@ -5213,6 +5213,9 @@ static int validate_ops(const struct sched_ext_ops *ops)return -EINVAL ; } +if (ops->flags &SCX_OPS_HAS_CGROUP_WEIGHT ) +pr_warn ("SCX_OPS_HAS_CGROUP_WEIGHT is deprecated and a noop\n" ); +return 0 ; }
Andrea Righi
reviewerRe: [PATCH sched_ext/for-6.15-fixes] sched_ext: Mark SCX_OPS_HAS_CGROUP_WEIGHT for deprecation
Hi Tejun,
Quoted 3 lines · Tejun Heo
SCX_OPS_HAS_CGROUP_WEIGHTwas only used to suppress the missing cgroup weight support warnings. Now that the warnings are removed, the flag doesn't do anything. Mark it for deprecation and remove its usage fromscx_flatcg.
Is the removal from scx_flatcg meant to be part of this patch, or is it intended as a follow-up? Other than that LGTM.
Thanks,
-Andrea
Quoted 30 lines
Signed-off-by Tejun Heo <[email protected]>Suggested-by Andrea Righi <[email protected]>--- kernel/sched/ext.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)kernel/sched/ext.c +4
-1@@ -163,7 +163,7 @@ enum scx_ops_flags {/* * CPU cgroup support flags */ -SCX_OPS_HAS_CGROUP_WEIGHT =1LLU <<16 ,/* cpu.weight */ +SCX_OPS_HAS_CGROUP_WEIGHT =1LLU <<16 ,/* DEPRECATED, will be removed on 6.18 */ SCX_OPS_ALL_FLAGS =SCX_OPS_KEEP_BUILTIN_IDLE | SCX_OPS_ENQ_LAST |@@ -5213,6 +5213,9 @@ static int validate_ops(const struct sched_ext_ops *ops)return -EINVAL ; } +if (ops->flags &SCX_OPS_HAS_CGROUP_WEIGHT ) +pr_warn ("SCX_OPS_HAS_CGROUP_WEIGHT is deprecated and a noop\n" ); +return 0 ; }
Tejun Heo
reviewerRe: [PATCH sched_ext/for-6.15-fixes] sched_ext: Mark SCX_OPS_HAS_CGROUP_WEIGHT for deprecation
Quoted 9 lines · Andrea Righi
Hi Tejun,
Quoted 3 lines · Tejun Heo
SCX_OPS_HAS_CGROUP_WEIGHTwas only used to suppress the missing cgroup weight support warnings. Now that the warnings are removed, the flag doesn't do anything. Mark it for deprecation and remove its usage fromscx_flatcg.Is the removal from
scx_flatcgmeant to be part of this patch, or is it intended as a follow-up? Other than that LGTM.
Oh, sorry about that. Lemme send v2.
Thanks.
Signature · 1 line
tejun
Tejun Heo
reviewerPATCH v2 1/1 sched_ext: Mark SCX_OPS_HAS_CGROUP_WEIGHT for deprecation
In reply to Tejun HeoSCX_OPS_HAS_CGROUP_WEIGHT was only used to suppress the missing cgroup weight support warnings. Now that the warnings are removed, the flag doesn't do anything. Mark it for deprecation and remove its usage from scx_flatcg.
v2: Actually include the scx_flatcg update.
--- kernel/sched/ext.c | 5 ++++- tools/sched_ext/scx_flatcg.bpf.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-)
kernel/sched/ext.c +4 -1
@@ -163,7 +163,7 @@ enum scx_ops_flags {/* * CPU cgroup support flags */ -SCX_OPS_HAS_CGROUP_WEIGHT =1LLU <<16 ,/* cpu.weight */ +SCX_OPS_HAS_CGROUP_WEIGHT =1LLU <<16 ,/* DEPRECATED, will be removed on 6.18 */ SCX_OPS_ALL_FLAGS =SCX_OPS_KEEP_BUILTIN_IDLE | SCX_OPS_ENQ_LAST |
@@ -5213,6 +5213,9 @@ static int validate_ops(const struct sched_ext_ops *ops)return -EINVAL ; } +if (ops->flags &SCX_OPS_HAS_CGROUP_WEIGHT ) +pr_warn ("SCX_OPS_HAS_CGROUP_WEIGHT is deprecated and a noop\n" ); +return 0 ; }
tools/sched_ext/scx_flatcg.bpf.c +1 -1
@@ -950,5 +950,5 @@ SCX_OPS_DEFINE(flatcg_ops, .cgroup_move = (void *)fcg_cgroup_move, .init = (void *)fcg_init, .exit = (void *)fcg_exit, - .flags = SCX_OPS_HAS_CGROUP_WEIGHT | SCX_OPS_ENQ_EXITING, + .flags = SCX_OPS_ENQ_EXITING, .name = "flatcg");
Re: [PATCH v2 sched_ext/for-6.15-fixes] sched_ext: Mark SCX_OPS_HAS_CGROUP_WEIGHT for deprecation
Quoted 8 lines · Tejun Heo
SCX_OPS_HAS_CGROUP_WEIGHTwas only used to suppress the missing cgroup weight support warnings. Now that the warnings are removed, the flag doesn't do anything. Mark it for deprecation and remove its usage fromscx_flatcg.v2: Actually include the
scx_flatcgupdate.Signed-off-by Tejun Heo <[email protected]>Suggested-by Andrea Righi <[email protected]>
Looks good, thanks!
-Andrea
Quoted 39 lines
--- kernel/sched/ext.c | 5 ++++- tools/sched_ext/scx_flatcg.bpf.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-)kernel/sched/ext.c +4
-1@@ -163,7 +163,7 @@ enum scx_ops_flags {/* * CPU cgroup support flags */ -SCX_OPS_HAS_CGROUP_WEIGHT =1LLU <<16 ,/* cpu.weight */ +SCX_OPS_HAS_CGROUP_WEIGHT =1LLU <<16 ,/* DEPRECATED, will be removed on 6.18 */ SCX_OPS_ALL_FLAGS =SCX_OPS_KEEP_BUILTIN_IDLE | SCX_OPS_ENQ_LAST |@@ -5213,6 +5213,9 @@ static int validate_ops(const struct sched_ext_ops *ops)return -EINVAL ; } +if (ops->flags &SCX_OPS_HAS_CGROUP_WEIGHT ) +pr_warn ("SCX_OPS_HAS_CGROUP_WEIGHT is deprecated and a noop\n" ); +return 0 ; }tools/sched_ext/scx_flatcg.bpf.c +1
-1@@ -950,5 +950,5 @@ SCX_OPS_DEFINE(flatcg_ops, .cgroup_move = (void *)fcg_cgroup_move, .init = (void *)fcg_init, .exit = (void *)fcg_exit, - .flags = SCX_OPS_HAS_CGROUP_WEIGHT | SCX_OPS_ENQ_EXITING, + .flags = SCX_OPS_ENQ_EXITING, .name = "flatcg");
Re: [PATCH v2 sched_ext/for-6.15-fixes] sched_ext: Mark SCX_OPS_HAS_CGROUP_WEIGHT for deprecation
In reply to Tejun HeoQuoted 8 lines · Tejun Heo
SCX_OPS_HAS_CGROUP_WEIGHTwas only used to suppress the missing cgroup weight support warnings. Now that the warnings are removed, the flag doesn't do anything. Mark it for deprecation and remove its usage fromscx_flatcg.v2: Actually include the
scx_flatcgupdate.Signed-off-by Tejun Heo <[email protected]>Suggested-by Andrea Righi <[email protected]>
Applied to sched_ext/for-6.15-fixes. Thanks.
Signature · 1 line
tejun