perf libunwind arm64: Fix missing close parens in an if statement
Arnaldo Carvalho de Melo
maintainerPATCH 1/1 perf libunwind arm64: Fix missing close parens in an if statement
While testing building with libunwind (using LIBUNWIND=1) in various arches I noticed a problem on arm64, on an rpi5 system, a missing close parens in a change related to dso__data_get_fd() usage, fix it.
Fixes 5ac22c35aa8519f1 ("perf dso: Use lock annotations to fix asan deadlock")
Cc Adrian Hunter <[email protected]>
Cc Ian Rogers <[email protected]>
Cc James Clark <[email protected]>
Cc Jiri Olsa <[email protected]>
Cc Kan Liang <[email protected]>
Cc Namhyung Kim <[email protected]>
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- tools/perf/util/unwind-libunwind-local.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/unwind-libunwind-local.c +1 -1
@@ -371,7 +371,7 @@ static int read_unwind_spec_debug_frame(struct dso *dso,* has to be pointed by symsrc_filename */ if (ofs ==0 ) { - if (dso__data_get_fd(dso, machine, &fd) { +if (dso__data_get_fd (dso, machine, &fd)) { ofs =elf_section_offset (fd,".debug_frame" );dso__data_put_fd (dso); }
Signature · 1 line
2.48.1
Namhyung Kim
maintainerQuoted 4 lines · Arnaldo Carvalho de Melo
While testing building with libunwind (using LIBUNWIND=1) in various arches I noticed a problem on arm64, on an rpi5 system, a missing close parens in a change related to
dso__data_get_fd()usage, fix it.
Quoted 8 lines
Fixes 5ac22c35aa8519f1 ("perf dso: Use lock annotations to fix asan deadlock")Cc Adrian Hunter <[email protected]>Cc Ian Rogers <[email protected]>Cc James Clark <[email protected]>Cc Jiri Olsa <[email protected]>Cc Kan Liang <[email protected]>Cc Namhyung Kim <[email protected]>Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
Thanks for fixing this. For some reason the build test couldn't detect it on my system (I have libunwind-dev installed).
I'll add it to perf-tools tree.
Thanks,
Namhyung
Quoted 20 lines
--- tools/perf/util/unwind-libunwind-local.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/unwind-libunwind-local.c +1
-1@@ -371,7 +371,7 @@ static int read_unwind_spec_debug_frame(struct dso *dso,* has to be pointed by symsrc_filename */ if (ofs ==0 ) { - if (dso__data_get_fd(dso, machine, &fd) { +if (dso__data_get_fd (dso, machine, &fd)) { ofs =elf_section_offset (fd,".debug_frame" );dso__data_put_fd (dso); }Signature · 1 line
2.48.1