Skip to contentSkip to conversation

bcachefs: Fix build on parisc by avoiding __multi3()

PATCH New Helge Deller 1 participant 1 message Jan 28, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcachefs: Fix build on parisc by avoiding __multi3()

The gcc compiler on paric does support the __int128 type, although the architecture does not have native 128-bit support.

The effect is, that the bcachefs u128_square() function will pull in the libgcc __multi3() helper, which breaks the kernel build when bcachefs is built as module since this function isn't currently exported in arch/parisc/kernel/parisc_ksyms.c.
The build failure can be seen in the latest debian kernel build at:
https://buildd.debian.org/status/fetch.php?pkg=linux&arch=hppa&ver=6.7.1-1%7Eexp1&stamp=1706132569&raw=0

We prefer to not export that symbol, so fall back to the optional 64-bit implementation provided by bcachefs and thus avoid usage of __multi3().

Cc Kent Overstreet <[email protected]>
fs/bcachefs/mean_and_variance.h +1 -1
index b2be565bb8f2..64df11ab422b 100644
@@ -17,7 +17,7 @@
  * Rust and rustc has issues with u128.
  */
 
-#if defined(__SIZEOF_INT128__) && defined(__KERNEL__)
+#if defined(__SIZEOF_INT128__) && defined(__KERNEL__) && !defined(CONFIG_PARISC)
 
 typedef struct {
 	unsigned __int128 v;