Skip to contentSkip to conversation

driver: core: add dedicated workqueue for devlink removal

PATCH Andy Shevchenko 1 participant 1 message Feb 5, 2024 ACPI

lore
Share & tools
lore
#0 lore raw
Quoted 9 lines · On Fri, Feb 02, 2024 at 01:18:16PM +0100, Nuno Sa via B4 Relay wrote:

From: Nuno Sa <[email protected]>

Let's use a dedicated queue for devlinks since releasing a link happens asynchronously but some code paths, like DT overlays, have some expectations regarding the of_node when being removed (the refcount must be 1). Given how devlinks are released that cannot be assured. Hence, add a dedicated queue so that it's easy to sync against devlinks removal.

While at it, make sure to explicitly include <linux/workqueue.h>.

...

include/linux/fwnode.h extern bool fw_devlink_is_strict(void); · line 216

Quoted 7 lines
include/linux/fwnode.h +1 -0
@@ -213,5 +213,6 @@ extern bool fw_devlink_is_strict(void);
 int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
 void fwnode_links_purge(struct fwnode_handle *fwnode);
 void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode);
+void fwnode_links_flush_queue(void);

Can it be grouped like

  void fwnode_links_flush_queue(void);
  void fwnode_links_purge(struct fwnode_handle *fwnode);
  void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode);

?

(devlinks namespaces seems a bit messy to me, but I'm not familiar with that
code at all)

Signature · 2 lines
With Best Regards,
Andy Shevchenko