Skip to contentSkip to conversation

staging: sm750fb: rename function deGetTransparency()

PATCH In review Samuel Kayode 2 participants 2 messages Feb 23, 2024 – Mar 5, 2024

Subsystems (3)
Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Samuel Kayode

author
#0 lore raw

PATCH 1/1 staging: sm750fb: rename function deGetTransparency()

Rename function deGetTransparency to de_get_transparency to fix checkpatch warning Avoid CamelCase.

Signed-off-by Samuel Kayode <[email protected]>
---
 drivers/staging/sm750fb/sm750_accel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/sm750_accel.c +2 -2
index 44b9e3fe3a41..ad9d8bd34e5a 100644
@@ -284,7 +284,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
 	return 0;
 }
 
-static unsigned int deGetTransparency(struct lynx_accel *accel)
+static unsigned int de_get_transparency(struct lynx_accel *accel)
 {
 	unsigned int de_ctrl;
 

@@ -391,7 +391,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf,
 		DE_CONTROL_ROP_SELECT | DE_CONTROL_COMMAND_HOST_WRITE |
 		DE_CONTROL_HOST | DE_CONTROL_STATUS;
 
-	write_dpr(accel, DE_CONTROL, de_ctrl | deGetTransparency(accel));
+	write_dpr(accel, DE_CONTROL, de_ctrl | de_get_transparency(accel));
 
 	/* Write MONO data (line by line) to 2D Engine data port */
 	for (i = 0; i < height; i++) {
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 13 lines · Samuel Kayode

Rename function deGetTransparency to de_get_transparency to fix checkpatch warning Avoid CamelCase.

Signed-off-by Samuel Kayode <[email protected]>
---
 drivers/staging/sm750fb/sm750_accel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm750fb/sm750_accel.c +0 -0
index 44b9e3fe3a41..ad9d8bd34e5a 100644

drivers/staging/sm750fb/sm750_accel.c int sm750_hw_copyarea(struct lynx_accel *accel, · line 287

Quoted 5 lines
drivers/staging/sm750fb/sm750_accel.c +1 -1
@@ -284,7 +284,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
 	return 0;
 }
 
-static unsigned int deGetTransparency(struct lynx_accel *accel)
+static unsigned int de_get_transparency(struct lynx_accel *accel)

What does "de_" here mean? Why did you keep it?

thanks,

greg k-h