Fix typo in reporting-regressions.rst
Subsystems (2)
PATCH 1/1 Fix typo in reporting-regressions.rst
Append a ':' character to the first usage of "#regzbot introduced".
According to the regzbot documentation, the ':' suffix is the correct format, and, even if not strictly necessary, it is good to be consistent.
--- Documentation/admin-guide/reporting-regressions.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/admin-guide/reporting-regressions.rst +1 -1
@@ -31,7 +31,7 @@ The important bits (aka "TL;DR") Linux kernel regression tracking bot "regzbot" track the issue by specifying when the regression started like this:: - #regzbot introduced v5.13..v5.14-rc1 + #regzbot introduced: v5.13..v5.14-rc1 All the details on Linux kernel regressions relevant for users
Signature · 1 line
2.39.2
Thorsten Leemhuis
maintainer[CCing Nícolas]
On 07.03.24 19:10, Chris Bainbridge wrote:
First off: many thx for this, much appreciated!
Quoted 1 line
Append a ':' character to the first usage of "#regzbot introduced".
FWIW, that is obvious and not needed here; but having it in the subject would be good. The subject also does not really match the expected style. But let's ignore that for now due the aspect mentioned below.
Quoted 3 lines
According to the regzbot documentation, the ':' suffix is the correct format, and, even if not strictly necessary, it is good to be consistent.
Sadly a slightly tricky situation developed coincidentally: Nícolas not even 24 hours later send a patch that fixes this as well, but does so in a related document as well, which is wise:
https://lore.kernel.org/all/[email protected]/
Which leads to the question: how much do you care that you patch makes it in? If you would like to have a fresh commit in the kernel (which is totally valid thing to want!) we definitely could improve your submission and then adjust Nícolas changes on top of it -- but if you don't care at all we could just directly take Nícolas patch.
Ciao, Thorsten
Quoted 5 lines · Thorsten Leemhuis
Which leads to the question: how much do you care that you patch makes it in? If you would like to have a fresh commit in the kernel (which is totally valid thing to want!) we definitely could improve your submission and then adjust Nícolas changes on top of it -- but if you don't care at all we could just directly take Nícolas patch.
I don't care - just take the other patch. But please fix the multiple incorrect spellings of colon ('collon') first.
Quoted 8 lines · Chris Bainbridge
Quoted 5 lines · Thorsten Leemhuis
Which leads to the question: how much do you care that you patch makes it in? If you would like to have a fresh commit in the kernel (which is totally valid thing to want!) we definitely could improve your submission and then adjust Nícolas changes on top of it -- but if you don't care at all we could just directly take Nícolas patch.
I don't care - just take the other patch.
Okay, many thx for this!
Quoted 2 lines
But please fix the multiple
incorrect spellings of colon ('collon') first.
:-D Will bring this up when reviewing (but I guess I only will get around to that tomorrow).
Thx again!
Ciao, Thorsten
Quoted 9 lines · Chris Bainbridge
Quoted 5 lines · Thorsten Leemhuis
Which leads to the question: how much do you care that you patch makes it in? If you would like to have a fresh commit in the kernel (which is totally valid thing to want!) we definitely could improve your submission and then adjust Nícolas changes on top of it -- but if you don't care at all we could just directly take Nícolas patch.
I don't care - just take the other patch. But please fix the multiple incorrect spellings of colon ('collon') first.
Oh wow, I looked it up before writing and was confident that was the right spelling... Thanks for pointing it out, will fix in v2 after Thorsten gives any other feedback he might have.
Thanks,
Nícolas