Skip to contentSkip to conversation

GPIO drivers under drivers/char/

DISCUSSION Andy Shevchenko 2 participants 3 messages May 10, 2024 – May 11, 2024 GPIO

lore
Share & tools
lore
#0 lore raw

Hi!

Due to patch bomb from Jens, I noticed that we have two interesting drivers (and a common library) under drivers/char/. Shouldn't we move them to drivers/gpio/ to keep an eye on that (with the respective update of MAINTAINERS if needed)? Also William might say something about this since those are old ISA (?) related ones and (perhaps?) might utilise PC-104 code.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#1 lore raw

(Update William's email; btw, William, it seems MAINTAINERS need an update, or .mailcap)

Quoted 7 lines · Andy Shevchenko

Hi!

Due to patch bomb from Jens, I noticed that we have two interesting drivers (and a common library) under drivers/char/. Shouldn't we move them to drivers/gpio/ to keep an eye on that (with the respective update of MAINTAINERS if needed)? Also William might say something about this since those are old ISA (?) related ones and (perhaps?) might utilise PC-104 code.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 14 lines · Andy Shevchenko

(Update William's email; btw, William, it seems MAINTAINERS need an update, or .mailcap)

Quoted 7 lines · Andy Shevchenko

Hi!

Due to patch bomb from Jens, I noticed that we have two interesting drivers (and a common library) under drivers/char/. Shouldn't we move them to drivers/gpio/ to keep an eye on that (with the respective update of MAINTAINERS if needed)? Also William might say something about this since those are old ISA (?) related ones and (perhaps?) might utilise PC-104 code.

Signature · 2 lines
With Best Regards,
Andy Shevchenko

Thank you for the forward; I'm updating MAINTAINERS to match my kernel.org address from now on so that we don't have this problem again in the future. :-)

Regarding the gpio char drivers, I take it you are referring to the nsc_gpio used by scx200_gpio and pc8736x_gpio. I agree, these should be moved to the GPIO subsystem so they're with the old GPIO drivers (and ported to the standard GPIO interface we have there if they're not already).

Taking a quick look, neither of these are PC-104 devices, but rather appear to be part of the Super I/O chip. Regardless, the driver interface can be the same since they're both performing ioport operations over an ISA bus essentially. You can utilize include/linux/isa.h and leverage the module_isa_driver() like what we do in the gpio-mm driver.

William Breathitt Gray