Incorrect thinlto cache directory path in Makefile
Hi,
Xu Zhen <[email protected]> reported on Bugzilla (https://bugzilla.kernel.org/show_bug.cgi?id=218825) thinlto build directory problem (especially on
Quoted 5 lines · DKMS modules). He
In
Makefile, the ld flag--thinlto-cache-dir' is set to$(extmod_prefix).thinlto-cache'. But at that time, the variableextmod_prefixhad not been assigned yet. Therefore, the thinlto cache dir is always created in the current directory.
Quoted 7 lines
Even worse, the cache dir cannot be deleted when executing
make clean'. This is because its path was written as$(KBUILD_EXTMOD)/.thinlto-cache' in the
clean: target.Some users have been troubled by it: https://github.com/dell/dkms/issues/292
This bug was introduced by commit
dc5723b02e523b2c4a68667f7e28c65018f7202f
Thanks.
Signature · 1 line
An old man doll... just what I always wanted! - Clara
+CC: Nathan
Quoted 18 lines · Bagas Sanjaya
Hi,
Xu Zhen <[email protected]> reported on Bugzilla (https://bugzilla.kernel.org/show_bug.cgi?id=218825) thinlto build directory problem (especially on
Quoted 12 lines · DKMS modules). He
In
Makefile, the ld flag--thinlto-cache-dir' is set to$(extmod_prefix).thinlto-cache'. But at that time, the variableextmod_prefixhad not been assigned yet. Therefore, the thinlto cache dir is always created in the current directory.Even worse, the cache dir cannot be deleted when executing
make clean'. This is because its path was written as$(KBUILD_EXTMOD)/.thinlto-cache' in the
clean: target.Some users have been troubled by it: https://github.com/dell/dkms/issues/292
This bug was introduced by commit
dc5723b02e523b2c4a68667f7e28c65018f7202f
I agree this is a bug.
line 945:
KBUILD_LDFLAGS += --thinlto-cache-dir=$(extmod_prefix).thinlto-cache
line 1034:
KBUILD_LDFLAGS += $(call ld-option,--no-warn-rwx-segments)
line 1095:
export extmod_prefix = $(if $(KBUILD_EXTMOD),$(KBUILD_EXTMOD)/)
$(call ld-option ) at line 1034 adds --thinlto-cache-dir=.thinlto-cache because --thinlto-cache-dir=$(extmod_prefix).thinlto-cache was added at line 945, but $(extmod_prefix) is empty until it is defined at line 1095.
However, the offending line was already removed for another issue.
See the following in linux-next:
Author: Nathan Chancellor <[email protected]> Date: Wed May 1 15:55:25 2024 -0700
kbuild: Remove support for Clang's ThinLTO caching
If --thinlto-cache-dir comes back,
I hope Nathan will take care of this issue.
Quoted 4 lines
Thanks.
--
An old man doll... just what I always wanted! - Clara
Signature · 2 lines
Best Regards Masahiro Yamada
Quoted 30 lines · Masahiro Yamada
+CC: Nathan
Quoted 18 lines · Bagas Sanjaya
Hi,
Xu Zhen <[email protected]> reported on Bugzilla (https://bugzilla.kernel.org/show_bug.cgi?id=218825) thinlto build directory problem (especially on
Quoted 12 lines · DKMS modules). He
In
Makefile, the ld flag--thinlto-cache-dir' is set to$(extmod_prefix).thinlto-cache'. But at that time, the variableextmod_prefixhad not been assigned yet. Therefore, the thinlto cache dir is always created in the current directory.Even worse, the cache dir cannot be deleted when executing
make clean'. This is because its path was written as$(KBUILD_EXTMOD)/.thinlto-cache' in the
clean: target.Some users have been troubled by it: https://github.com/dell/dkms/issues/292
This bug was introduced by commit
dc5723b02e523b2c4a68667f7e28c65018f7202fI agree this is a bug.
Quoted 6 lines
line 945:
KBUILD_LDFLAGS+= --thinlto-cache-dir=$(extmod_prefix).thinlto-cacheline 1034:
KBUILD_LDFLAGS+= $(call ld-option,--no-warn-rwx-segments)
This one is probably OK because it is guarded by CONFIG_LD_IS_BFD, while LTO requires LD_IS_LLD.
I see another ld-option at 1043.
LDFLAGS_vmlinux += $(call ld-option,--pack-dyn-relocs=relr,-z
pack-relative-relocs)
Maybe, this is related to the issue
(although I did not attempt to reproduce it).
Signature · 2 lines
Best Regards Masahiro Yamada