Skip to contentSkip to conversation

hppa/vdso: Add wrappers for vDSO functions

PATCH In review Helge Deller 4 participants 8 messages Jun 21, 2024 – Jul 2, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 hppa/vdso: Add wrappers for vDSO functions

The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO support for gettimeofday(), clock_gettime() and clock_gettime64() syscalls for 32- and 64-bit userspace.
The patch below adds the necessary glue code for glibc.

Changes in v2:
- add vsyscalls for 64-bit too

sysdeps/unix/sysv/linux/hppa/sysdep.h renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org +12 -0
diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h
@@ -468,6 +468,18 @@ L(pre_end):					ASM_LINE_SEP	\
 #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
 #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
 
+#define VDSO_NAME	"LINUX_6.11"
+#define VDSO_HASH	182951793
+
+#ifdef __LP64__
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#else
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#endif /* __LP64__ */
+
 #endif	/* __ASSEMBLER__ */
 
 #endif /* _LINUX_HPPA_SYSDEP_H */
#1 lore raw

Committed to glibc master.

Dave

Quoted 33 lines · Helge Deller

The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO support for gettimeofday(), clock_gettime() and clock_gettime64() syscalls for 32- and 64-bit userspace.
The patch below adds the necessary glue code for glibc.

Changes in v2:
- add vsyscalls for 64-bit too

diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h

sysdeps/unix/sysv/linux/hppa/sysdep.h renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org +12 -0
@@ -468,6 +468,18 @@ L(pre_end):					ASM_LINE_SEP	\
  #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
  #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
 
+#define VDSO_NAME	"LINUX_6.11"
+#define VDSO_HASH	182951793
+
+#ifdef __LP64__
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#else
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#endif /* __LP64__ */
+
  #endif	/* __ASSEMBLER__ */
 
  #endif /* _LINUX_HPPA_SYSDEP_H */
Signature · 1 line
John David Anglin  [email protected]
#2 lore raw
In reply to Helge Deller
Quoted 20 lines · Helge Deller

The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO support for gettimeofday(), clock_gettime() and clock_gettime64() syscalls for 32- and 64-bit userspace.
The patch below adds the necessary glue code for glibc.

Changes in v2:
- add vsyscalls for 64-bit too

diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h

sysdeps/unix/sysv/linux/hppa/sysdep.h renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org +3 -0
@@ -468,6 +468,18 @@ L(pre_end):					ASM_LINE_SEP	\
 #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
 #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
 
+#define VDSO_NAME	"LINUX_6.11"
+#define VDSO_HASH	182951793
+

sysdeps/unix/sysv/linux/hppa/sysdep.h L(pre_end): ASM_LINE_SEP \ · line 483

Quoted 10 lines
sysdeps/unix/sysv/linux/hppa/sysdep.h renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org +9 -0
+#ifdef __LP64__
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#else
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#endif /* __LP64__ */
+
 #endif	/* __ASSEMBLER__ */

Not sure why you have added the gettimeofday support, currently 32 bits it is already routed to to clock_gettime (which will use __vdso_clock_gettime64 anyway). For hppa to actually use, it would require to add a way to call it for !USE_IFUNC_GETTIMEOFDAY gettimeofday, which I am not it really be an improvement here.

#3 lore raw
Quoted 29 lines · Adhemerval Zanella Netto
Quoted 26 lines · Helge Deller

The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO support for gettimeofday(), clock_gettime() and clock_gettime64() syscalls for 32- and 64-bit userspace.
The patch below adds the necessary glue code for glibc.

Changes in v2:
- add vsyscalls for 64-bit too

diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h

sysdeps/unix/sysv/linux/hppa/sysdep.h renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org +9 -0
@@ -468,6 +468,18 @@ L(pre_end):					ASM_LINE_SEP	\
  #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
  #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
 
+#define VDSO_NAME	"LINUX_6.11"
+#define VDSO_HASH	182951793
+
+#ifdef __LP64__
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#else
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
Quoted 8 lines

sysdeps/unix/sysv/linux/hppa/sysdep.h L(pre_end): ASM_LINE_SEP \ · line 483

Quoted 4 lines
sysdeps/unix/sysv/linux/hppa/sysdep.h renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org +3 -0
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#endif /* __LP64__ */
+
  #endif	/* __ASSEMBLER__ */

Not sure why you have added the gettimeofday support, currently 32 bits it is already routed to to clock_gettime (which will use __vdso_clock_gettime64 anyway).

Yep, you are right.
I actually didn't checked if it's being used but just saw it's defined for other arches too, so I assumed it to be used.

Quoted 3 lines

For hppa to actually use, it would require to add a way to call it for !USE_IFUNC_GETTIMEOFDAY gettimeofday, which I am not it really be an improvement here.

Yes, that doesn't make sense.

Looking at the code it seems riscv, sparc, arm, mips and s390 define it too, without being used. Do you suggest we should remove gettimeofday vsyscall from hppa again (or just keep like the others even if not being used)?

Helge

#4 lore raw
Quoted 47 lines · Helge Deller
Quoted 29 lines · Adhemerval Zanella Netto
Quoted 26 lines · Helge Deller

The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO support for gettimeofday(), clock_gettime() and clock_gettime64() syscalls for 32- and 64-bit userspace.
The patch below adds the necessary glue code for glibc.

Changes in v2:
- add vsyscalls for 64-bit too

diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h

sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org    2024-06-15 20:20:58.992000000 +0000 +9 -0
@@ -468,6 +468,18 @@ L(pre_end):                    ASM_LINE_SEP    \
   #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
   #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
 
+#define VDSO_NAME    "LINUX_6.11"
+#define VDSO_HASH    182951793
+
+#ifdef __LP64__
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#else
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
Quoted 8 lines

sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 L(pre_end):                    ASM_LINE_SEP    \ · line 483

Quoted 4 lines
sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org    2024-06-15 20:20:58.992000000 +0000 +3 -0
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#endif /* __LP64__ */
+
   #endif    /* __ASSEMBLER__ */

Not sure why you have added the gettimeofday support, currently 32 bits it is already routed to to clock_gettime (which will use __vdso_clock_gettime64 anyway).

Yep, you are right.
I actually didn't checked if it's being used but just saw it's defined for other arches too, so I assumed it to be used.

Quoted 3 lines

For hppa to actually use, it would require to add a way to call it for !USE_IFUNC_GETTIMEOFDAY gettimeofday, which I am not it really be an improvement here.

Quoted 5 lines

Yes, that doesn't make sense.

Looking at the code it seems riscv, sparc, arm, mips and s390 define it too, without being used. Do you suggest we should remove gettimeofday vsyscall from hppa again (or just keep like the others even if not being used)?

The riscv only added it for CONFIG_64BIT, while old ABIs like arm, sparc, mips, and s390 added before 64 bit time_t landed on 5.1. With current 32 bits ABIs moving to 64 bit time_t userland, there is no much sense in providing a 32 bit gettimeofday, nor I think I adding a gettimeoday64 would make much sense (maybe on really high sensitive workloads that require low-latency timestamping, but clock_gettime would work better anyway).

It is highly unlikely that the symbol will ever be used by userland, and I think it only make sense to provide clock_gettime64. The glibc 32 bit time_t clock_gettime routes to clock_gettime64 and it will only fallback to 32 bit vDSO symbol if the 64 bit time_t one is not present.

#5 lore raw

* Adhemerval Zanella Netto <[email protected]>:

Quoted 62 lines · Helge Deller
Quoted 47 lines · Adhemerval Zanella Netto
Quoted 29 lines · Helge Deller
Quoted 26 lines

The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO support for gettimeofday(), clock_gettime() and clock_gettime64() syscalls for 32- and 64-bit userspace.
The patch below adds the necessary glue code for glibc.

Changes in v2:
- add vsyscalls for 64-bit too

diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h

sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org    2024-06-15 20:20:58.992000000 +0000 +9 -0
@@ -468,6 +468,18 @@ L(pre_end):                    ASM_LINE_SEP    \
   #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
   #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
 
+#define VDSO_NAME    "LINUX_6.11"
+#define VDSO_HASH    182951793
+
+#ifdef __LP64__
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#else
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
Quoted 8 lines

sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 L(pre_end):                    ASM_LINE_SEP    \ · line 483

Quoted 4 lines
sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org    2024-06-15 20:20:58.992000000 +0000 +3 -0
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#endif /* __LP64__ */
+
   #endif    /* __ASSEMBLER__ */

Not sure why you have added the gettimeofday support, currently 32 bits it is already routed to to clock_gettime (which will use __vdso_clock_gettime64 anyway).

Yep, you are right.
I actually didn't checked if it's being used but just saw it's defined for other arches too, so I assumed it to be used.

Quoted 3 lines

For hppa to actually use, it would require to add a way to call it for !USE_IFUNC_GETTIMEOFDAY gettimeofday, which I am not it really be an improvement here.

Quoted 5 lines

Yes, that doesn't make sense.

Looking at the code it seems riscv, sparc, arm, mips and s390 define it too, without being used. Do you suggest we should remove gettimeofday vsyscall from hppa again (or just keep like the others even if not being used)?

The riscv only added it for CONFIG_64BIT, while old ABIs like arm, sparc, mips, and s390 added before 64 bit time_t landed on 5.1. With current 32 bits ABIs moving to 64 bit time_t userland, there is no much sense in providing a 32 bit gettimeofday, nor I think I adding a gettimeoday64 would make much sense (maybe on really high sensitive workloads that require low-latency timestamping, but clock_gettime would work better anyway).

Quoted 4 lines

It is highly unlikely that the symbol will ever be used by userland, and I think it only make sense to provide clock_gettime64. The glibc 32 bit time_t clock_gettime routes to clock_gettime64 and it will only fallback to 32 bit vDSO symbol if the 64 bit time_t one is not present.

Like patch below?
Helge

[PATCH] hppa/vdso: Provide 64-bit clock_gettime() vDSO only

Adhemerval noticed that the gettimeofday() and 32-bit clock_gettime() vDSO calls won't be used by glibc on hppa, so there is no need to declare them. Both syscalls will be emulated by utilizing return values of the 64-bit clock_gettime() vDSO instead..

sysdeps/unix/sysv/linux/hppa/sysdep.h +0 -3
index af62f7501e..e47975e5cf 100644
@@ -473,11 +473,8 @@ L(pre_end):					ASM_LINE_SEP	\
 
 #ifdef __LP64__
 # define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
-# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
 #else
-# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
 # define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
-# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
 #endif /* __LP64__ */
 
 #endif	/* __ASSEMBLER__ */
#6 lore raw
Quoted 88 lines · Helge Deller

* Adhemerval Zanella Netto <[email protected]>:

Quoted 62 lines · Helge Deller
Quoted 47 lines · Adhemerval Zanella Netto
Quoted 29 lines · Helge Deller
Quoted 26 lines

The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO support for gettimeofday(), clock_gettime() and clock_gettime64() syscalls for 32- and 64-bit userspace.
The patch below adds the necessary glue code for glibc.

Changes in v2:
- add vsyscalls for 64-bit too

diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h

sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org    2024-06-15 20:20:58.992000000 +0000 +9 -0
@@ -468,6 +468,18 @@ L(pre_end):                    ASM_LINE_SEP    \
   #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
   #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
 
+#define VDSO_NAME    "LINUX_6.11"
+#define VDSO_HASH    182951793
+
+#ifdef __LP64__
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#else
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
Quoted 8 lines

sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 L(pre_end):                    ASM_LINE_SEP    \ · line 483

Quoted 4 lines
sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org    2024-06-15 20:20:58.992000000 +0000 +3 -0
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#endif /* __LP64__ */
+
   #endif    /* __ASSEMBLER__ */

Not sure why you have added the gettimeofday support, currently 32 bits it is already routed to to clock_gettime (which will use __vdso_clock_gettime64 anyway).

Yep, you are right.
I actually didn't checked if it's being used but just saw it's defined for other arches too, so I assumed it to be used.

Quoted 3 lines

For hppa to actually use, it would require to add a way to call it for !USE_IFUNC_GETTIMEOFDAY gettimeofday, which I am not it really be an improvement here.

Quoted 5 lines

Yes, that doesn't make sense.

Looking at the code it seems riscv, sparc, arm, mips and s390 define it too, without being used. Do you suggest we should remove gettimeofday vsyscall from hppa again (or just keep like the others even if not being used)?

The riscv only added it for CONFIG_64BIT, while old ABIs like arm, sparc, mips, and s390 added before 64 bit time_t landed on 5.1. With current 32 bits ABIs moving to 64 bit time_t userland, there is no much sense in providing a 32 bit gettimeofday, nor I think I adding a gettimeoday64 would make much sense (maybe on really high sensitive workloads that require low-latency timestamping, but clock_gettime would work better anyway).

Quoted 4 lines

It is highly unlikely that the symbol will ever be used by userland, and I think it only make sense to provide clock_gettime64. The glibc 32 bit time_t clock_gettime routes to clock_gettime64 and it will only fallback to 32 bit vDSO symbol if the 64 bit time_t one is not present.

Like patch below?
Helge

[PATCH] hppa/vdso: Provide 64-bit clock_gettime() vDSO only

Adhemerval noticed that the gettimeofday() and 32-bit clock_gettime() vDSO calls won't be used by glibc on hppa, so there is no need to declare them. Both syscalls will be emulated by utilizing return values of the 64-bit clock_gettime() vDSO instead..

sysdeps/unix/sysv/linux/hppa/sysdep.h +0 -0
index af62f7501e..e47975e5cf 100644
@@ -473,11 +473,8 @@ L(pre_end):					ASM_LINE_SEP	\
 

sysdeps/unix/sysv/linux/hppa/sysdep.h L(pre_end): ASM_LINE_SEP \ · line 480

Quoted 10 lines
sysdeps/unix/sysv/linux/hppa/sysdep.h +0 -3
 #ifdef __LP64__
 # define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
-# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
 #else
-# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
 # define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
-# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
 #endif /* __LP64__ */
 
 #endif	/* __ASSEMBLER__ */

Yeah, it seems ok thanks.

#7 lore raw

Committed to glibc master.

Dave

Quoted 94 lines · Adhemerval Zanella Netto
Quoted 81 lines · Helge Deller

* Adhemerval Zanella Netto <[email protected]>:

Quoted 56 lines · Helge Deller
Quoted 40 lines · Adhemerval Zanella Netto
Quoted 19 lines · Helge Deller
Quoted 17 lines

The upcoming parisc (hppa) v6.11 Linux kernel will include vDSO support for gettimeofday(), clock_gettime() and clock_gettime64() syscalls for 32- and 64-bit userspace.
The patch below adds the necessary glue code for glibc.

Changes in v2:
- add vsyscalls for 64-bit too

diff -up ./sysdeps/unix/sysv/linux/hppa/sysdep.h.org ./sysdeps/unix/sysv/linux/hppa/sysdep.h

sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org    2024-06-15 20:20:58.992000000 +0000 +0 -0
@@ -468,6 +468,18 @@ L(pre_end):                    ASM_LINE_SEP    \
   #define CLOB_ARGS_1 CLOB_ARGS_2, "%r25"
   #define CLOB_ARGS_0 CLOB_ARGS_1, "%r26"
 
Quoted 16 lines

sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 L(pre_end):                    ASM_LINE_SEP    \ · line 483

Quoted 13 lines
sysdeps/unix/sysv/linux/hppa/sysdep.h    2024-06-21 19:19:02.132000000 +0000 renamed from sysdeps/unix/sysv/linux/hppa/sysdep.h.org    2024-06-15 20:20:58.992000000 +0000 +12 -0
+#define VDSO_NAME    "LINUX_6.11"
+#define VDSO_HASH    182951793
+
+#ifdef __LP64__
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#else
+# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
+# define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
+# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
+#endif /* __LP64__ */
+
   #endif    /* __ASSEMBLER__ */

Not sure why you have added the gettimeofday support, currently 32 bits it is already routed to to clock_gettime (which will use __vdso_clock_gettime64 anyway).

Yep, you are right.
I actually didn't checked if it's being used but just saw it's defined for other arches too, so I assumed it to be used.

Quoted 8 lines
Quoted 3 lines

For hppa to actually use, it would require to add a way to call it for !USE_IFUNC_GETTIMEOFDAY gettimeofday, which I am not it really be an improvement here.

Yes, that doesn't make sense.

Looking at the code it seems riscv, sparc, arm, mips and s390 define it too, without being used. Do you suggest we should remove gettimeofday vsyscall from hppa again (or just keep like the others even if not being used)?

The riscv only added it for CONFIG_64BIT, while old ABIs like arm, sparc, mips, and s390 added before 64 bit time_t landed on 5.1. With current 32 bits ABIs moving to 64 bit time_t userland, there is no much sense in providing a 32 bit gettimeofday, nor I think I adding a gettimeoday64 would make much sense (maybe on really high sensitive workloads that require low-latency timestamping, but clock_gettime would work better anyway).

Quoted 4 lines

It is highly unlikely that the symbol will ever be used by userland, and I think it only make sense to provide clock_gettime64. The glibc 32 bit time_t clock_gettime routes to clock_gettime64 and it will only fallback to 32 bit vDSO symbol if the 64 bit time_t one is not present.

Like patch below?
Helge

[PATCH] hppa/vdso: Provide 64-bit clock_gettime() vDSO only

Adhemerval noticed that the gettimeofday() and 32-bit clock_gettime() vDSO calls won't be used by glibc on hppa, so there is no need to declare them. Both syscalls will be emulated by utilizing return values of the 64-bit clock_gettime() vDSO instead..

sysdeps/unix/sysv/linux/hppa/sysdep.h +0 -0
index af62f7501e..e47975e5cf 100644
@@ -473,11 +473,8 @@ L(pre_end):					ASM_LINE_SEP	\
 

sysdeps/unix/sysv/linux/hppa/sysdep.h L(pre_end): ASM_LINE_SEP \ · line 480

Quoted 10 lines
sysdeps/unix/sysv/linux/hppa/sysdep.h +0 -3
  #ifdef __LP64__
  # define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
-# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
  #else
-# define HAVE_CLOCK_GETTIME_VSYSCALL    "__vdso_clock_gettime"
  # define HAVE_CLOCK_GETTIME64_VSYSCALL  "__vdso_clock_gettime64"
-# define HAVE_GETTIMEOFDAY_VSYSCALL     "__vdso_gettimeofday"
  #endif /* __LP64__ */
 
  #endif	/* __ASSEMBLER__ */

Yeah, it seems ok thanks.

Signature · 1 line
John David Anglin  [email protected]