Skip to contentSkip to conversation

watchdog: Add missing include for FIELD_*()

PATCH Applied Matti Vaittinen 3 participants 3 messages Jul 1, 2024 – Jul 4, 2024

Subsystems (2)
Watchdog device drivers ROHM power management IC device drivers
lore
Share & tools
lore

Matti Vaittinen

author maintainer
#0 lore raw

PATCH 1/1 watchdog: Add missing include for FIELD_*()

The FIELD_PREP() and FIELD_GET() macros are defined in the linux/bitfield.h. Include this header to avoid missing the macro definitions.

Signed-off-by Matti Vaittinen <[email protected]>
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here

---
This patch is built on the ib-mfd-regulator-watchdog-v6.11 tag. These macros got included via some indirect route in my build config on v6.10-rc1 - but the lkp reported problem on some config.

Please, let me know if this follow-up fix is Ok or if I should rather respin the:
https://lore.kernel.org/all/[email protected]/
with this fix. (I don't see much of potential bisecting problems if this fix still gets in the next release, as the watchdog code is behind a new Kconfig flag - but please let me know if I should re-spin whole series).

---
 drivers/watchdog/bd96801_wdt.c | 1 +
 1 file changed, 1 insertion(+)
drivers/watchdog/bd96801_wdt.c +1 -0
index ff51f42ced2a..12b74fd2bc05 100644
@@ -5,6 +5,7 @@
  * ROHM BD96801 watchdog driver
  */
 
+#include <linux/bitfield.h>
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/mfd/rohm-bd96801.h>

base-commit: fcf1f960a6aa45a22efd4d49114c672ed305b85f

Signature · 14 lines
2.45.1


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Matti Vaittinen

The FIELD_PREP() and FIELD_GET() macros are defined in the linux/bitfield.h. Include this header to avoid missing the macro definitions.

Signed-off-by Matti Vaittinen <[email protected]>
Reported-by kernel test robot <[email protected]>
Closes https://lore.kernel.org/oe-kbuild-all/[email protected]/ open here
Acked-by Guenter Roeck <[email protected]>
Quoted 29 lines

---
This patch is built on the ib-mfd-regulator-watchdog-v6.11 tag. These macros got included via some indirect route in my build config on v6.10-rc1 - but the lkp reported problem on some config.

Please, let me know if this follow-up fix is Ok or if I should rather respin the:
https://lore.kernel.org/all/[email protected]/
with this fix. (I don't see much of potential bisecting problems if this fix still gets in the next release, as the watchdog code is behind a new Kconfig flag - but please let me know if I should re-spin whole series).

---
  drivers/watchdog/bd96801_wdt.c | 1 +
  1 file changed, 1 insertion(+)
drivers/watchdog/bd96801_wdt.c +1 -0
index ff51f42ced2a..12b74fd2bc05 100644
@@ -5,6 +5,7 @@
   * ROHM BD96801 watchdog driver
   */
 
+#include <linux/bitfield.h>
  #include <linux/interrupt.h>
  #include <linux/kernel.h>
  #include <linux/mfd/rohm-bd96801.h>

base-commit: fcf1f960a6aa45a22efd4d49114c672ed305b85f

Applied
#2 lore raw

Re: (subset) [PATCH] watchdog: Add missing include for FIELD_*()

In reply to Matti Vaittinen
Quoted 5 lines · Matti Vaittinen

The FIELD_PREP() and FIELD_GET() macros are defined in the linux/bitfield.h. Include this header to avoid missing the macro definitions.

Applied, thanks!

[1/1] watchdog: Add missing include for FIELD_*()

      commit: e53cb372d75b5912fc72d9eebe8d37620fb58056

--
Lee Jones [李琼斯]