Skip to contentSkip to conversation

Should adp5589-keys driver be removed?

DISCUSSION Dmitry Torokhov 2 participants 2 messages Jul 14, 2024 HID

lore
Share & tools
lore
#0 lore raw

Hi Michael, Nuno, Utsav,

I am looking at the adp5589-keys driver and it only supports configuration via platform data and there are no users of it in the mainline kernel. We should either remove it if it is no longer relevant, or change it to use generic device properties so that it can actually be used on modern systems.

Please let me know.

Thanks.

Signature · 1 line
Dmitry
#1 lore raw
Quoted 8 lines · Dmitry Torokhov

Hi Michael, Nuno, Utsav,

I am looking at the adp5589-keys driver and it only supports configuration via platform data and there are no users of it in the mainline kernel. We should either remove it if it is no longer relevant, or change it to use generic device properties so that it can actually be used on modern systems.

Quoted 4 lines

Please let me know.

Thanks.

Hi Dmitry,

I think that driver is still relevant (Michael can better confirm it). I'll do a similar refactor as I did for the adp5588.

Please just bear in mind that with summer vacations and all of that it may take me a bit longer to send a patchset but I'll definitely take care of it.

Thanks!
- Nuno Sá