kernel-patch-validator - Tool to validate patches before submission
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 1 line · Greg KH
Note, it is now 2025, so this check keeps failing :)
Haha, you caught me! The irony of a date validation tool having its own date bug... I've already fixed it to properly check against the current year instead of hardcoding 2025.
Quoted 2 lines
Overall, I like the idea, the implementation needs a bit of work, see the few github issues I opened on it for details found in my testing.
Thank you so much for taking the time to test it and open those issues! I really appreciate the detailed feedback. I've been working through them this morning:
- Fixed the 2025 check (now validates against current date)
- Fixed the set -e issue so it shows all errors instead of bailing out
- Updated stable email validation to accept both formats
- Removed all the emojis (they looked unprofessional anyway)
Quoted 3 lines
Can you add some of these checks to checkpatch.pl itself? That would be the best thing to do in the end. Having to use different tools makes things harder to keep in sync and to remember to use at all.
You're absolutely right about this. Having separate tools is definitely not ideal - I often forgot to run my own validator!
I'm thinking the best approach would be:
1. Port the most useful checks to checkpatch.pl (like the changelog placement check that would have saved me from your bot's rejection!)
2. Keep the workflow helpers separate (find-bugs.sh, test-patch.sh) since they do more than just validation
Would you prefer if I start with small individual patches to checkpatch.pl for each check, or should I put together an RFC first to discuss which checks would be most valuable to integrate?
I built this tool mainly to understand what I was doing wrong. Now that I've learned from my mistakes (thanks to you and Dan's feedback), it makes total sense to help others by putting these checks where everyone will actually use them.
Thanks,
Ignacio
Quoted 3 lines · Ignacio Peña
Would you prefer if I start with small individual patches to checkpatch.pl for each check, or should I put together an RFC first to discuss which checks would be most valuable to integrate?
Just send patches, like normal. "RFC" doesn't work for when you don't have working patches to start with.
thanks,
greg k-h