Skip to contentSkip to conversation

cpufreq: intel_pstate: Update Balance performance EPP for Emerald Rapids

PATCH Applied Pedro Henrique Kopper 3 participants 3 messages Aug 1, 2024 – Aug 2, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpufreq: intel_pstate: Update Balance performance EPP for Emerald Rapids

On Intel Emerald Rapids machines, we ship the Energy Performance Preference (EPP) default for balance_performance as 128. However, during an internal investigation together with Intel, we have determined that 32 is a more suitable value. This leads to significant improvements in both performance and energy:

POV-Ray: 32% faster | 12% less energy
OpenSSL: 12% faster | energy within 1%
Build Linux Kernel: 29% faster | 18% less energy

Therefore, we should move the default EPP for balance_performance to 32. This is in line with what has already been done for Sapphire Rapids.

---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +1 -0
index 392a8000b238..c0278d023cfc 100644
@@ -3405,6 +3405,7 @@ static const struct x86_cpu_id intel_epp_default[] = {
 	 */
 	X86_MATCH_VFM(INTEL_ALDERLAKE_L, HWP_SET_DEF_BALANCE_PERF_EPP(102)),
 	X86_MATCH_VFM(INTEL_SAPPHIRERAPIDS_X, HWP_SET_DEF_BALANCE_PERF_EPP(32)),
+	X86_MATCH_VFM(INTEL_EMERALDRAPIDS_X, HWP_SET_DEF_BALANCE_PERF_EPP(32)),
 	X86_MATCH_VFM(INTEL_METEORLAKE_L, HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,
 		      179, 64, 16)),
 	X86_MATCH_VFM(INTEL_ARROWLAKE, HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,
Signature · 1 line
2.43.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Pedro Henrique Kopper

On Intel Emerald Rapids machines, we ship the Energy Performance Preference
(EPP) default for balance_performance as 128. However, during an internal
investigation together with Intel, we have determined that 32 is a more
suitable value. This leads to significant improvements in both performance
and energy:

POV-Ray: 32% faster | 12% less energy
OpenSSL: 12% faster | energy within 1%
Build Linux Kernel: 29% faster | 18% less energy

Quoted 5 lines

Therefore, we should move the default EPP for balance_performance to 32.
This is in line with what has already been done for Sapphire Rapids.

Quoted 23 lines

---
 drivers/cpufreq/intel_pstate.c | 1 +

 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +1 -0
index 392a8000b238..c0278d023cfc 100644
@@ -3405,6 +3405,7 @@ static const struct x86_cpu_id
 intel_epp_default[] = {
  	 */
  	X86_MATCH_VFM(INTEL_ALDERLAKE_L,
 HWP_SET_DEF_BALANCE_PERF_EPP(102)),
  	X86_MATCH_VFM(INTEL_SAPPHIRERAPIDS_X,
 HWP_SET_DEF_BALANCE_PERF_EPP(32)),
+	X86_MATCH_VFM(INTEL_EMERALDRAPIDS_X,

HWP_SET_DEF_BALANCE_PERF_EPP(32)),
  X86_MATCH_VFM(INTEL_METEORLAKE_L,
HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,
        179, 64, 16)),
  X86_MATCH_VFM(INTEL_ARROWLAKE,
HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,

maintainer Applied
#2 lore raw
Quoted 16 lines · srinivas pandruvada
Quoted 14 lines · Pedro Henrique Kopper

On Intel Emerald Rapids machines, we ship the Energy Performance Preference
(EPP) default for balance_performance as 128. However, during an internal
investigation together with Intel, we have determined that 32 is a more
suitable value. This leads to significant improvements in both performance
and energy:

POV-Ray: 32% faster | 12% less energy
OpenSSL: 12% faster | energy within 1%
Build Linux Kernel: 29% faster | 18% less energy

Quoted 6 lines
Quoted 5 lines

Therefore, we should move the default EPP for balance_performance to 32.
This is in line with what has already been done for Sapphire Rapids.

Applied as 6.11-rc material.

If I'm able to send a pull request next week, I'll push this for -rc3. Otherwise, it'll be -rc4.

Quoted 25 lines
Quoted 23 lines
---
 drivers/cpufreq/intel_pstate.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/intel_pstate.c +1 -0
index 392a8000b238..c0278d023cfc 100644
@@ -3405,6 +3405,7 @@ static const struct x86_cpu_id
 intel_epp_default[] = {
       */
      X86_MATCH_VFM(INTEL_ALDERLAKE_L,
 HWP_SET_DEF_BALANCE_PERF_EPP(102)),
      X86_MATCH_VFM(INTEL_SAPPHIRERAPIDS_X,
 HWP_SET_DEF_BALANCE_PERF_EPP(32)),
+     X86_MATCH_VFM(INTEL_EMERALDRAPIDS_X,

HWP_SET_DEF_BALANCE_PERF_EPP(32)),
X86_MATCH_VFM(INTEL_METEORLAKE_L,
HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,

                    179, 64, 16)),
      X86_MATCH_VFM(INTEL_ARROWLAKE,

HWP_SET_EPP_VALUES(HWP_EPP_POWERSAVE,