Input: cyttsp4 - remove driver
Subsystems (3)
Dmitry Torokhov
maintainerPATCH 1/1 Input: cyttsp4 - remove driver
The cyttsp4 touchscreen driver was contributed in 2013 and since then has seen no updates. The driver uses platform data (no device tree support) and there are no users of it in the mainline kernel. There were occasional fixes to it for issues either found by static code analysis tools or via visual inspection, but otherwise the driver is completely untested.
Remove the driver.
--- drivers/input/touchscreen/Kconfig | 30 - drivers/input/touchscreen/Makefile | 5 +- drivers/input/touchscreen/cyttsp4_core.c | 2174 ----------------- drivers/input/touchscreen/cyttsp4_core.h | 448 ---- drivers/input/touchscreen/cyttsp4_i2c.c | 72 - drivers/input/touchscreen/cyttsp4_spi.c | 187 -- drivers/input/touchscreen/cyttsp_core.h | 4 - drivers/input/touchscreen/cyttsp_i2c.c | 55 + drivers/input/touchscreen/cyttsp_i2c_common.c | 86 - include/linux/platform_data/cyttsp4.h | 62 - 10 files changed, 56 insertions(+), 3067 deletions(-)
drivers/input/touchscreen/Kconfig +0 -30
@@ -254,36 +254,6 @@ config TOUCHSCREEN_CYTTSP_SPI To compile this driver as a module, choose M here: the module will be called cyttsp_spi. -config TOUCHSCREEN_CYTTSP4_CORE - tristate "Cypress TrueTouch Gen4 Touchscreen Driver" - help - Core driver for Cypress TrueTouch(tm) Standard Product - Generation4 touchscreen controllers. - - Say Y here if you have a Cypress Gen4 touchscreen. - - If unsure, say N. - - To compile this driver as a module, choose M here. - -config TOUCHSCREEN_CYTTSP4_I2C - tristate "support I2C bus connection" - depends on TOUCHSCREEN_CYTTSP4_CORE && I2C - help - Say Y here if the touchscreen is connected via I2C bus. - - To compile this driver as a module, choose M here: the - module will be called cyttsp4_i2c. - -config TOUCHSCREEN_CYTTSP4_SPI - tristate "support SPI bus connection" - depends on TOUCHSCREEN_CYTTSP4_CORE && SPI_MASTER - help - Say Y here if the touchscreen is connected via SPI bus. - - To compile this driver as a module, choose M here: the - module will be called cyttsp4_spi. - config TOUCHSCREEN_CYTTSP5 tristate "Cypress TrueTouch Gen5 Touchscreen Driver" depends on I2C
drivers/input/touchscreen/Makefile +1 -4
@@ -25,11 +25,8 @@ obj-$(CONFIG_TOUCHSCREEN_CHIPONE_ICN8505) += chipone_icn8505.o obj-$(CONFIG_TOUCHSCREEN_CY8CTMA140) += cy8ctma140.o obj-$(CONFIG_TOUCHSCREEN_CY8CTMG110) += cy8ctmg110_ts.o obj-$(CONFIG_TOUCHSCREEN_CYTTSP_CORE) += cyttsp_core.o -obj-$(CONFIG_TOUCHSCREEN_CYTTSP_I2C) += cyttsp_i2c.o cyttsp_i2c_common.o +obj-$(CONFIG_TOUCHSCREEN_CYTTSP_I2C) += cyttsp_i2c.o obj-$(CONFIG_TOUCHSCREEN_CYTTSP_SPI) += cyttsp_spi.o -obj-$(CONFIG_TOUCHSCREEN_CYTTSP4_CORE) += cyttsp4_core.o -obj-$(CONFIG_TOUCHSCREEN_CYTTSP4_I2C) += cyttsp4_i2c.o cyttsp_i2c_common.o -obj-$(CONFIG_TOUCHSCREEN_CYTTSP4_SPI) += cyttsp4_spi.o obj-$(CONFIG_TOUCHSCREEN_CYTTSP5) += cyttsp5.o obj-$(CONFIG_TOUCHSCREEN_DA9034) += da9034-ts.o obj-$(CONFIG_TOUCHSCREEN_DA9052) += da9052_tsi.o
drivers/input/touchscreen/cyttsp4_core.c deleted +0 -2174
2,174 lines not on this page · raw message
drivers/input/touchscreen/cyttsp4_core.h deleted +0 -448
448 lines not on this page · raw message
drivers/input/touchscreen/cyttsp4_i2c.c deleted +0 -72
72 lines not on this page · raw message
drivers/input/touchscreen/cyttsp4_spi.c deleted +0 -187
187 lines not on this page · raw message
drivers/input/touchscreen/cyttsp_core.h +0 -4
@@ -137,10 +137,6 @@ struct cyttsp {struct cyttsp *cyttsp_probe (const struct cyttsp_bus_ops *bus_ops,struct device *dev,int irq,size_t xfer_buf_size); -int cyttsp_i2c_write_block_data (struct device *dev,u8 *xfer_buf,u16 addr, -u8 length,const void *values); -int cyttsp_i2c_read_block_data (struct device *dev,u8 *xfer_buf,u16 addr, -u8 length,void *values);extern const struct dev_pm_ops cyttsp_pm_ops;#endif /* __CYTTSP_CORE_H__ */
drivers/input/touchscreen/cyttsp_i2c.c +55 -0
61 lines not on this page · raw message
drivers/input/touchscreen/cyttsp_i2c_common.c deleted +0 -86
86 lines not on this page · raw message
include/linux/platform_data/cyttsp4.h deleted +0 -62
62 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 5 lines
2.46.0.rc2.264.g509ed76dc8-goog -- Dmitry
Part of the diff is not shown here. View the raw message.
Dmitry Torokhov <[email protected]> writes:
Hello Dmitry,
Quoted 11 lines
The cyttsp4 touchscreen driver was contributed in 2013 and since then has seen no updates. The driver uses platform data (no device tree support) and there are no users of it in the mainline kernel. There were occasional fixes to it for issues either found by static code analysis tools or via visual inspection, but otherwise the driver is completely untested.
Remove the driver.
Signed-off-by Dmitry Torokhov <[email protected]>---
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 10 lines · Dmitry Torokhov
The cyttsp4 touchscreen driver was contributed in 2013 and since then has seen no updates. The driver uses platform data (no device tree support) and there are no users of it in the mainline kernel. There were occasional fixes to it for issues either found by static code analysis tools or via visual inspection, but otherwise the driver is completely untested.
Remove the driver.
Signed-off-by Dmitry Torokhov <[email protected]>
Yours,
Linus Walleij