Skip to contentSkip to conversation

of btrfs_free_squota_rsv

DISCUSSION Dr. David Alan Gilbert 2 participants 3 messages Oct 3, 2024 Btrfs file system

lore
Share & tools
lore
#0 lore raw

Hi Boris,
One of my scripts noticed that 'btrfs_free_squota_rsv' is unused;
it came from your commit:

commit e85a0adacf170634878fffcbf34b725aff3f49ed

Author: Boris Burkov <[email protected]>
Date:   Fri Dec 1 13:00:13 2023 -0800

btrfs: ensure releasing squota reserve on head refs

I was going to deadcode it, but then thought I'd better check since unused 'free's sometime turn out to be someone forgot to free something!

Thoughts?

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#1 lore raw
Quoted 8 lines · Dr. David Alan Gilbert

Hi Boris,
One of my scripts noticed that 'btrfs_free_squota_rsv' is unused;
it came from your commit:

commit e85a0adacf170634878fffcbf34b725aff3f49ed

Author: Boris Burkov <[email protected]>
Date:   Fri Dec 1 13:00:13 2023 -0800
Quoted 6 lines

btrfs: ensure releasing squota reserve on head refs

I was going to deadcode it, but then thought I'd better check since unused 'free's sometime turn out to be someone forgot to free something!

Thoughts?

Hi Dave,

Thanks for catching it, and for the thoughtful message.

I believe that function is just pure sloppy duplication. The same functionality is in introduced in the same patch in fs/btrfs/extent-tree.c in free_head_ref_squota_rsv, which _is_ used in the cleanup path.

So with that said, please deadcode away!

Boris

Quoted 7 lines

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
#2 lore raw
Quoted 18 lines · * Boris Burkov ([email protected]) wrote:
Quoted 8 lines · Dr. David Alan Gilbert

Hi Boris,
One of my scripts noticed that 'btrfs_free_squota_rsv' is unused;
it came from your commit:

commit e85a0adacf170634878fffcbf34b725aff3f49ed

Author: Boris Burkov <[email protected]>
Date:   Fri Dec 1 13:00:13 2023 -0800
Quoted 6 lines

btrfs: ensure releasing squota reserve on head refs

I was going to deadcode it, but then thought I'd better check since unused 'free's sometime turn out to be someone forgot to free something!

Thoughts?

Hi Dave,

Quoted 8 lines

Thanks for catching it, and for the thoughtful message.

I believe that function is just pure sloppy duplication. The same functionality is in introduced in the same patch in fs/btrfs/extent-tree.c in free_head_ref_squota_rsv, which _is_ used in the cleanup path.

So with that said, please deadcode away!

OK then, please see my just posted message [email protected] (from my [email protected] alias)

Thanks again,

Dave

Quoted 9 lines

Boris

Quoted 7 lines

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/