of atmel_pmecc_destroy_user

Hi Boris and co,
One of my scripts noticed that 'atmel_pmecc_destroy_user'
isn't called anywhere; I was going to delete it, but hmm, I wonder if it's actually a missing call and leaking (in the unlikely case the device was ever removed).

It was added by your:
commit f88fc122cc34c2545dec9562eaab121494e401ef
Author: Boris Brezillon <[email protected]>
Date: Thu Mar 16 09:02:40 2017 +0100

mtd: nand: Cleanup/rework the atmel_nand driver

and I see the allocation in:

     user = kzalloc(size, GFP_KERNEL);
       in
     nand->pmecc = atmel_pmecc_create_user(nc->pmecc, &req);
       called in atmel_nand_pmecc_init
         from atmel_nand_ecc_init
           from atmel_hsmc_nand_ecc_init

But I don't see any freeing.

(I don't knowingly have hardware to test a fix, although I guess there's probably one somewhere....)

Suggestions?

Hi David,

Quoted 23 lines · On Sun, 29 Sep 2024 17:05:01 +0000 "Dr. David Alan Gilbert"…

Hi Boris and co,
One of my scripts noticed that 'atmel_pmecc_destroy_user'
isn't called anywhere; I was going to delete it, but hmm, I wonder if it's actually a missing call and leaking (in the unlikely case the device was ever removed).

It was added by your:
commit f88fc122cc34c2545dec9562eaab121494e401ef
Author: Boris Brezillon <[email protected]>
Date: Thu Mar 16 09:02:40 2017 +0100

mtd: nand: Cleanup/rework the atmel_nand driver

and I see the allocation in:

     user = kzalloc(size, GFP_KERNEL);
       in
     nand->pmecc = atmel_pmecc_create_user(nc->pmecc, &req);
       called in atmel_nand_pmecc_init
         from atmel_nand_ecc_init
           from atmel_hsmc_nand_ecc_init

But I don't see any freeing.

Quoted 4 lines

(I don't knowingly have hardware to test a fix, although I guess there's probably one somewhere....)

Suggestions?

There's definitely a leak. I haven't looked at NAND stuff for a while though, so I'll let Miquel advise you on where atmel_pmecc_destroy_user() should be called.

Regards,

Boris

Quoted 33 lines

Hi David,

Quoted 27 lines · On Sun, 29 Sep 2024 17:05:01 +0000 "Dr. David Alan Gilbert"…

Hi Boris and co,
One of my scripts noticed that 'atmel_pmecc_destroy_user'
isn't called anywhere; I was going to delete it, but hmm, I wonder if it's actually a missing call and leaking (in the unlikely case the device was ever removed).

It was added by your:
commit f88fc122cc34c2545dec9562eaab121494e401ef
Author: Boris Brezillon <[email protected]>
Date: Thu Mar 16 09:02:40 2017 +0100

mtd: nand: Cleanup/rework the atmel_nand driver

and I see the allocation in:

     user = kzalloc(size, GFP_KERNEL);
       in
     nand->pmecc = atmel_pmecc_create_user(nc->pmecc, &req);
       called in atmel_nand_pmecc_init
         from atmel_nand_ecc_init
           from atmel_hsmc_nand_ecc_init

But I don't see any freeing.

(I don't knowingly have hardware to test a fix, although I guess there's probably one somewhere....)

Suggestions?

Quoted 3 lines

There's definitely a leak. I haven't looked at NAND stuff for a while though, so I'll let Miquel advise you on where atmel_pmecc_destroy_user() should be called.

I see Miquel has posted a fix.

Thanks to both of you!