Skip to contentSkip to conversation

perf tests: Remove dangling CFLAGS for removed attr.o object

PATCH Applied Arnaldo Carvalho de Melo 3 participants 3 messages Nov 4, 2024 – Nov 5, 2024 perf events

lore
Share & tools
lore

Arnaldo Carvalho de Melo

author maintainer
#0 lore raw

PATCH 1/1 perf tests: Remove dangling CFLAGS for removed attr.o object

Since the C test wrapper for attr.py was removed we don't have an attr.o object for that CFLAGS_attr.o to apply for, remove it.

Fixes 3a447031f5fc21c4 ("perf test: Remove C test wrapper for attr.py")
Cc Athira Rajeev <[email protected]>
Cc Howard Chu <[email protected]>
Cc Ian Rogers <[email protected]>
Cc James Clark <[email protected]>
Cc Leo Yan <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephen Rothwell <[email protected]>
Cc Thomas Richter <[email protected]>
Cc Veronika Molnarova <[email protected]>
Cc Weilin Wang <[email protected]>
Cc Ze Gao <[email protected]>
Cc zhaimingbing <[email protected]>
---
 tools/perf/tests/Build | 1 -
 1 file changed, 1 deletion(-)
tools/perf/tests/Build +0 -1
index 03cbdf7c50a09be4..01ed9335db4dba4e 100644
@@ -72,7 +72,6 @@ ifeq ($(SRCARCH),$(filter $(SRCARCH),x86 arm arm64 powerpc))
 perf-test-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
 endif
 
-CFLAGS_attr.o         += -DBINDIR="BUILD_STR($(bindir_SQ))" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
 CFLAGS_python-use.o   += -DPYTHONPATH="BUILD_STR($(OUTPUT)python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
 CFLAGS_dwarf-unwind.o += -fno-optimize-sibling-calls
 
Signature · 1 line
2.47.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Arnaldo Carvalho de Melo

Since the C test wrapper for attr.py was removed we don't have an attr.o object for that CFLAGS_attr.o to apply for, remove it.

Quoted 14 lines
Fixes 3a447031f5fc21c4 ("perf test: Remove C test wrapper for attr.py")
Cc Athira Rajeev <[email protected]>
Cc Howard Chu <[email protected]>
Cc Ian Rogers <[email protected]>
Cc James Clark <[email protected]>
Cc Leo Yan <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Stephen Rothwell <[email protected]>
Cc Thomas Richter <[email protected]>
Cc Veronika Molnarova <[email protected]>
Cc Weilin Wang <[email protected]>
Cc Ze Gao <[email protected]>
Cc zhaimingbing <[email protected]>

Thanks,
Ian

Quoted 19 lines
---
 tools/perf/tests/Build | 1 -
 1 file changed, 1 deletion(-)
tools/perf/tests/Build +0 -2
index 03cbdf7c50a09be4..01ed9335db4dba4e 100644
@@ -72,7 +72,6 @@ ifeq ($(SRCARCH),$(filter $(SRCARCH),x86 arm arm64 powerpc))
 perf-test-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
 endif
 
-CFLAGS_attr.o         += -DBINDIR="BUILD_STR($(bindir_SQ))" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
 CFLAGS_python-use.o   += -DPYTHONPATH="BUILD_STR($(OUTPUT)python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
 CFLAGS_dwarf-unwind.o += -fno-optimize-sibling-calls
 
--

2.47.0

maintainer Applied
#2 lore raw
In reply to Arnaldo Carvalho de Melo
Quoted 4 lines · Arnaldo Carvalho de Melo

Since the C test wrapper for attr.py was removed we don't have an attr.o object for that CFLAGS_attr.o to apply for, remove it.

Applied to perf-tools-next, thanks!

Best regards,
Namhyung