Skip to contentSkip to conversation

Questions of openbmc-test-automation

DISCUSSION Will Liang (梁永鉉) 2 participants 4 messages Sep 23, 2019 – Sep 24, 2019

lore
Share & tools
lore
#0 lore raw

Hi,

I use the "openbmc-test-automation" package to test our project.
And I just want to implement the IPMI test case because our platform does not support REDFISH (IPMI only). But I found that in the IPMI test case, it use the REFISH command as well (eg Redfish power on[0]).

[0] https://github.com/openbmc/openbmc-test-automation/blob/2a520ee37c72ea847ca2d6c773493a6dd752c827/ipmi/test_ipmi_sdr.robot#L59

My questions are following:
1. Are there other ways to avoid using the Redfish commands?
2. Is it possible to add parameter(ex:PROTOCOL) on the command line to select the protocol to use?
For example:
- add the new keyword maybe like "Power On".
- and the new keyword "power on" can use the new parameter to choose what protocol be used(default protocol is REDFISH if not set).
- the new keyword like below:
Power On
[Documentation] select the execute protocol.
[Arguments] ${stack_mode}=${stack_mode} ${quiet}=${quiet}

Run Keyword If '${PROTOCOL}' == 'Redfish'
... Redfish Power On stack_mode=skip quiet=0
... ELSE IPMI Power On stack_mode=skip quiet=0

BRs
Will

#1 lore raw

Hi Will
At present, we don't have ways to avoid Redfish dependency in IPMI suite. We can code like the way you pointed, but it is possible only for some IPMI commands(like power on and off). For all other IPMI commands like event logs, FRU, SDR, DCMI commands we need to depend on Redfish to verify the output.

Thanks
Rahul

Quoted 31 lines · On Mon, 23 Sep 2019, 11:13 Will Liang (梁永鉉), <[email protected]> wrote:

Hi,

I use the "openbmc-test-automation" package to test our project. And I just want to implement the IPMI test case because our platform does not support REDFISH (IPMI only).
But I found that in the IPMI test case, it use the REFISH command as well (eg Redfish power on[0]).

[0]
https://github.com/openbmc/openbmc-test-automation/blob/2a520ee37c72ea847ca2d6c773493a6dd752c827/ipmi/test_ipmi_sdr.robot#L59

My questions are following:
1. Are there other ways to avoid using the Redfish commands?
2. Is it possible to add parameter(ex:PROTOCOL) on the command line to select the protocol to use?
For example:
- add the new keyword maybe like "Power On".
- and the new keyword "power on" can use the new parameter to choose what protocol be used(default protocol is REDFISH if not set).
- the new keyword like below:
Power On
[Documentation] select the execute protocol.
[Arguments] ${stack_mode}=${stack_mode} ${quiet}=${quiet}

Run Keyword If '${PROTOCOL}' == 'Redfish'
... Redfish Power On stack_mode=skip quiet=0
... ELSE IPMI Power On stack_mode=skip quiet=0

BRs
Will

#2 lore raw

Hi Rahul,

Thank you for your responds.

According to our request, can I add a new IPMI test suite and a new IPMI only keyword?

BRs,
Will
________________________________
寄件者: Rahul Maheshwari <[email protected]> 寄件日期: 2019年9月23日 下午 07:29
收件者: Will Liang (梁永鉉)
副本: [email protected]
主旨: Re: Questions of openbmc-test-automation

Hi Will
At present, we don't have ways to avoid Redfish dependency in IPMI suite. We can code like the way you pointed, but it is possible only for some IPMI commands(like power on and off). For all other IPMI commands like event logs, FRU, SDR, DCMI commands we need to depend on Redfish to verify the output.

Thanks
Rahul

On Mon, 23 Sep 2019, 11:13 Will Liang (梁永鉉), <[email protected]<mailto:[email protected]>> wrote:
Hi,

I use the "openbmc-test-automation" package to test our project.
And I just want to implement the IPMI test case because our platform does not support REDFISH (IPMI only). But I found that in the IPMI test case, it use the REFISH command as well (eg Redfish power on[0]).

[0] https://github.com/openbmc/openbmc-test-automation/blob/2a520ee37c72ea847ca2d6c773493a6dd752c827/ipmi/test_ipmi_sdr.robot#L59

My questions are following:
1. Are there other ways to avoid using the Redfish commands?
2. Is it possible to add parameter(ex:PROTOCOL) on the command line to select the protocol to use?
For example:
- add the new keyword maybe like "Power On".
- and the new keyword "power on" can use the new parameter to choose what protocol be used(default protocol is REDFISH if not set).
- the new keyword like below:
Power On
[Documentation] select the execute protocol.
[Arguments] ${stack_mode}=${stack_mode} ${quiet}=${quiet}

Run Keyword If '${PROTOCOL}' == 'Redfish'
... Redfish Power On stack_mode=skip quiet=0
... ELSE IPMI Power On stack_mode=skip quiet=0

BRs
Will

#3 lore raw

Sure. Please go ahead.

Thanks & Regards
Rahul

Quoted 65 lines · On Tue, 24 Sep 2019, 07:05 Will Liang (梁永鉉), <[email protected]> wrote:

Hi Rahul,

Thank you for your responds.

According to our request, can I add a new IPMI test suite and a new IPMI only keyword?

BRs,
Will
------------------------------
*寄件者:* Rahul Maheshwari <[email protected]> *寄件日期:* 2019年9月23日 下午 07:29
*收件者:* Will Liang (梁永鉉)
*副本:* [email protected]
*主旨:* Re: Questions of openbmc-test-automation

Hi Will
At present, we don't have ways to avoid Redfish dependency in IPMI suite. We can code like the way you pointed, but it is possible only for some IPMI commands(like power on and off). For all other IPMI commands like event logs, FRU, SDR, DCMI commands we need to depend on Redfish to verify the output.

Thanks
Rahul

Quoted 31 lines · On Mon, 23 Sep 2019, 11:13 Will Liang (梁永鉉), <[email protected]> wrote:

Hi,

I use the "openbmc-test-automation" package to test our project. And I just want to implement the IPMI test case because our platform does not support REDFISH (IPMI only).
But I found that in the IPMI test case, it use the REFISH command as well (eg Redfish power on[0]).

[0]
https://github.com/openbmc/openbmc-test-automation/blob/2a520ee37c72ea847ca2d6c773493a6dd752c827/ipmi/test_ipmi_sdr.robot#L59

My questions are following:
1. Are there other ways to avoid using the Redfish commands?
2. Is it possible to add parameter(ex:PROTOCOL) on the command line to select the protocol to use?
For example:
- add the new keyword maybe like "Power On".
- and the new keyword "power on" can use the new parameter to choose what protocol be used(default protocol is REDFISH if not set).
- the new keyword like below:
Power On
[Documentation] select the execute protocol.
[Arguments] ${stack_mode}=${stack_mode} ${quiet}=${quiet}

Run Keyword If '${PROTOCOL}' == 'Redfish'
... Redfish Power On stack_mode=skip quiet=0
... ELSE IPMI Power On stack_mode=skip quiet=0

BRs
Will