about async buffered reads feature
Hi Jens,
I'm doing tests about this feature: [PATCHSET RFC 0/11] Add support for async buffered reads
But currently with fio testing, I found the code doesn't go to the essential places in the function generic_file_buffered_read:
if (iocb->ki_flags & IOCB_WAITQ) {
if (written) {
put_page(page);
goto out;
}
error = wait_on_page_locked_async(page,
iocb->ki_waitq);
} else {and
page_not_up_to_date:
/* Get exclusive access to the page ... */
if (iocb->ki_flags & IOCB_WAITQ)
error = lock_page_async(page, iocb->ki_waitq);
elsecould you give me a copy of your test program which you mentioned in the RFC? My testing environment:
fio version: 3.10
kernel version: the mainline kernel, latest commit is 805c6d3c19210c90c109107d189744e960eae025
Thanks,
Hao
Jens Axboe
maintainerQuoted 15 lines · Hao_Xu
Hi Jens,
I'm doing tests about this feature: [PATCHSET RFC 0/11] Add support for async buffered reads
But currently with fio testing, I found the code doesn't go to the essential places in the functiongeneric_file_buffered_read:if (iocb->ki_flags & IOCB_WAITQ) { if (written) { put_page(page); goto out; } error = wait_on_page_locked_async(page, iocb->ki_waitq); } else {
Quoted 7 lines
and
page_not_up_to_date: /* Get exclusive access to the page ... */ if (iocb->ki_flags & IOCB_WAITQ) error = lock_page_async(page, iocb->ki_waitq); else
Can you try with this added? Looks like a regression got introduced...
fs/io_uring.c +1 -4
@@ -3339,10 +3339,7 @@ static int io_read(struct io_kiocb *req, bool force_nonblock, goto done;/* some cases will consume bytes even on error returns */ iov_iter_revert (iter, iov_count -iov_iter_count (iter)); - ret =io_setup_async_rw (req, iovec, inline_vecs, iter, false); -if (ret) - goto out_free; -return -EAGAIN ; + goto copy_iov; }else if (ret <0 ) {/* make sure -ERESTARTSYS -> -EINTR is done */ goto done;
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerQuoted 18 lines · Jens Axboe
Quoted 17 lines · Hao_Xu
Hi Jens,
I'm doing tests about this feature: [PATCHSET RFC 0/11] Add support for async buffered reads
But currently with fio testing, I found the code doesn't go to the essential places in the functiongeneric_file_buffered_read:if (iocb->ki_flags & IOCB_WAITQ) { if (written) { put_page(page); goto out; } error = wait_on_page_locked_async(page, iocb->ki_waitq); } else {and
Quoted 7 lines
Quoted 5 lines
page_not_up_to_date: /* Get exclusive access to the page ... */ if (iocb->ki_flags & IOCB_WAITQ) error = lock_page_async(page, iocb->ki_waitq); elseCan you try with this added? Looks like a regression got introduced...
Oops, needs 'ret' cleared too. This should be better!
fs/io_uring.c +2 -4
@@ -3172,10 +3172,8 @@ static int io_read(struct io_kiocb *req, bool force_nonblock, goto done;/* some cases will consume bytes even on error returns */ iov_iter_revert (iter, iov_count -iov_iter_count (iter)); - ret =io_setup_async_rw (req, iovec, inline_vecs, iter, false); -if (ret) - goto out_free; -return -EAGAIN ; + ret =0 ; + goto copy_iov; }else if (ret <0 ) {/* make sure -ERESTARTSYS -> -EINTR is done */ goto done;
Signature · 1 line
Jens Axboe