Skip to contentSkip to conversation

nvme: default to 0 poll queues

PATCH New Jens Axboe 2 participants 3 messages Nov 17, 2018 – Nov 19, 2018 NVMe

lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 nvme: default to 0 poll queues

We need a better way of configuring this, and given that polling is (still) a bit niche, let's default to using 0 poll queues. That way we'll have the same read/write/poll behavior as 4.20, and users that want to test/use polling are required to do manual configuration of the number of poll queues.

Signed-off-by Jens Axboe <axboe at kernel.dk>
drivers/nvme/host/pci.c +1 -1
index 89874e23e422..57e790391b82 100644
@@ -86,7 +86,7 @@ MODULE_PARM_DESC(write_queues,
 	"Number of queues to use for writes. If not set, reads and writes "
 	"will share a queue set.");
 
-static int poll_queues = 1;
+static int poll_queues = 0;
 module_param_cb(poll_queues, &queue_count_ops, &poll_queues, 0644);
 MODULE_PARM_DESC(poll_queues, "Number of queues to use for polled IO.");
Signature · 1 line
Jens Axboe
maintainer
#1 lore raw

PATCH 1/1 nvme: default to 0 poll queues

Quoted 8 lines · Jens Axboe

We need a better way of configuring this, and given that polling is (still) a bit niche, let's default to using 0 poll queues. That way we'll have the same read/write/poll behavior as 4.20, and users that want to test/use polling are required to do manual configuration of the number of poll queues.

Signed-off-by Jens Axboe <axboe at kernel.dk>

Looks good (except that you could use more of each line for the commit log).

Reviewed-by Christoph Hellwig <hch at lst.de>

Given that the poll queues were introduced in the block tree, can you queue it up there?

author maintainer
#2 lore raw

PATCH 1/1 nvme: default to 0 poll queues

Quoted 10 lines · Christoph Hellwig
Quoted 8 lines · Jens Axboe

We need a better way of configuring this, and given that polling is (still) a bit niche, let's default to using 0 poll queues. That way we'll have the same read/write/poll behavior as 4.20, and users that want to test/use polling are required to do manual configuration of the number of poll queues.

Signed-off-by Jens Axboe <axboe at kernel.dk>
Quoted 7 lines

Looks good (except that you could use more of each line for the commit log).

Reviewed-by Christoph Hellwig <hch at lst.de>

Given that the poll queues were introduced in the block tree, can you queue it up there?

Yep will do, stretched to 72 as well :-)

Signature · 1 line
Jens Axboe