Skip to contentSkip to conversation

fork historic module

RFC James Morris 2 participants 2 messages Dec 17, 2004 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 2 lines

Any comments and suggestions are welcome.

I don't see why you are using LSM for this.

It's not an access control system, only uses one LSM hook (I gather becuase it happens to be in the right place), and furthermore, uses a hook intended for LSM resource management.

- James

Signature · 2 lines
James Morris
<[email protected]>
#2 lore raw
Quoted 8 lines · * James Morris ([email protected]) wrote:
Quoted 2 lines

Any comments and suggestions are welcome.

I don't see why you are using LSM for this.

It's not an access control system, only uses one LSM hook (I gather becuase it happens to be in the right place), and furthermore, uses a hook intended for LSM resource management.

We went through this before. I recommended against using it, and suggested using proper framework, such as PAGG or CKRM. However, Guillaume preferred to use something that was in the kernel instead of relying on another external patch. I don't have a problem with that, but it's not mergeable. Ideally efforts would be made to consolidate to common resource management needs, and elsa could be part of this effort. So Guillame, feel free to use the LSM hook, but just know it's not a mergeable work.

thanks,
-chris

Signature · 1 line
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net