Skip to contentSkip to conversation

iio: hid: fix the retval in accel_3d_capture_sample

PATCH In review Dmitry Perchanov 2 participants 2 messages Jan 11, 2023 – Jan 14, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: hid: fix the retval in accel_3d_capture_sample

Return value should be zero for success.
This was forgotten for timestamp feature.
Verified on RealSense cameras.

Fixes a96cd0f901ee ("iio: accel: hid-sensor-accel-3d: Add timestamp")
---
 drivers/iio/accel/hid-sensor-accel-3d.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/accel/hid-sensor-accel-3d.c +1 -0
index a2def6f93..5eac7ea19 100644
@@ -280,6 +280,7 @@ static int accel_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
 			hid_sensor_convert_timestamp(
 					&accel_state->common_attributes,
 					*(int64_t *)raw_data);
+		ret = 0;
 	break;
 	default:
 		break;
Signature · 10 lines
2.39.0


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
maintainer
#1 lore raw
Quoted 6 lines · On Wed, 11 Jan 2023 14:22:10 +0200 Dmitry Perchanov…

Return value should be zero for success.
This was forgotten for timestamp feature.
Verified on RealSense cameras.

Fixes a96cd0f901ee ("iio: accel: hid-sensor-accel-3d: Add timestamp")

All tags need to be in one block with no blank lines. I've fixed
this up whilst applying. Applied to the fixes-togreg branch of iio.git.

Thanks

Jonathan

Quoted 17 lines
---
 drivers/iio/accel/hid-sensor-accel-3d.c | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/accel/hid-sensor-accel-3d.c +1 -0
index a2def6f93..5eac7ea19 100644
@@ -280,6 +280,7 @@ static int accel_3d_capture_sample(struct hid_sensor_hub_device *hsdev,
 			hid_sensor_convert_timestamp(
 					&accel_state->common_attributes,
 					*(int64_t *)raw_data);
+		ret = 0;
 	break;
 	default:
 		break;