Skip to contentSkip to conversation

Synaptics and TrackPoint problems in 2.6.12

DISCUSSION Stephen Evanchik 4 participants 5 messages Jul 20, 2005 Input drivers

lore
Share & tools
lore
#0 lore raw

Dimitry,

I have been receiving a lot of complaints that TrackPoints on Synaptics pass-thru ports stopped working with 2.6.12. I retested 2.6.9 and 2.6.11-rc3 successfully, I believe 2.6.11.7 may also work but that is unconfirmed at this point.

The behavior is always the same .. after sending the read secondary ID command, the TrackPoint seems to be disabled from that point forward.

Any ideas?

Signature · 2 lines
Stephen Evanchik
http://stephen.evanchik.com
#1 lore raw
Quoted 7 lines · Stephen Evanchik

Dimitry,

I have been receiving a lot of complaints that TrackPoints on Synaptics pass-thru ports stopped working with 2.6.12. I retested 2.6.9 and 2.6.11-rc3 successfully, I believe 2.6.11.7 may also work but that is unconfirmed at this point.

Quoted 5 lines

The behavior is always the same .. after sending the read secondary ID command, the TrackPoint seems to be disabled from that point forward.

Any ideas?

Not really... You know, I am reviewing the 2.6.12 patch and don't really see anything that might have caused the problem you are describing. I know that not all devices on pass-through ports are broken since I have one (not TrackPoint, just a simple eraser head pointer) and I make sure it works ;)

When you are talking about reading secondary ID, are you talking about TP_READ_ID or something else?

Are you experiencing the breakage yourself? It might be interesting to see the log with i8042 debugging turned on.

Signature · 1 line
Dmitry
#2 lore raw
In reply to Stephen Evanchik
Quoted 9 lines · On Tue, 19 Jul 2005 23:40:18 -0400 Stephen Evanchik wrote:

I have been receiving a lot of complaints that TrackPoints on Synaptics pass-thru ports stopped working with 2.6.12. I retested 2.6.9 and 2.6.11-rc3 successfully, I believe 2.6.11.7 may also work but that is unconfirmed at this point.

The behavior is always the same .. after sending the read secondary ID command, the TrackPoint seems to be disabled from that point forward.

Any ideas?

Looks like this problem was introduced by the change from PSMOUSE_PS2 to PSMOUSE_TRACKPOINT in the TrackPoint support patch. The Synaptics driver needs to know whether the device on the pass-thru port is using 3-byte or 4-byte packets; however, instead of checking child->pktsize, it checks child->type >= PSMOUSE_GENPS - and this check is now giving a wrong result. Therefore the Synaptics driver configures the pass-thru port for 4-byte packets, and all 3-byte packets from TrackPoint seem to be thrown away.

The patch below is reported to fix the problem - now the 4-byte mode is used only if child->pktsize == 4. Another option is to change the PSMOUSE_TRACKPOINT value so that it is less than PSMOUSE_GENPS, however, I think that checking child->pktsize is more correct in this case.

In theory, someone could attach a device which uses 6-byte packets to the Synaptics pass-thru port; I'm not sure what would happen in this case, but with Synaptics confugured for 3-byte packets (as the patch below will do) this configuration even has a chance of working.

---
Subject: [PATCH] Fix pass-thru port configuration in the Synaptics driver

The Synaptics driver uses child->type to select either 3-byte or 4-byte packet size for the pass-thru port; this gives wrong results at least for PSMOUSE_TRACKPOINT. Change the check to use child->pktsize instead.

drivers/input/mouse/synaptics.c renamed from drivers/input/mouse/synaptics.c.alt-synaptics-with-trackpoint +2 -2
@@ -219,7 +219,7 @@ static void synaptics_pass_pt_packet(str
 		serio_interrupt(ptport, packet[1], 0, NULL);
 		serio_interrupt(ptport, packet[4], 0, NULL);
 		serio_interrupt(ptport, packet[5], 0, NULL);
-		if (child->type >= PSMOUSE_GENPS)
+		if (child->pktsize == 4)
 			serio_interrupt(ptport, packet[2], 0, NULL);
 	} else
 		serio_interrupt(ptport, packet[1], 0, NULL);
@@ -233,7 +233,7 @@ static void synaptics_pt_activate(struct
 
 	/* adjust the touchpad to child's choice of protocol */
 	if (child) {
-		if (child->type >= PSMOUSE_GENPS)
+		if (child->pktsize == 4)
 			priv->mode |= SYN_BIT_FOUR_BYTE_CLIENT;
 		else
 			priv->mode &= ~SYN_BIT_FOUR_BYTE_CLIENT;
maintainer
#3 lore raw
Quoted 12 lines · Sergey Vlasov
Quoted 9 lines · On Tue, 19 Jul 2005 23:40:18 -0400 Stephen Evanchik wrote:

I have been receiving a lot of complaints that TrackPoints on Synaptics pass-thru ports stopped working with 2.6.12. I retested 2.6.9 and 2.6.11-rc3 successfully, I believe 2.6.11.7 may also work but that is unconfirmed at this point.

The behavior is always the same .. after sending the read secondary ID command, the TrackPoint seems to be disabled from that point forward.

Any ideas?

Quoted 8 lines

Looks like this problem was introduced by the change from PSMOUSE_PS2 to PSMOUSE_TRACKPOINT in the TrackPoint support patch. The Synaptics driver needs to know whether the device on the pass-thru port is using 3-byte or 4-byte packets; however, instead of checking child->pktsize, it checks child->type >= PSMOUSE_GENPS - and this check is now giving a wrong result. Therefore the Synaptics driver configures the pass-thru port for 4-byte packets, and all 3-byte packets from TrackPoint seem to be thrown away.

Oh, yes, that would do it.

Quoted 2 lines

The patch below is reported to fix the problem - now the 4-byte mode is used only if child->pktsize == 4.

That is the correct fix.

Quoted 2 lines

Another option is to change the
PSMOUSE_TRACKPOINT value so that it is less than PSMOUSE_GENPS,

No, protocol numbers should not be changed as userspace drivers/setups check them and rely on them being stable. That's why psmouse->pktsize was introduced to begin with. Unfortunately synaptics pass-through piece was missed and not adjusted.

I will add the patch to my tree, thanks!

Quoted 4 lines

In theory, someone could attach a device which uses 6-byte packets to the Synaptics pass-thru port; I'm not sure what would happen in this case, but with Synaptics confugured for 3-byte packets (as the patch below will do) this configuration even has a chance of working.

I don't think it can support more than 4 byte packets. bytes 0 and 3 are protocol markers and can't be readily used for transmitting other protocols data.

Signature · 1 line
Dmitry
#4 lore raw
Quoted 6 lines · Dmitry Torokhov
Quoted 2 lines · Sergey Vlasov

Another option is to change the
PSMOUSE_TRACKPOINT value so that it is less than PSMOUSE_GENPS,

No, protocol numbers should not be changed as userspace drivers/setups check them and rely on them being stable.

Found that now:

	psmouse->dev.id.product = psmouse->type;

So the type is visible through the input device interface. Probably this should be mentioned in a comment near "enum psmouse_type" - its definition in drivers/input/mouse/psmouse.h looks just like some driver-internal enum.

Quoted 8 lines
Quoted 4 lines

In theory, someone could attach a device which uses 6-byte packets to the Synaptics pass-thru port; I'm not sure what would happen in this case, but with Synaptics confugured for 3-byte packets (as the patch below will do) this configuration even has a chance of working.

I don't think it can support more than 4 byte packets. bytes 0 and 3 are protocol markers and can't be readily used for transmitting other protocols data.

At least the Synaptics protocol description mentions that its 6-byte protocol was designed to look like two 3-byte PS/2 mouse packets, so that it would work even if the controller looks at those markers; other such protocols are likely to have the same property for the same reason. Now, if the Synaptics touchpad would be able to accept a 6-byte packet from the pass-thru port as two 3-byte packets...