Set pcbeep to default value
Hi Takashi,
Attach patch will set pcbeep to default value for ALC274.
BR,
Kailang
From 590987836f5f8e565e7fed37256185f5504d6da6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <[email protected]>
Date: Thu, 21 Nov 2024 16:16:26 +0800
Subject: [PATCH] Set PCBeep to default value for ALC274
Enable PC beep path cause pop noise via speaker during boot time. Set to default value will solve the issue.
sound/pci/hda/patch_realtek.c +2 -0
@@ -473,6 +473,8 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)break ;case 0x10ec0234 :case 0x10ec0274 : +alc_write_coef_idx (codec,0x6e ,0x0c25 ); + fallthrough;case 0x10ec0294 :case 0x10ec0700 :case 0x10ec0701 :
Quoted 4 lines · Kailang
Hi Takashi,
Attach patch will set pcbeep to default value for ALC274.
Could you resubmit with your Signed-off-by tag?
Also, a bit more comment about what this COEF setup is meant would be helpful.
thanks,
Takashi
OK.
Quoted 40 lines
-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Monday, November 25, 2024 10:45 PM
To: Kailang <[email protected]>
Cc: Takashi Iwai <[email protected]>
Subject: Re: Set pcbeep to default valueExternal mail.
Quoted 18 lines · Kailang
Quoted 18 lines
-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Friday, November 22, 2024 5:34 PM
To: Kailang <[email protected]>
Cc: ([email protected]) <[email protected]>
Subject: Re: Set pcbeep to default valueExternal mail.
Quoted 1 line · Kailang
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Hi Takashi,
Attach patch will set pcbeep to default value for ALC274.
Could you resubmit with your Signed-off-by tag?
Sorry! Attach again.
Quoted 8 lines
You seem to have dropped Cc to alsa-devel ML.
Also, nowadays we use [email protected] for the main ML for kernel patches. Care to resubmit to there?thanks,
Takashi
From 590987836f5f8e565e7fed37256185f5504d6da6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <[email protected]>
Date: Thu, 21 Nov 2024 16:16:26 +0800
Subject: [PATCH] Set PCBeep to default value for ALC274
BIOS Enable PC beep path cause pop noise via speaker during boot time. Set to default value from driver will solve the issue.
sound/pci/hda/patch_realtek.c +2 -0
@@ -473,6 +473,8 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)break ;case 0x10ec0234 :case 0x10ec0274 : +alc_write_coef_idx (codec,0x6e ,0x0c25 ); + fallthrough;case 0x10ec0294 :case 0x10ec0700 :case 0x10ec0701 :
Sorry! Attach again.
Add ALSA: hda/realtek: to Title.
Quoted 8 lines
-----Original Message-----
From: Kailang
Sent: Tuesday, November 26, 2024 10:36 AM
To: 'Takashi Iwai' <[email protected]>
Cc: ([email protected]) <[email protected]>; '[email protected]' <[email protected]>
Subject: RE: Set pcbeep to default value
Quoted 49 lines
OK.
Quoted 47 lines
-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Monday, November 25, 2024 10:45 PM
To: Kailang <[email protected]>
Cc: Takashi Iwai <[email protected]>
Subject: Re: Set pcbeep to default valueExternal mail.
Quoted 17 lines · Kailang
Quoted 17 lines
-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Friday, November 22, 2024 5:34 PM
To: Kailang <[email protected]>
Cc: ([email protected]) <[email protected]>
Subject: Re: Set pcbeep to default valueExternal mail.
Quoted 1 line · Kailang
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Hi Takashi,
Attach patch will set pcbeep to default value for ALC274.
Could you resubmit with your Signed-off-by tag?
Sorry! Attach again.
You seem to have dropped Cc to alsa-devel ML.
Also, nowadays we use [email protected] for the main ML for kernel patches. Care to resubmit to there?thanks,
Takashi
From 590987836f5f8e565e7fed37256185f5504d6da6 Mon Sep 17 00:00:00 2001
From: Kailang Yang <[email protected]>
Date: Thu, 21 Nov 2024 16:16:26 +0800
Subject: [PATCH] ALSA: hda/realtek: Set PCBeep to default value for ALC274
BIOS Enable PC beep path cause pop noise via speaker during boot time. Set to default value from driver will solve the issue.
sound/pci/hda/patch_realtek.c +2 -0
@@ -473,6 +473,8 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)break ;case 0x10ec0234 :case 0x10ec0274 : +alc_write_coef_idx (codec,0x6e ,0x0c25 ); + fallthrough;case 0x10ec0294 :case 0x10ec0700 :case 0x10ec0701 :
Quoted 4 lines · Kailang
Sorry! Attach again.
Add ALSA: hda/realtek: to Title.
Applied now. Thanks.
Takashi