Skip to contentSkip to conversation

io_uring: fix personality idr leak

PATCH In review Jens Axboe 2 participants 2 messages Feb 23, 2020 – Feb 24, 2020

Subsystems (2)
lore
Share & tools
lore

Jens Axboe

author maintainer
#0 lore raw

PATCH 1/1 io_uring: fix personality idr leak

We somehow never free the idr, even though we init it for every ctx. Free it when the rest of the ring data is freed.

Fixes 071698e13ac6 ("io_uring: allow registering credentials")

---

fs/io_uring.c +1 -0
index 7d0be264527d..d961945cb332 100644
@@ -6339,6 +6339,7 @@ static void io_ring_ctx_free(struct io_ring_ctx *ctx)
 	io_sqe_buffer_unregister(ctx);
 	io_sqe_files_unregister(ctx);
 	io_eventfd_unregister(ctx);
+	idr_destroy(&ctx->personality_idr);
 
 #if defined(CONFIG_UNIX)
 	if (ctx->ring_sock) {
Signature · 1 line
Jens Axboe
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jens Axboe

We somehow never free the idr, even though we init it for every ctx. Free it when the rest of the ring data is freed.

Fixes 071698e13ac6 ("io_uring: allow registering credentials")

---

Quoted 17 lines
fs/io_uring.c +1 -0
index 7d0be264527d..d961945cb332 100644
@@ -6339,6 +6339,7 @@ static void io_ring_ctx_free(struct io_ring_ctx *ctx)
 	io_sqe_buffer_unregister(ctx);
 	io_sqe_files_unregister(ctx);
 	io_eventfd_unregister(ctx);
+	idr_destroy(&ctx->personality_idr);
 
 #if defined(CONFIG_UNIX)
 	if (ctx->ring_sock) {
Signature · 2 lines
-- 
Jens Axboe