Skip to contentSkip to conversation

TI:OMAP: [PATCH 1/7] OMAP3 Beagle Update revision detection

U-Boot Khasim Syed Mohammed 5 participants 8 messages Jan 18, 2010 – Feb 6, 2010

lore
Share & tools
lore
#1 lore raw
Quoted 7 lines · Khasim Syed Mohammed

From 2dce4d64339a26144eac2ed56eb664cc1ea527c7 Mon Sep 17 00:00:00 2001
From: Syed Mohammed Khasim <[email protected]>
Date: Mon, 18 Jan 2010 18:03:42 +0530
Subject: [PATCH] OMAP3 Beagle Update revision detection

New BeagleBoard revision C4 uses a new ID. Update revision detection.

This patch set caused regressions in MAKEALL arm
These must be fixed.

omap3_beagle
cmd_i2c.c:109: warning: missing braces around initializer cmd_i2c.c:109: warning: (near initialization for 'i2c_no_probes[0]') beagle.c: In function 'misc_init_r':
beagle.c:143: warning: implicit declaration of function 'twl4030_pmrecv_vsel_cfg' beagle.c:152: warning: implicit declaration of function 'prcm_config_720mhz'

The changes I asked from for 1/7 were done.
Tom

#2 lore raw
Quoted 2 lines · Tom
Quoted 1 line · Khasim Syed Mohammed

From 2dce4d64339a26144eac2ed56eb664cc1ea527c7 Mon Sep 17 00:00:00 2001

Khasim: The 'From' line of your patch starts with an additional '>'

Quoted 1 line

From 2dce4d64339a2 ...

Could you check where this comes from? Maybe this confuses the mailing list archive

http://lists.denx.de/pipermail/u-boot/2010-January/066629.html

?

And could you try to add a 'vX' version to the subject of your patches? E.g.

[PATCH 1/7 v4] OMAP3 Bea ....

This would really help to identify the patch versions.

Quoted 8 lines
Quoted 6 lines

From: Syed Mohammed Khasim<[email protected]>
Date: Mon, 18 Jan 2010 18:03:42 +0530
Subject: [PATCH] OMAP3 Beagle Update revision detection

New BeagleBoard revision C4 uses a new ID. Update revision detection.

This patch set caused regressions in MAKEALL arm

Tom: On recent master a84b655fab2bc021fdafa91d1196cf826474cdd8 this patch seems to compile fine (?)

Best regards

Dirk

Quoted 16 lines

These must be fixed.

omap3_beagle
cmd_i2c.c:109: warning: missing braces around initializer cmd_i2c.c:109: warning: (near initialization for 'i2c_no_probes[0]') beagle.c: In function 'misc_init_r':
beagle.c:143: warning: implicit declaration of function 'twl4030_pmrecv_vsel_cfg' beagle.c:152: warning: implicit declaration of function 'prcm_config_720mhz'

The changes I asked from for 1/7 were done.
Tom
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#3 lore raw

Am Sonntag, den 24.01.2010, 09:59 +0100 schrieb Dirk Behme:

[?]

Quoted 6 lines

And could you try to add a 'vX' version to the subject of your patches? E.g.

[PATCH 1/7 v4] OMAP3 Bea ....

This would really help to identify the patch versions.

Just for your information, because it is not that obvious. You can achieve this when running git format-patch by using --subject-prefix="PATCH v4" (for example, see git help format-patch).

[?]

Thanks and I wish Khasim luck that the next series is going to be the last iteration,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100124/13c84d0a/attachment.pgp

#4 lore raw
In reply to Dirk Behme

Dear Dirk Behme,

Quoted 7 lines · In message <[email protected]> you wrote:

Khasim: The 'From' line of your patch starts with an additional '>'

Quoted 1 line

From 2dce4d64339a2 ...

Could you check where this comes from? Maybe this confuses the mailing list archive

This is pretty noremal. It should not affect anything. It is actually needed for all MUAs who store their messages in mailbox format.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I must follow the people.  Am I not their leader? - Benjamin Disraeli
#5 lore raw
Quoted 6 lines · Wolfgang Denk

Dear Dirk Behme,

Quoted 3 lines · In message<[email protected]> you wrote:

Khasim: The 'From' line of your patch starts with an additional '>'

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

From 2dce4d64339a2 ...

Could you check where this comes from? Maybe this confuses the mailing list archive

This is pretty noremal. It should not affect anything. It is actually needed for all MUAs who store their messages in mailbox format.

Ok.

Any other idea what causes the broken ml archive

http://lists.denx.de/pipermail/u-boot/2010-January/066629.html

then?

Best regards

Dirk

#6 lore raw

Dear Dirk Behme,

Quoted 6 lines · In message <[email protected]> you wrote:

Any other idea what causes the broken ml archive

http://lists.denx.de/pipermail/u-boot/2010-January/066629.html

then?

I have no idea. The mbox entry looks ok, and also the article looks OK on gmane.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If there are self-made purgatories, then we all have to live in them.
	-- Spock, "This Side of Paradise", stardate 3417.7
#7 lore raw
In reply to Tom
Quoted 12 lines · Tom
Quoted 7 lines · Khasim Syed Mohammed

From 2dce4d64339a26144eac2ed56eb664cc1ea527c7 Mon Sep 17 00:00:00 2001
From: Syed Mohammed Khasim<[email protected]>
Date: Mon, 18 Jan 2010 18:03:42 +0530
Subject: [PATCH] OMAP3 Beagle Update revision detection

New BeagleBoard revision C4 uses a new ID. Update revision detection.

This patch set caused regressions in MAKEALL arm
These must be fixed.

Quoted 6 lines

omap3_beagle
cmd_i2c.c:109: warning: missing braces around initializer cmd_i2c.c:109: warning: (near initialization for 'i2c_no_probes[0]') beagle.c: In function 'misc_init_r':
beagle.c:143: warning: implicit declaration of function 'twl4030_pmrecv_vsel_cfg' beagle.c:152: warning: implicit declaration of function 'prcm_config_720mhz'

With recent U-Boot main git head "a1b322a98319de568b3bc38029ef7e123643c1e8" I don't see this:

Quoted 1 line

./MAKEALL omap3_beagle

Configuring for omap3_beagle board...
text data bss dec hex filename
184267 9764 202428 396459 60cab ./u-boot

--------------------- SUMMARY ---------------------------- Boards compiled: 1
---------------------------------------------------------

Is this already gone? Or how to reproduce it?

Dirk