pinctrl: mediatek: common-v1: Fix error checking in mtk_eint_init()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 23, 2025

Subsystems (5)

Kernel janitors GPIO Arm MediaTek Pin control +1 more subsystems

lore

Share & tools

lore

Dan Carpenter

author

2025-04-23 08:23 UTC #0 lore raw

PATCH 1/1 pinctrl: mediatek: common-v1: Fix error checking in mtk_eint_init()

The devm_kzalloc() function doesn't return error pointers, it returns NULL on error. Then on the next line it checks the same pointer again by mistake, "->base" instead of "->base[0]".

Fixes fe412e3a6c97 ("pinctrl: mediatek: common-v1: Fix EINT breakage on older controllers")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/pinctrl/mediatek/pinctrl-mtk-common.c +3 -3

index 7585de11854b..8596f3541265 100644
@@ -1018,12 +1018,12 @@ static int mtk_eint_init(struct mtk_pinctrl *pctl, struct platform_device *pdev)
 	pctl->eint->nbase = 1;
 	/* mtk-eint expects an array */
 	pctl->eint->base = devm_kzalloc(pctl->dev, sizeof(pctl->eint->base), GFP_KERNEL);
-	if (IS_ERR(pctl->eint->base))
+	if (!pctl->eint->base)
 		return -ENOMEM;
 
 	pctl->eint->base[0] = devm_platform_ioremap_resource(pdev, 0);
-	if (IS_ERR(pctl->eint->base))
-		return PTR_ERR(pctl->eint->base);
+	if (IS_ERR(pctl->eint->base[0]))
+		return PTR_ERR(pctl->eint->base[0]);
 
 	pctl->eint->irq = irq_of_parse_and_map(np, 0);
 	if (!pctl->eint->irq)

Signature · 1 line

2.47.2

Linus Walleij

2025-04-23 10:59 UTC #1 lore raw

Quoted 6 lines · Dan Carpenter

The devm_kzalloc() function doesn't return error pointers, it returns NULL on error. Then on the next line it checks the same pointer again by mistake, "->base" instead of "->base[0]".
Fixes fe412e3a6c97 ("pinctrl: mediatek: common-v1: Fix EINT breakage on older controllers")
Signed-off-by Dan Carpenter <[email protected]>

Patch applied for fixes as a fix on fix.

Yours,
Linus Walleij