rxrpc: rxgk: Fix some reference count leaks
Subsystems (4)
PATCH 1/1 rxrpc: rxgk: Fix some reference count leaks
These paths should call rxgk_put(gk) but they don't. In the rxgk_construct_response() function the "goto error;" will free the "response" skb as well calling rxgk_put() so that's a bonus.
--- net/rxrpc/rxgk.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
net/rxrpc/rxgk.c +7 -3
@@ -440,8 +440,10 @@ static int rxgk_secure_packet(struct rxrpc_call *call, struct rxrpc_txbuf *txb)return PTR_ERR (gk) == -ESTALE ? -EKEYREJECTED :PTR_ERR (gk); ret =key_validate (call->conn->key); -if (ret <0 ) +if (ret <0 ) { +rxgk_put (gk);return ret; + } call->security_enctype = gk->krb5->etype; txb->cksum =htons (gk->key_number);
@@ -483,7 +485,7 @@ static int rxgk_verify_packet_integrity(struct rxrpc_call *call, hdr =kzalloc (sizeof (*hdr),GFP_NOFS );if (!hdr) -return -ENOMEM ; + goto put_gk; hdr->epoch =htonl (call->conn->proto.epoch); hdr->cid =htonl (call->cid);
@@ -505,6 +507,7 @@ static int rxgk_verify_packet_integrity(struct rxrpc_call *call, sp->len = len; } +put_gk:rxgk_put (gk);_leave (" = %d" , ret);return ret;
@@ -594,6 +597,7 @@ static int rxgk_verify_packet(struct rxrpc_call *call, struct sk_buff *skb) call->security_enctype = gk->krb5->etype;switch (call->conn->security_level) {case RXRPC_SECURITY_PLAIN : +rxgk_put (gk);return 0 ;case RXRPC_SECURITY_AUTH :return rxgk_verify_packet_integrity (call, gk, skb);
@@ -969,7 +973,7 @@ static int rxgk_construct_response(struct rxrpc_connection *conn, ret =rxgk_pad_out (response, authx_len, authx_offset + authx_len);if (ret <0 ) -return ret; + goto error; len = authx_offset + authx_len + ret;if (len != response->len) {
Signature · 1 line
2.47.2
Quoted 6 lines · Dan Carpenter
These paths should call
rxgk_put(gk)but they don't. In therxgk_construct_response()function the "goto error;" will free the "response" skb as well callingrxgk_put()so that's a bonus.Fixes 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")Signed-off-by Dan Carpenter <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 23 Apr 2025 11:25:45 +0300 you wrote:
These paths should call
rxgk_put(gk)but they don't. In therxgk_construct_response()function the "goto error;" will free the "response" skb as well callingrxgk_put()so that's a bonus.Fixes 9d1d2b59341f ("rxrpc: rxgk: Implement the yfs-rxgk security class (GSSAPI)")Signed-off-by Dan Carpenter <[email protected]>[...]
Here is the summary with links:
- [net-next] rxrpc: rxgk: Fix some reference count leaks
https://git.kernel.org/netdev/net-next/c/3a4236c37954
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html