drm/amdgpu/userq: Call unreserve on error in amdgpu_userq_fence_read_wptr()
Subsystems (3)
PATCH 1/1 drm/amdgpu/userq: Call unreserve on error in amdgpu_userq_fence_read_wptr()
This error path should call amdgpu_bo_unreserve() before returning.
Fixes d8675102ba32 ("drm/amdgpu: add vm root BO lock before accessing the vm")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c +1 -0
@@ -373,6 +373,7 @@ static int amdgpu_userq_fence_read_wptr(struct amdgpu_usermode_queue *queue, mapping =amdgpu_vm_bo_lookup_mapping (queue->vm, addr >>PAGE_SHIFT );if (!mapping) { +amdgpu_bo_unreserve (queue->vm->root.bo);DRM_ERROR ("Failed to lookup amdgpu_bo_va_mapping\n" );return -EINVAL ; }
Signature · 1 line
2.47.2
Alex Deucher
AppliedApplied. Thanks!
Quoted 24 lines · Dan Carpenter
This error path should call
amdgpu_bo_unreserve()before returning.Fixes d8675102ba32 ("drm/amdgpu: add vm root BO lock before accessing the vm")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c +1
-1@@ -373,6 +373,7 @@ static int amdgpu_userq_fence_read_wptr(struct amdgpu_usermode_queue *queue, mapping =amdgpu_vm_bo_lookup_mapping (queue->vm, addr >>PAGE_SHIFT );if (!mapping) { +amdgpu_bo_unreserve (queue->vm->root.bo);DRM_ERROR ("Failed to lookup amdgpu_bo_va_mapping\n" );return -EINVAL ; } --2.47.2