drm/bridge: cdns-mhdp8546: unlock on error in cdns_mhdp_atomic_enable()
Subsystems (4)
PATCH 1/1 drm/bridge: cdns-mhdp8546: unlock on error in cdns_mhdp_atomic_enable()
Unlock and reschedule if drm_mode_duplicate() fails. In real life, the drm_mode_duplicate() function does a small allocation and those never fail in current kernels. So this doesn't really affect runtime but the missing unlock triggers a static checker warning.
Fixes 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +4 -2
@@ -1984,8 +1984,10 @@ static void cdns_mhdp_atomic_enable(struct drm_bridge *bridge, mhdp_state =to_cdns_mhdp_bridge_state (new_state); mhdp_state->current_mode =drm_mode_duplicate (bridge->dev, mode); -if (!mhdp_state->current_mode) -return ; +if (!mhdp_state->current_mode) { + ret = -ENOMEM ; + goto out; + }drm_mode_set_name (mhdp_state->current_mode);
Signature · 1 line
2.47.2
Quoted 11 lines · Dan Carpenter
Unlock and reschedule if
drm_mode_duplicate()fails. In real life, thedrm_mode_duplicate()function does a small allocation and those never fail in current kernels. So this doesn't really affect runtime but the missing unlock triggers a static checker warning.Fixes 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by Dmitry Baryshkov <[email protected]>
Signature · 2 lines
With best wishes Dmitry