Skip to contentSkip to conversation

drm/bridge: cdns-mhdp8546: unlock on error in cdns_mhdp_atomic_enable()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 30, 2025 – May 3, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: cdns-mhdp8546: unlock on error in cdns_mhdp_atomic_enable()

Unlock and reschedule if drm_mode_duplicate() fails. In real life, the drm_mode_duplicate() function does a small allocation and those never fail in current kernels. So this doesn't really affect runtime but the missing unlock triggers a static checker warning.

Fixes 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference")
---
 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c +4 -2
index b431e7efd1f0..172039fbfab8 100644
@@ -1984,8 +1984,10 @@ static void cdns_mhdp_atomic_enable(struct drm_bridge *bridge,
 	mhdp_state = to_cdns_mhdp_bridge_state(new_state);
 
 	mhdp_state->current_mode = drm_mode_duplicate(bridge->dev, mode);
-	if (!mhdp_state->current_mode)
-		return;
+	if (!mhdp_state->current_mode) {
+		ret = -ENOMEM;
+		goto out;
+	}
 
 	drm_mode_set_name(mhdp_state->current_mode);
 
Signature · 1 line
2.47.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Dan Carpenter

Unlock and reschedule if drm_mode_duplicate() fails. In real life, the drm_mode_duplicate() function does a small allocation and those never fail in current kernels. So this doesn't really affect runtime but the missing unlock triggers a static checker warning.

Fixes 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null pointer dereference")
---
 drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Signature · 2 lines
With best wishes
Dmitry