Skip to contentSkip to conversation

drm/nouveau/fifo: small cleanup in nvkm_chan_cctx_get()

PATCH Applied Dan Carpenter 2 participants 2 messages Apr 30, 2025 – May 16, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau/fifo: small cleanup in nvkm_chan_cctx_get()

"&chan->cgrp->mutex" and "&cgrp->mutex" are the same thing. Use "&cgrp->mutex" consistently. It looks nicer and it silences a Smatch static checker warning.

---
 drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c +1 -1
index 7d4716dcd512..f5cd7f7c48b4 100644
@@ -104,7 +104,7 @@ nvkm_chan_cctx_get(struct nvkm_chan *chan, struct nvkm_engn *engn, struct nvkm_c
 	if (cctx) {
 		refcount_inc(&cctx->refs);
 		*pcctx = cctx;
-		mutex_unlock(&chan->cgrp->mutex);
+		mutex_unlock(&cgrp->mutex);
 		return 0;
 	}
 
Signature · 1 line
2.47.2
maintainer Applied
#1 lore raw
Quoted 3 lines · Dan Carpenter

"&chan->cgrp->mutex" and "&cgrp->mutex" are the same thing. Use "&cgrp->mutex" consistently. It looks nicer and it silences a Smatch static checker warning.

Applied to drm-misc-next, thanks!