cifs: Fix double unlock bug in open_cached_dir()
Subsystems (3)
PATCH 1/1 cifs: Fix double unlock bug in open_cached_dir()
The "goto out;" also does mutex_unlock(&cfid->cfid_mutex) so delete this duplicate unlock.
Fixes 62adfb82c199 ("cifs: serialize initialization and cleanup of cfid")
Signed-off-by Dan Carpenter <[email protected]>
---
To be honest I suspect that we're going to have to revert 62adfb82c199 ("cifs: serialize initialization and cleanup of cfid") instead of fixing it? So this patch might not be worth applying.
fs/smb/client/cached_dir.c | 1 - 1 file changed, 1 deletion(-)
fs/smb/client/cached_dir.c +0 -1
@@ -238,7 +238,6 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,*/ npath =path_no_prefix (cifs_sb, path);if (IS_ERR (npath)) { -mutex_unlock (&cfid->cfid_mutex); rc =PTR_ERR (npath); goto out; }
Signature · 1 line
2.47.2