Skip to contentSkip to conversation

x86/xen/msr: Remove calling native_{read,write}_msr{,_safe}() in pmu_msr_{read,write}()

bug report Dan Carpenter 1 participant 1 message May 8, 2025

lore
Share & tools
lore
#0 lore raw

Hello Xin Li (Intel),

Commit 0cb6f4128a7d ("x86/xen/msr: Remove calling native_{read,write}_msr{,_safe}() in pmu_msr_{read,write}()") from Apr 27, 2025 (linux-next), leads to the following Smatch static checker warning:

	arch/x86/xen/enlighten_pv.c:1168 xen_read_msr_safe()
	error: uninitialized symbol 'err'.

arch/x86/xen/enlighten_pv.c

    1163 static int xen_read_msr_safe(u32 msr, u64 *val)
    1164 {
    1165         int err;
    1166 
    1167         *val = xen_do_read_msr(msr, &err);
                                              ^^^

The first return in xen_do_read_msr() doesn't set *err.

--> 1168         return err;
    1169 }

regards,
dan carpenter