crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()
Subsystems (3)
PATCH 1/1 crypto: qat/qat_6xxx - Fix NULL vs IS_ERR() check in adf_probe()
The pcim_iomap_region() returns error pointers. It doesn't return NULL pointers. Update the check to match.
Fixes 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/crypto/intel/qat/qat_6xxx/adf_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/intel/qat/qat_6xxx/adf_drv.c +2 -2
@@ -156,8 +156,8 @@ static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)/* Map 64-bit PCIe BAR */ bar->virt_addr =pcim_iomap_region (pdev, bar_map[i],pci_name (pdev)); -if (!bar->virt_addr) { - ret = -ENOMEM ; +if (IS_ERR (bar->virt_addr)) { + ret =PTR_ERR (bar->virt_addr);return dev_err_probe (dev, ret,"Failed to ioremap PCI region.\n" ); } }
Signature · 1 line
2.47.2
Thanks Dan.
Quoted 6 lines · Dan Carpenter
The
pcim_iomap_region()returns error pointers. It doesn't return NULL pointers. Update the check to match.Fixes 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")Signed-off-by Dan Carpenter <[email protected]>---
Acked-by Giovanni Cabiddu <[email protected]>
Herbert Xu
maintainerQuoted 8 lines · Dan Carpenter
The
pcim_iomap_region()returns error pointers. It doesn't return NULL pointers. Update the check to match.Fixes 17fd7514ae68 ("crypto: qat - add qat_6xxx driver")Signed-off-by Dan Carpenter <[email protected]>--- drivers/crypto/intel/qat/qat_6xxx/adf_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt