Skip to contentSkip to conversation

intel-gpio for 6.16-1

GIT PULL Andy Shevchenko 2 participants 11 messages May 20, 2025 – May 21, 2025 GPIO

lore
Share & tools
lore
#0 lore raw

Hi Linux GPIO maintainers,

The GPIO ACPI code rework is in this PR. The patches are in Linux Next for at least a few days. However, one regression was reported and fixed immediately, which becomes the last patch in the PR. It wasn't in Linux Next since there was no Linux Next on this week. Nonetheless, Randy Dunlap tested it independently, that's why I include it into PR (without this the checkpatch and make htmldocs warn).

Please, pull for v6.16-rc1.

Thanks,

With Best Regards,
Andy Shevchenko

The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8:

Linux 6.15-rc1 (2025-04-06 13:11:33 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel.git tags/intel-gpio-v6.16-1

for you to fetch changes up to 6f09a17d60410e805ae112fbbfa3ed8ecd0636dd:

gpiolib-acpi: Update file references in the Documentation and MAINTAINERS (2025-05-20 22:30:51 +0300)

----------------------------------------------------------------
intel-gpio for v6.16-1

* Converted two Intel GPIO drivers to use new value setters
* Split GPIO ACPI quirks to its own file
* Refactored GPIO ACPI library to shrink the code

The following is an automated git shortlog grouped by driver:

gpiolib:

 -  acpi: Update file references in the Documentation and MAINTAINERS
 -  acpi: Move quirks to a separate file
 -  acpi: Add acpi_gpio_need_run_edge_events_on_boot() getter
 -  acpi: Handle deferred list via new API
 -  acpi: Switch to use enum in acpi_gpio_in_ignore_list()
 -  acpi: Make sure we fill struct acpi_gpio_info
 -  acpi: Use temporary variable for struct acpi_gpio_info
 -  acpi: Deduplicate some code in __acpi_find_gpio()
 -  acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
 -  acpi: Rename par to params for better readability
 -  acpi: Reduce memory footprint for struct acpi_gpio_params
 -  acpi: Remove index parameter from acpi_gpio_property_lookup()
 -  acpi: Improve struct acpi_gpio_info memory footprint

graniterapids:
- use new line value setter callbacks

ich:
- use new line value setter callbacks

----------------------------------------------------------------
Andy Shevchenko (16):
gpiolib: acpi: Improve struct acpi_gpio_info memory footprint
gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup()
gpiolib: acpi: Reduce memory footprint for struct acpi_gpio_params
gpiolib: acpi: Rename par to params for better readability
gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
gpiolib: acpi: Deduplicate some code in __acpi_find_gpio() Merge patch series "gpiolib: acpi: Refactor to shrink the code by ~8%"
gpiolib: acpi: Use temporary variable for struct acpi_gpio_info
gpiolib: acpi: Make sure we fill struct acpi_gpio_info
Merge patch series "gpiolib: acpi: Fix missing info filling"
gpiolib: acpi: Switch to use enum in acpi_gpio_in_ignore_list()
gpiolib: acpi: Handle deferred list via new API
gpiolib: acpi: Add acpi_gpio_need_run_edge_events_on_boot() getter
gpiolib: acpi: Move quirks to a separate file
Merge patch series "gpiolib: acpi: Split quirks to its own file"
gpiolib-acpi: Update file references in the Documentation and MAINTAINERS

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

 Documentation/driver-api/gpio/index.rst            |   2 +-
 .../translations/zh_CN/driver-api/gpio/index.rst   |   2 +-
 MAINTAINERS                                        |   2 +-
 drivers/gpio/Makefile                              |   1 +
 drivers/gpio/gpio-graniterapids.c                  |   6 +-
 drivers/gpio/gpio-ich.c                            |  12 +-
 .../gpio/{gpiolib-acpi.c => gpiolib-acpi-core.c}   | 522 ++++-----------------
 drivers/gpio/gpiolib-acpi-quirks.c                 | 363 ++++++++++++++
 drivers/gpio/gpiolib-acpi.h                        |  15 +
 drivers/platform/x86/intel/int0002_vgpio.c         |   2 +-
 include/linux/gpio/consumer.h                      |   2 +-
 11 files changed, 497 insertions(+), 432 deletions(-)
 rename drivers/gpio/{gpiolib-acpi.c => gpiolib-acpi-core.c} (72%)
 create mode 100644 drivers/gpio/gpiolib-acpi-quirks.c
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#1 lore raw
Quoted 78 lines · Andy Shevchenko

Hi Linux GPIO maintainers,

The GPIO ACPI code rework is in this PR. The patches are in Linux Next for at least a few days. However, one regression was reported and fixed immediately, which becomes the last patch in the PR. It wasn't in Linux Next since there was no Linux Next on this week. Nonetheless, Randy Dunlap tested it independently, that's why I include it into PR (without this the checkpatch and make htmldocs warn).

Please, pull for v6.16-rc1.

Thanks,

With Best Regards,
Andy Shevchenko

The following changes since commit 0af2f6be1b4281385b618cb86ad946eded089ac8:

Linux 6.15-rc1 (2025-04-06 13:11:33 -0700)

are available in the Git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel.git tags/intel-gpio-v6.16-1

for you to fetch changes up to 6f09a17d60410e805ae112fbbfa3ed8ecd0636dd:

gpiolib-acpi: Update file references in the Documentation and MAINTAINERS (2025-05-20 22:30:51 +0300)

----------------------------------------------------------------
intel-gpio for v6.16-1

* Converted two Intel GPIO drivers to use new value setters
* Split GPIO ACPI quirks to its own file
* Refactored GPIO ACPI library to shrink the code

The following is an automated git shortlog grouped by driver:

gpiolib:

 -  acpi: Update file references in the Documentation and MAINTAINERS
 -  acpi: Move quirks to a separate file
 -  acpi: Add acpi_gpio_need_run_edge_events_on_boot() getter
 -  acpi: Handle deferred list via new API
 -  acpi: Switch to use enum in acpi_gpio_in_ignore_list()
 -  acpi: Make sure we fill struct acpi_gpio_info
 -  acpi: Use temporary variable for struct acpi_gpio_info
 -  acpi: Deduplicate some code in __acpi_find_gpio()
 -  acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
 -  acpi: Rename par to params for better readability
 -  acpi: Reduce memory footprint for struct acpi_gpio_params
 -  acpi: Remove index parameter from acpi_gpio_property_lookup()
 -  acpi: Improve struct acpi_gpio_info memory footprint

graniterapids:
- use new line value setter callbacks

ich:
- use new line value setter callbacks

----------------------------------------------------------------
Andy Shevchenko (16):
gpiolib: acpi: Improve struct acpi_gpio_info memory footprint
gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup()
gpiolib: acpi: Reduce memory footprint for struct acpi_gpio_params
gpiolib: acpi: Rename par to params for better readability
gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup
gpiolib: acpi: Deduplicate some code in __acpi_find_gpio() Merge patch series "gpiolib: acpi: Refactor to shrink the code by ~8%"
gpiolib: acpi: Use temporary variable for struct acpi_gpio_info
gpiolib: acpi: Make sure we fill struct acpi_gpio_info
Merge patch series "gpiolib: acpi: Fix missing info filling"
gpiolib: acpi: Switch to use enum in acpi_gpio_in_ignore_list()
gpiolib: acpi: Handle deferred list via new API
gpiolib: acpi: Add acpi_gpio_need_run_edge_events_on_boot() getter
gpiolib: acpi: Move quirks to a separate file
Merge patch series "gpiolib: acpi: Split quirks to its own file"
gpiolib-acpi: Update file references in the Documentation and MAINTAINERS

Quoted 3 lines

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

Hi Andy,

These have been in my gpio/for-next branch for a long time and the ones in your PR have different commit hashes. Please remove them. I don't see any notification about you having picked those up neither in my inbox.

Bart

Quoted 21 lines
 Documentation/driver-api/gpio/index.rst            |   2 +-
 .../translations/zh_CN/driver-api/gpio/index.rst   |   2 +-
 MAINTAINERS                                        |   2 +-
 drivers/gpio/Makefile                              |   1 +
 drivers/gpio/gpio-graniterapids.c                  |   6 +-
 drivers/gpio/gpio-ich.c                            |  12 +-
 .../gpio/{gpiolib-acpi.c => gpiolib-acpi-core.c}   | 522 ++++-----------------
 drivers/gpio/gpiolib-acpi-quirks.c                 | 363 ++++++++++++++
 drivers/gpio/gpiolib-acpi.h                        |  15 +
 drivers/platform/x86/intel/int0002_vgpio.c         |   2 +-
 include/linux/gpio/consumer.h                      |   2 +-
 11 files changed, 497 insertions(+), 432 deletions(-)
 rename drivers/gpio/{gpiolib-acpi.c => gpiolib-acpi-core.c} (72%)
 create mode 100644 drivers/gpio/gpiolib-acpi-quirks.c

--
With Best Regards,
Andy Shevchenko

#2 lore raw
Quoted 2 lines · Bartosz Golaszewski

On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 8 lines
Quoted 3 lines

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

These have been in my gpio/for-next branch for a long time and the ones in your PR have different commit hashes. Please remove them. I don't see any notification about you having picked those up neither in my inbox.

Really? I though I commented a few weeks ago that I prefer to take them when Stephen complained on dups. After that there were no dups noticed. Since you haven't answered to that email, I (rightfully) assumed you are okay with the proposed course of actions.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 15 lines · Andy Shevchenko
Quoted 2 lines · Bartosz Golaszewski

On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 8 lines
Quoted 3 lines

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

These have been in my gpio/for-next branch for a long time and the ones in your PR have different commit hashes. Please remove them. I don't see any notification about you having picked those up neither in my inbox.

Quoted 5 lines

Really? I though I commented a few weeks ago that I prefer to take them when Stephen complained on dups. After that there were no dups noticed. Since you haven't answered to that email, I (rightfully) assumed you are okay with the proposed course of actions.

Can you point me to this email? I have not seen anything and can't find anything.

Bartosz

#4 lore raw
In reply to Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Bartosz Golaszewski

On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 9 lines
Quoted 8 lines
Quoted 3 lines

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

These have been in my gpio/for-next branch for a long time and the ones in your PR have different commit hashes. Please remove them. I don't see any notification about you having picked those up neither in my inbox.

Quoted 4 lines

Really? I though I commented a few weeks ago that I prefer to take them when Stephen complained on dups. After that there were no dups noticed. Since you haven't answered to that email, I (rightfully) assumed you are okay with the proposed course of actions.

FWIW, check your mailbox:
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-next/[email protected]/

Note the last one, you didn't respond. So?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
Quoted 22 lines · Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Bartosz Golaszewski

On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 9 lines
Quoted 8 lines
Quoted 3 lines

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

These have been in my gpio/for-next branch for a long time and the ones in your PR have different commit hashes. Please remove them. I don't see any notification about you having picked those up neither in my inbox.

Quoted 4 lines

Really? I though I commented a few weeks ago that I prefer to take them when Stephen complained on dups. After that there were no dups noticed. Since you haven't answered to that email, I (rightfully) assumed you are okay with the proposed course of actions.

Quoted 7 lines

FWIW, check your mailbox:
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-next/[email protected]/

Note the last one, you didn't respond. So?

I really don't have them. Neither of the three. Probably gmail spam filter borked? Anyway, would you mind removing them from your PR?

Bartosz

#6 lore raw
Quoted 6 lines · Bartosz Golaszewski
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Bartosz Golaszewski

On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 20 lines
Quoted 20 lines
Quoted 9 lines
Quoted 8 lines
Quoted 3 lines

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

These have been in my gpio/for-next branch for a long time and the ones in your PR have different commit hashes. Please remove them. I don't see any notification about you having picked those up neither in my inbox.

Quoted 4 lines

Really? I though I commented a few weeks ago that I prefer to take them when Stephen complained on dups. After that there were no dups noticed. Since you haven't answered to that email, I (rightfully) assumed you are okay with the proposed course of actions.

FWIW, check your mailbox:
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-next/[email protected]/

Quoted 4 lines
Quoted 1 line

Note the last one, you didn't respond. So?

I really don't have them. Neither of the three. Probably gmail spam filter borked? Anyway, would you mind removing them from your PR?

Okay for this. But let's talk *again* about maintainership of the Intel GPIO drivers. Last time we discussed that you have agreed that I'm in charge of that. If you think otherwise, let me know.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw
Quoted 33 lines · Andy Shevchenko
Quoted 6 lines · Bartosz Golaszewski
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Bartosz Golaszewski

On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 22 lines
Quoted 21 lines
Quoted 9 lines
Quoted 8 lines
Quoted 3 lines

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

These have been in my gpio/for-next branch for a long time and the ones in your PR have different commit hashes. Please remove them. I don't see any notification about you having picked those up neither in my inbox.

Quoted 4 lines

Really? I though I commented a few weeks ago that I prefer to take them when Stephen complained on dups. After that there were no dups noticed. Since you haven't answered to that email, I (rightfully) assumed you are okay with the proposed course of actions.

FWIW, check your mailbox:
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-next/[email protected]/

Note the last one, you didn't respond. So?

Quoted 8 lines
Quoted 2 lines

I really don't have them. Neither of the three. Probably gmail spam filter borked? Anyway, would you mind removing them from your PR?

Okay for this. But let's talk *again* about maintainership of the Intel GPIO drivers. Last time we discussed that you have agreed that I'm in charge of that. If you think otherwise, let me know.

Ok, sorry for the misunderstanding but if I were to drop them, then I'd have to rebase tens of patches that came later, it just makes more sense for you to do it.

Maybe we need to think about putting intel GPIO drivers under their own directory in v6.16, that would make it very clear which ones are your territory?

Bart

#8 lore raw
Quoted 9 lines · Bartosz Golaszewski
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Bartosz Golaszewski
Quoted 4 lines · Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Bartosz Golaszewski

On Tue, May 20, 2025 at 9:45 PM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 25 lines
Quoted 25 lines
Quoted 24 lines
Quoted 14 lines
Quoted 9 lines
Quoted 8 lines
Quoted 3 lines

Bartosz Golaszewski (2):
gpio: graniterapids: use new line value setter callbacks
gpio: ich: use new line value setter callbacks

These have been in my gpio/for-next branch for a long time and the ones in your PR have different commit hashes. Please remove them. I don't see any notification about you having picked those up neither in my inbox.

Quoted 4 lines

Really? I though I commented a few weeks ago that I prefer to take them when Stephen complained on dups. After that there were no dups noticed. Since you haven't answered to that email, I (rightfully) assumed you are okay with the proposed course of actions.

Quoted 7 lines

FWIW, check your mailbox:
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-gpio/[email protected]/
https://lore.kernel.org/linux-next/[email protected]/

Note the last one, you didn't respond. So?

I really don't have them. Neither of the three. Probably gmail spam filter borked? Anyway, would you mind removing them from your PR?

Quoted 8 lines
Quoted 4 lines

Okay for this. But let's talk *again* about maintainership of the Intel GPIO drivers. Last time we discussed that you have agreed that I'm in charge of that. If you think otherwise, let me know.

Ok, sorry for the misunderstanding but if I were to drop them, then I'd have to rebase tens of patches that came later, it just makes more sense for you to do it.

I understand that, but it's an exceptional situation. Shouldn't be like this ideally... I'm about to send an updated PR.

Quoted 3 lines

Maybe we need to think about putting intel GPIO drivers under their own directory in v6.16, that would make it very clear which ones are your territory?

Okay, let me cook the change.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#9 lore raw
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Bartosz Golaszewski

On Wed, May 21, 2025 at 11:24 AM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 6 lines
Quoted 3 lines

Ok, sorry for the misunderstanding but if I were to drop them, then I'd have to rebase tens of patches that came later, it just makes more sense for you to do it.

I understand that, but it's an exceptional situation. Shouldn't be like this ideally... I'm about to send an updated PR.

Here we are (in case you missed my email):
[email protected]

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#10 lore raw
Quoted 12 lines · Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Bartosz Golaszewski

On Wed, May 21, 2025 at 11:24 AM Andy Shevchenko
<[email protected]> wrote:

...

Quoted 4 lines
Quoted 3 lines

Ok, sorry for the misunderstanding but if I were to drop them, then I'd have to rebase tens of patches that came later, it just makes more sense for you to do it.

Quoted 6 lines
Quoted 2 lines

I understand that, but it's an exceptional situation. Shouldn't be like this ideally... I'm about to send an updated PR.

Here we are (in case you missed my email):
[email protected]

Now you're just being mean. :P

Bart