drm/plane: Fix error pointer vs NULL bug in create_in_format_blob()
Subsystems (3)
PATCH 1/1 drm/plane: Fix error pointer vs NULL bug in create_in_format_blob()
The callers expect to receive error pointers on error but create_in_format_blob() returns NULL. Change it to return error pointers.
Fixes 0d6dcd741c26 ("drm/plane: modify create_in_formats to acommodate async")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/drm_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_plane.c +2 -2
@@ -209,7 +209,7 @@ static struct drm_property_blob *create_in_format_blob(struct drm_device *dev, formats_size =sizeof (__u32) * plane->format_count;if (WARN_ON (!formats_size)) {/* 0 formats are never expected */ -return 0 ; +return ERR_PTR (-EINVAL ); } modifiers_size =
@@ -225,7 +225,7 @@ static struct drm_property_blob *create_in_format_blob(struct drm_device *dev, blob =drm_property_create_blob (dev, blob_size,NULL );if (IS_ERR (blob)) -return NULL ; +return blob; blob_data = blob->data; blob_data->version =FORMAT_BLOB_CURRENT ;
Signature · 1 line
2.47.2
Quoted 9 lines · Dan Carpenter
The callers expect to receive error pointers on error but
create_in_format_blob()returns NULL. Change it to return error pointers.Fixes 0d6dcd741c26 ("drm/plane: modify create_in_formats to acommodate async")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/drm_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by Dmitry Baryshkov <[email protected]>
Signature · 2 lines
With best wishes Dmitry