mmc: sdhci-of-k1: Fix error code in probe()
Subsystems (5)
PATCH 1/1 mmc: sdhci-of-k1: Fix error code in probe()
If spacemit_sdhci_get_clocks() fails, then propagate the error code. Don't return success.
Fixes e5502d15b0f3 ("mmc: sdhci-of-k1: add support for SpacemiT K1 SoC")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/mmc/host/sdhci-of-k1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-of-k1.c +2 -1
@@ -276,7 +276,8 @@ static int spacemit_sdhci_probe(struct platform_device *pdev) host->mmc->caps |=MMC_CAP_NEED_RSP_BUSY ; -if (spacemit_sdhci_get_clocks (dev, pltfm_host)) + ret =spacemit_sdhci_get_clocks (dev, pltfm_host); +if (ret) goto err_pltfm; ret =sdhci_add_host (host);
Signature · 1 line
2.47.2
Hi Dan,
Quoted 26 lines · Dan Carpenter
If
spacemit_sdhci_get_clocks()fails, then propagate the error code. Don't return success.Fixes e5502d15b0f3 ("mmc: sdhci-of-k1: add support for SpacemiT K1 SoC")Signed-off-by Dan Carpenter <[email protected]>--- drivers/mmc/host/sdhci-of-k1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mmc/host/sdhci-of-k1.c +2
-1@@ -276,7 +276,8 @@ static int spacemit_sdhci_probe(struct platform_device *pdev) host->mmc->caps |=MMC_CAP_NEED_RSP_BUSY ; -if (spacemit_sdhci_get_clocks (dev, pltfm_host)) + ret =spacemit_sdhci_get_clocks (dev, pltfm_host); +if (ret) goto err_pltfm; ret =sdhci_add_host (host);Signature · 1 line
2.47.2
Thanks for catching this..
Reviewed-by Yixun Lan <[email protected]>
Signature · 1 line
Yixun Lan (dlan)
Quoted 5 lines · Dan Carpenter
If
spacemit_sdhci_get_clocks()fails, then propagate the error code. Don't return success.Fixes e5502d15b0f3 ("mmc: sdhci-of-k1: add support for SpacemiT K1 SoC")Signed-off-by Dan Carpenter <[email protected]>
Acked-by Adrian Hunter <[email protected]>
Quoted 18 lines
--- drivers/mmc/host/sdhci-of-k1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mmc/host/sdhci-of-k1.c +2
-1@@ -276,7 +276,8 @@ static int spacemit_sdhci_probe(struct platform_device *pdev) host->mmc->caps |=MMC_CAP_NEED_RSP_BUSY ; -if (spacemit_sdhci_get_clocks (dev, pltfm_host)) + ret =spacemit_sdhci_get_clocks (dev, pltfm_host); +if (ret) goto err_pltfm; ret =sdhci_add_host (host);
Quoted 6 lines · Dan Carpenter
If
spacemit_sdhci_get_clocks()fails, then propagate the error code. Don't return success.Fixes e5502d15b0f3 ("mmc: sdhci-of-k1: add support for SpacemiT K1 SoC")Signed-off-by Dan Carpenter <[email protected]>
Applied for fixes, thanks!
Kind regards
Uffe
Quoted 21 lines
--- drivers/mmc/host/sdhci-of-k1.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/mmc/host/sdhci-of-k1.c +2
-2@@ -276,7 +276,8 @@ static int spacemit_sdhci_probe(struct platform_device *pdev) host->mmc->caps |=MMC_CAP_NEED_RSP_BUSY ; -if (spacemit_sdhci_get_clocks (dev, pltfm_host)) + ret =spacemit_sdhci_get_clocks (dev, pltfm_host); +if (ret) goto err_pltfm; ret =sdhci_add_host (host); --2.47.2