spi: spi-pci1xxxx: Fix error code in probe
Subsystems (2)
PATCH 1/1 spi: spi-pci1xxxx: Fix error code in probe
Return the error code if pci_alloc_irq_vectors() fails. Don't return success.
--- drivers/spi/spi-pci1xxxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-pci1xxxx.c +1 -1
@@ -765,7 +765,7 @@ static int pci1xxxx_spi_probe(struct pci_dev *pdev, const struct pci_device_id * PCI_IRQ_ALL_TYPES);if (num_vector <0 ) {dev_err (&pdev->dev,"Error allocating MSI vectors\n" ); -return ret; +return num_vector; }init_completion (&spi_sub_ptr->spi_xfer_done);
Signature · 1 line
2.47.2
Quoted 10 lines · Dan Carpenter
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Return the error code if
pci_alloc_irq_vectors()fails. Don't return success.Fixes b4608e944177 ("spi: spi-pci1xxxx: Fix Probe failure with DualSPI instance with INTx interrupts")
Signed-off-by Dan Carpenter <[email protected]>
Mark Brown
maintainerQuoted 4 lines · Dan Carpenter
Return the error code if
pci_alloc_irq_vectors()fails. Don't return success.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: spi-pci1xxxx: Fix error code in probe
commit: 2b74aea6d078ade810a3b0f7d1bcfcba2eaad416
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark