misc: pci_endpoint_test: Fix array underflow in pci_endpoint_test_ioctl()
Subsystems (4)
PATCH v2 1/1 misc: pci_endpoint_test: Fix array underflow in pci_endpoint_test_ioctl()
Commit eefb83790a0d ("misc: pci_endpoint_test: Add doorbell test case") added NO_BAR (-1) to the pci_barno enum which, in practical terms, changes the enum from an unsigned int to a signed int. If the user passes a negative number in pci_endpoint_test_ioctl() then it results in an array underflow in pci_endpoint_test_bar().
---
v2: Update the commit message to mention the commit which adds the
NO_BAR.
drivers/misc/pci_endpoint_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/pci_endpoint_test.c +1 -1
@@ -937,7 +937,7 @@ static long pci_endpoint_test_ioctl(struct file *file, unsigned int cmd,switch (cmd) {case PCITEST_BAR : bar = arg; -if (bar >BAR_5 ) +if (bar <=NO_BAR || bar >BAR_5 ) goto ret;if (is_am654_pci_dev (pdev) && bar ==BAR_0 ) goto ret;
Signature · 1 line
2.47.2
Quoted 8 lines · Dan Carpenter
Commit
eefb83790a0d("misc:pci_endpoint_test: Add doorbell test case") addedNO_BAR(-1) to thepci_barnoenum which, in practical terms, changes the enum from an unsigned int to a signed int. If the user passes a negative number inpci_endpoint_test_ioctl()then it results in an array underflow inpci_endpoint_test_bar().[...]
Applied, thanks!
[1/1] misc: pci_endpoint_test: Fix array underflow in pci_endpoint_test_ioctl()
(no commit info)
Best regards,
Signature · 1 line
Manivannan Sadhasivam <[email protected]>