Skip to contentSkip to conversation

smb: client: Fix use after free in send_done()

PATCH In review Dan Carpenter 2 participants 11 messages Aug 6, 2025 – Aug 7, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 smb: client: Fix use after free in send_done()

The mempool_free() function frees "request". Don't free the request until after smbd_disconnect_rdma_connection() to avoid a use after free bug.

Fixes 5e65668c75c0 ("smb: client: let send_done() cleanup before calling smbd_disconnect_rdma_connection()")
---
 fs/smb/client/smbdirect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/smb/client/smbdirect.c +1 -1
index 58321e483a1a..162f8d1c548a 100644
@@ -286,8 +286,8 @@ static void send_done(struct ib_cq *cq, struct ib_wc *wc)
 	if (wc->status != IB_WC_SUCCESS || wc->opcode != IB_WC_SEND) {
 		log_rdma_send(ERR, "wc->status=%d wc->opcode=%d\n",
 			wc->status, wc->opcode);
-		mempool_free(request, request->info->request_mempool);
 		smbd_disconnect_rdma_connection(request->info);
+		mempool_free(request, request->info->request_mempool);
 		return;
 	}
 
Signature · 1 line
2.47.2
#1 lore raw

Hi Dan,

Quoted 15 lines

The mempool_free() function frees "request". Don't free the request until after smbd_disconnect_rdma_connection() to avoid a use after free bug.

Fixes 5e65668c75c0 ("smb: client: let send_done() cleanup before calling smbd_disconnect_rdma_connection()")
---
  fs/smb/client/smbdirect.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/smb/client/smbdirect.c +0 -0
index 58321e483a1a..162f8d1c548a 100644

fs/smb/client/smbdirect.c static void send_done(struct ib_cq *cq, struct ib_wc *wc) · line 290

Quoted 6 lines
fs/smb/client/smbdirect.c +1 -1
@@ -286,8 +286,8 @@ static void send_done(struct ib_cq *cq, struct ib_wc *wc)
  	if (wc->status != IB_WC_SUCCESS || wc->opcode != IB_WC_SEND) {
  		log_rdma_send(ERR, "wc->status=%d wc->opcode=%d\n",
  			wc->status, wc->opcode);
-		mempool_free(request, request->info->request_mempool);
  		smbd_disconnect_rdma_connection(request->info);
+		mempool_free(request, request->info->request_mempool);

The correct fix is to use 'info' instead of 'request->info' other than that the order needs to stay that way.

I already asked Steve to squash such a change into the original commit (which is not yet upstream).

See:
https://lore.kernel.org/linux-cifs/[email protected]/T/#m98a8607d7b83a11fd78547306836a872a2a27192

What was the test that triggered the problem? Or did you only noticed it by looking at the code?

Thanks!
metze

#2 lore raw
Quoted 27 lines · Stefan Metzmacher

Hi Dan,

Quoted 15 lines

The mempool_free() function frees "request". Don't free the request until after smbd_disconnect_rdma_connection() to avoid a use after free bug.

Fixes 5e65668c75c0 ("smb: client: let send_done() cleanup before calling smbd_disconnect_rdma_connection()")
---
  fs/smb/client/smbdirect.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/smb/client/smbdirect.c +0 -0
index 58321e483a1a..162f8d1c548a 100644

fs/smb/client/smbdirect.c static void send_done(struct ib_cq *cq, struct ib_wc *wc) · line 290

Quoted 6 lines
fs/smb/client/smbdirect.c +1 -1
@@ -286,8 +286,8 @@ static void send_done(struct ib_cq *cq, struct ib_wc *wc)
  	if (wc->status != IB_WC_SUCCESS || wc->opcode != IB_WC_SEND) {
  		log_rdma_send(ERR, "wc->status=%d wc->opcode=%d\n",
  			wc->status, wc->opcode);
-		mempool_free(request, request->info->request_mempool);
  		smbd_disconnect_rdma_connection(request->info);
+		mempool_free(request, request->info->request_mempool);

The correct fix is to use 'info' instead of 'request->info' other than that the order needs to stay that way.

Quoted 8 lines

I already asked Steve to squash such a change into the original commit (which is not yet upstream).

See:
https://lore.kernel.org/linux-cifs/[email protected]/T/#m98a8607d7b83a11fd78547306836a872a2a27192

What was the test that triggered the problem? Or did you only noticed it by looking at the code?

This was a Smatch static checker warning. You need to have the cross function DB to detect it.

regards,
dan carpenter

#3 lore raw

Am 06.08.25 um 14:48 schrieb Dan Carpenter:

Quoted 31 lines · Stefan Metzmacher
Quoted 30 lines

Hi Dan,

Quoted 15 lines

The mempool_free() function frees "request". Don't free the request until after smbd_disconnect_rdma_connection() to avoid a use after free bug.

Fixes 5e65668c75c0 ("smb: client: let send_done() cleanup before calling smbd_disconnect_rdma_connection()")
---
   fs/smb/client/smbdirect.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
fs/smb/client/smbdirect.c +0 -0
index 58321e483a1a..162f8d1c548a 100644

fs/smb/client/smbdirect.c static void send_done(struct ib_cq *cq, struct ib_wc *wc) · line 290

Quoted 6 lines
fs/smb/client/smbdirect.c +1 -1
@@ -286,8 +286,8 @@ static void send_done(struct ib_cq *cq, struct ib_wc *wc)
   	if (wc->status != IB_WC_SUCCESS || wc->opcode != IB_WC_SEND) {
   		log_rdma_send(ERR, "wc->status=%d wc->opcode=%d\n",
   			wc->status, wc->opcode);
-		mempool_free(request, request->info->request_mempool);
   		smbd_disconnect_rdma_connection(request->info);
+		mempool_free(request, request->info->request_mempool);

The correct fix is to use 'info' instead of 'request->info' other than that the order needs to stay that way.

I already asked Steve to squash such a change into the original commit (which is not yet upstream).

Quoted 8 lines
Quoted 5 lines

See:
https://lore.kernel.org/linux-cifs/[email protected]/T/#m98a8607d7b83a11fd78547306836a872a2a27192

What was the test that triggered the problem? Or did you only noticed it by looking at the code?

This was a Smatch static checker warning. You need to have the cross function DB to detect it.

Ok, I'll try to integrate it into my build flow...

Does it replace sparse or does it run in addition? If it replaces sparse I guess a small script would run them both?

$ cat mychecker.sh:
#!/bin/bash
set -e
sparse $@
smatch $@

And maybe all others from
https://gautammenghani.com/linux,/c/2022/05/19/static-analysis-tools-linux-kernel.html

How often do I need to run smatch_scripts/build_kernel_data.sh on the whole kernel?

Thanks!
metze

#4 lore raw
Quoted 9 lines · Stefan Metzmacher
Quoted 5 lines
Quoted 2 lines

What was the test that triggered the problem? Or did you only noticed it by looking at the code?

This was a Smatch static checker warning. You need to have the cross function DB to detect it.

Ok, I'll try to integrate it into my build flow...

Does it replace sparse or does it run in addition?

In addition. I find the Sparse endianness checks especially useful.

Quoted 9 lines

If it replaces sparse I guess a small script would run them both?

$ cat mychecker.sh:
#!/bin/bash
set -e
sparse $@
smatch $@
Quoted 4 lines

And maybe all others from
https://gautammenghani.com/linux,/c/2022/05/19/static-analysis-tools-linux-kernel.html

How often do I need to run smatch_scripts/build_kernel_data.sh on the whole kernel?

The cross function database is really useful for just information purposes and looking at how functions are called. You probably would need to rebuild it four or five times to get useful information, unfortunately. I rebuild my every night on the latest linux-next.

But for other people, I normally say don't bother with the cross function DB. It takes a long time to build and it only slightly improves the output.

regards,
dan carpenter

#5 lore raw

Using smatch and sparse together (Re: [PATCH next] smb: client: Fix use after free in send_done())

Am 06.08.25 um 16:39 schrieb Dan Carpenter:

Quoted 24 lines · Stefan Metzmacher
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

What was the test that triggered the problem? Or did you only noticed it by looking at the code?

This was a Smatch static checker warning. You need to have the cross function DB to detect it.

Ok, I'll try to integrate it into my build flow...

Does it replace sparse or does it run in addition?

In addition. I find the Sparse endianness checks especially useful.

Quoted 11 lines

If it replaces sparse I guess a small script would run them both?

$ cat mychecker.sh:
#!/bin/bash
set -e
sparse $@
smatch $@

And maybe all others from
https://gautammenghani.com/linux,/c/2022/05/19/static-analysis-tools-linux-kernel.html

I'm using this now:

$ cat custom-checker.sh
#!/bin/bash

set -e

which sparse > /dev/null 2>&1 && {
sparse -Winit-cstring -Wsparse-error $@
}

which smatch > /dev/null 2>&1 && {
        smatch -p=kernel --fatal-checks $@
}
$ cat build-fs-smb.sh
make modules_prepare
make -j16 M=fs/smb CF=-D__CHECK_ENDIAN__ W=1ce C=1 KBUILD_MODPOST_WARN=1 KCFLAGS="-Wfatal-errors" CHECK="$(pwd)/custom-checker.sh" $@

I'm currently getting these warnings:

client/sess.c:436 cifs_chan_update_iface() warn: iterator used outside loop: 'iface' client/sess.c:444 cifs_chan_update_iface() warn: iterator used outside loop: 'iface' client/inode.c:1703 cifs_root_iget() warn: passing zero to 'ERR_PTR' client/inode.c:2295 cifs_mkdir() warn: passing zero to 'ERR_PTR' server/smb2pdu.c:3754 smb2_open() warn: Function too hairy. No more merges. server/smb2pdu.c:3754 smb2_open() parse error: Function too hairy. Giving up. 18 seconds

Is there a way to use --fatal-checks but turn the 'too hairy' and maybe others into a warning only? Something like -Wno-error=... in gcc.

Or at least turn this into an error:
client/smbdirect.c:292 send_done() error: dereferencing freed memory 'request' (line 290) Without --fatal-checks smatch still returns 0.

While this returns an error (without --fatal-checks):
server/smb2pdu.c:3754 smb2_open() warn: Function too hairy. No more merges. server/smb2pdu.c:3754 smb2_open() parse error: Function too hairy. Giving up. 8 seconds

Currently I typically use git rebase -i and then have some like this

exec bash build-fs-smb.sh C=0
pick 123456 my first patch
exec bash build-fs-smb.sh
pick 654321 my 2nd patch
exec bash build-fs-smb.sh

So I force C=0 on the initial run in order to avoid hitting the fatal Function too hairy and it then works with my default of C=1 if I don't change fs/smb/server/smb2pdu.c (or with --fatal-checks and other file that has a warning)

I'd actually prefer to use --fatal-checks and C=1 in all cases in order to notice problems I'm introducing...

Quoted 7 lines
Quoted 1 line

How often do I need to run smatch_scripts/build_kernel_data.sh on the whole kernel?

The cross function database is really useful for just information purposes and looking at how functions are called. You probably would need to rebuild it four or five times to get useful information, unfortunately. I rebuild my every night on the latest linux-next.

I have the following files generated on a fast machine:

$ ls -alrt smatch_*
-rw-r----- 1 metze metze     303104 Aug  6 15:42 smatch_db.sqlite.new
-rw-rw-r-- 1 metze metze    3107065 Aug  6 16:37 smatch_compile.warns
-rw-rw-r-- 1 metze metze 2848012813 Aug  6 16:37 smatch_warns.txt
-rw-rw-r-- 1 metze metze 6016192672 Aug  6 16:38 smatch_warns.txt.sql
-rw-rw-r-- 1 metze metze 4202917492 Aug  6 16:39 smatch_warns.txt.caller_info
-rw-r--r-- 1 metze metze 8757637120 Aug  6 16:57 smatch_db.sqlite

I copied them all to my laptop where I develop my patches and was able to reproduce the error :-)

Do I need copy all of these or is smatch_db.sqlite enough?

Would it be possible that you share your generated file(s) via a download, that might be useful for a lot of people.

Anyway thanks for all the hints so far:-)
metze

#6 lore raw

Re: Using smatch and sparse together (Re: [PATCH next] smb: client: Fix use after free in send_done())

Quoted 31 lines · Stefan Metzmacher

Am 06.08.25 um 16:39 schrieb Dan Carpenter:

Quoted 24 lines · Stefan Metzmacher
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

What was the test that triggered the problem? Or did you only noticed it by looking at the code?

This was a Smatch static checker warning. You need to have the cross function DB to detect it.

Ok, I'll try to integrate it into my build flow...

Does it replace sparse or does it run in addition?

In addition. I find the Sparse endianness checks especially useful.

Quoted 11 lines

If it replaces sparse I guess a small script would run them both?

$ cat mychecker.sh:
#!/bin/bash
set -e
sparse $@
smatch $@

And maybe all others from
https://gautammenghani.com/linux,/c/2022/05/19/static-analysis-tools-linux-kernel.html

I'm using this now:

$ cat custom-checker.sh
#!/bin/bash
Quoted 8 lines

set -e

which sparse > /dev/null 2>&1 && {
sparse -Winit-cstring -Wsparse-error $@
}

which smatch > /dev/null 2>&1 && {
        smatch -p=kernel --fatal-checks $@

I would say don't do fatal checks... I don't love that option at all. It was for another project which limits which checks it enables.

Quoted 11 lines

}

$ cat build-fs-smb.sh
make modules_prepare
make -j16 M=fs/smb CF=-D__CHECK_ENDIAN__ W=1ce C=1 KBUILD_MODPOST_WARN=1 KCFLAGS="-Wfatal-errors" CHECK="$(pwd)/custom-checker.sh" $@

I'm currently getting these warnings:

client/sess.c:436 cifs_chan_update_iface() warn: iterator used outside loop: 'iface' client/sess.c:444 cifs_chan_update_iface() warn: iterator used outside loop: 'iface'

This code is fine. It's quite hard for Smatch to parse

	if (list_entry_is_head(iface, &ses->iface_list, iface_head)) {

correctly.

Quoted 1 line

client/inode.c:1703 cifs_root_iget() warn: passing zero to 'ERR_PTR'

Huh... This warning showed up in 2023 and I didn't report it. I probably should have.

fs/smb/client/inode.c
1693 iget_root:
1694 if (!rc) {
1695 if (fattr.cf_flags & CIFS_FATTR_JUNCTION) {
1696 fattr.cf_flags &= ~CIFS_FATTR_JUNCTION;
1697 cifs_autodisable_serverino(cifs_sb);
1698 }
1699 inode = cifs_iget(sb, &fattr);

Should this have been:

		inode = cifs_iget(sb, &fattr);
		if (!inode)
			rc = -EINVAL;
  1700          }
  1701  
  1702          if (!inode) {
  1703                  inode = ERR_PTR(rc);
  1704                  goto out;
  1705          }
Quoted 1 line

client/inode.c:2295 cifs_mkdir() warn: passing zero to 'ERR_PTR'

Returning ERR_PTR(0) means reporting NULL and it's an idiom in fs/. But outside of fs/ then most times it is a bug. So the warning is useful, but in fs/ it's often deliberate like it is here.

Quoted 3 lines

server/smb2pdu.c:3754 smb2_open() warn: Function too hairy. No more merges. server/smb2pdu.c:3754 smb2_open() parse error: Function too hairy. Giving up. 18 seconds

Yeah. Ignore these.

Quoted 2 lines

Is there a way to use --fatal-checks but turn the 'too hairy' and maybe others into a warning only? Something like -Wno-error=... in gcc.

Yeah. Let me disable those unless --spammy is enabled. They're for debugging only and I'm probably the only person who is interested in them.

Quoted 5 lines

Or at least turn this into an error:
client/smbdirect.c:292 send_done() error: dereferencing freed memory 'request' (line 290) Without --fatal-checks smatch still returns 0.

Sure. To be honest, I normally build with the --succeed option which is the opposite of --fatal-checks.

Quoted 12 lines

While this returns an error (without --fatal-checks):
server/smb2pdu.c:3754 smb2_open() warn: Function too hairy. No more merges. server/smb2pdu.c:3754 smb2_open() parse error: Function too hairy. Giving up. 8 seconds

Currently I typically use git rebase -i and then have some like this

exec bash build-fs-smb.sh C=0
pick 123456 my first patch
exec bash build-fs-smb.sh
pick 654321 my 2nd patch
exec bash build-fs-smb.sh

Quoted 6 lines

So I force C=0 on the initial run in order to avoid hitting the fatal Function too hairy and it then works with my default of C=1 if I don't change fs/smb/server/smb2pdu.c (or with --fatal-checks and other file that has a warning)

I'd actually prefer to use --fatal-checks and C=1 in all cases in order to notice problems I'm introducing...

I use the scripts/new_bugs.pl script. After I've looked at the day's warnings then I run scripts/new_bugs.pl --store err-list and only review them again when I modify a file.

Quoted 13 lines
Quoted 8 lines
Quoted 2 lines

How often do I need to run smatch_scripts/build_kernel_data.sh on the whole kernel?

The cross function database is really useful for just information purposes and looking at how functions are called. You probably would need to rebuild it four or five times to get useful information, unfortunately. I rebuild my every night on the latest linux-next.

I have the following files generated on a fast machine:

$ ls -alrt smatch_*

Review

Quoted 6 lines
(quoted diff) +0 -6
-rw-r----- 1 metze metze     303104 Aug  6 15:42 smatch_db.sqlite.new
-rw-rw-r-- 1 metze metze    3107065 Aug  6 16:37 smatch_compile.warns
-rw-rw-r-- 1 metze metze 2848012813 Aug  6 16:37 smatch_warns.txt
-rw-rw-r-- 1 metze metze 6016192672 Aug  6 16:38 smatch_warns.txt.sql
-rw-rw-r-- 1 metze metze 4202917492 Aug  6 16:39 smatch_warns.txt.caller_info
-rw-r--r-- 1 metze metze 8757637120 Aug  6 16:57 smatch_db.sqlite

Your DB is 8GB. If you rebuild it enough times, then eventually the DB will max out at 32GB. If it gets to be over 40GB then my builds stop finishing in one night so I investigate and shrink it again... It's a cycle of adding code until things slow down too much and then optimizing it to make it bearable again.

Quoted 4 lines

I copied them all to my laptop where I develop my patches and was able to reproduce the error :-)

Do I need copy all of these or is smatch_db.sqlite enough?

Yep. Only smatch_db.sqlite. I should probably delete the other files after the DB has been built.

Quoted 4 lines

Would it be possible that you share your generated file(s) via a download, that might be useful for a lot of people.

The DB is too big and too dependent on your .config but I should share the smatch_data/ more regularly. I started to push that into a separate git repo but I didn't finish that work. I should do that.

regards,
dan carpenter

#7 lore raw

Re: Using smatch and sparse together (Re: [PATCH next] smb: client: Fix use after free in send_done())

Am 07.08.25 um 09:22 schrieb Dan Carpenter:

Quoted 24 lines · Stefan Metzmacher
Quoted 23 lines

Am 06.08.25 um 16:39 schrieb Dan Carpenter:

Quoted 22 lines · Stefan Metzmacher
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

What was the test that triggered the problem? Or did you only noticed it by looking at the code?

This was a Smatch static checker warning. You need to have the cross function DB to detect it.

Ok, I'll try to integrate it into my build flow...

Does it replace sparse or does it run in addition?

In addition. I find the Sparse endianness checks especially useful.

Quoted 9 lines

If it replaces sparse I guess a small script would run them both?

$ cat mychecker.sh:
#!/bin/bash
set -e
sparse $@
smatch $@
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

And maybe all others from
https://gautammenghani.com/linux,/c/2022/05/19/static-analysis-tools-linux-kernel.html

I'm using this now:

This seems to work for me now:

$ cat custom-checker.sh
#!/bin/bash

set -e

which sparse > /dev/null 2>&1 && {
sparse -Winit-cstring -Wsparse-error -fdiagnostic-prefix=SPARSE $@
}

which smatch > /dev/null 2>&1 && {
        smatch -p=kernel --pedantic --succeed $@
}
$ cat build-fs-smb.sh
#!/bin/bash
#

set -ueo pipefail

make modules_prepare
make -j16 M=fs/smb CF=-D__CHECK_ENDIAN__ W=1ce C=1 KBUILD_MODPOST_WARN=1 KCFLAGS="-Wfatal-errors" CHECK="$(pwd)/custom-checker.sh" $@ 2>&1 | tee build-fs-smb.out

cat build-fs-smb.out | grep -v 'parse error: Function too hairy' | grep -q 'error:' || {
rm build-fs-smb.out
exit 0
}
echo ""
echo "BUILD-ERRORS:"
cat build-fs-smb.out | grep -v 'parse error: Function too hairy' | grep 'error:' find fs/smb -name '*.o' | xargs rm
find fs/smb -name '*.ko' | xargs rm
rm build-fs-smb.out
exit 1

Quoted 4 lines

The DB is too big and too dependent on your .config but I should share the smatch_data/ more regularly. I started to push that into a separate git repo but I didn't finish that work. I should do that.

Ok, what's the gain of updating it?
Does it help when doing fixes on old kernels?

I'm typically doing a full kernel build a week after each rc. My idea was to rebuild the whole db after doing that.

Thanks!
metze

#8 lore raw

Re: Using smatch and sparse together (Re: [PATCH next] smb: client: Fix use after free in send_done())

Quoted 7 lines · Stefan Metzmacher
Quoted 4 lines

The DB is too big and too dependent on your .config but I should share the smatch_data/ more regularly. I started to push that into a separate git repo but I didn't finish that work. I should do that.

Ok, what's the gain of updating it?
Does it help when doing fixes on old kernels?

If you run smatch_scripts/build_kernel_data.sh then it runs smatch_scripts/gen_* which generates a bunch of the files in smatch_data/. Which in theory should enable more warnings for new code.

I've been moving away from generating files and more towards putting everything in the DB. I just took a look at the files now to respond to your email and what I saw wasn't good... I need to look at this some more.

I don't know how often the zero day bot rebuilds the smatch_data. I bet they never do and so I think it doesn't really matter.

Quoted 3 lines

I'm typically doing a full kernel build a week after each rc. My idea was to rebuild the whole db after doing that.

Yeah. That's a good strategy. The data from the existing DB feeds into the new one when you rebuild the DB so don't delete the old DB at the start or anything.

regards,
dan carpenter

#9 lore raw

Re: Using smatch and sparse together (Re: [PATCH next] smb: client: Fix use after free in send_done())

Am 07.08.25 um 17:06 schrieb Dan Carpenter:

Quoted 23 lines · Stefan Metzmacher
Quoted 7 lines
Quoted 4 lines

The DB is too big and too dependent on your .config but I should share the smatch_data/ more regularly. I started to push that into a separate git repo but I didn't finish that work. I should do that.

Ok, what's the gain of updating it?
Does it help when doing fixes on old kernels?

If you run smatch_scripts/build_kernel_data.sh then it runs smatch_scripts/gen_* which generates a bunch of the files in smatch_data/. Which in theory should enable more warnings for new code.

I've been moving away from generating files and more towards putting everything in the DB. I just took a look at the files now to respond to your email and what I saw wasn't good... I need to look at this some more.

I don't know how often the zero day bot rebuilds the smatch_data. I bet they never do and so I think it doesn't really matter.

Quoted 1 line
Quoted 6 lines
Quoted 2 lines

I'm typically doing a full kernel build a week after each rc. My idea was to rebuild the whole db after doing that.

Yeah. That's a good strategy. The data from the existing DB feeds into the new one when you rebuild the DB so don't delete the old DB at the start or anything.

I mean I'm typically do a git clean -xdf . in order to wipe everything in order to do a clean:
make -j33 bindeb-pkg

So it would build a new DB, as I'm working based on the new kernel I guess that's all I need or are there other reasons to update the existing DB?

Thanks!
metze

#10 lore raw

Re: Using smatch and sparse together (Re: [PATCH next] smb: client: Fix use after free in send_done())

Quoted 7 lines · Stefan Metzmacher
Quoted 6 lines
Quoted 2 lines

I'm typically doing a full kernel build a week after each rc. My idea was to rebuild the whole db after doing that.

Yeah. That's a good strategy. The data from the existing DB feeds into the new one when you rebuild the DB so don't delete the old DB at the start or anything.

Quoted 7 lines

I mean I'm typically do a git clean -xdf . in order to wipe everything in order to do a clean:
make -j33 bindeb-pkg

So it would build a new DB, as I'm working based on the new kernel I guess that's all I need or are there other reasons to update the existing DB?

You really want to keep the old smatch_db.sqlite DB file between rebuilds. Every time you rebuild the DB it adds more information to the call tree.

Imagine a() passes a number to b() which passes it to c(). It takes two rebuilds for that information to be built out.

regards,
dan carpenter