PM / devfreq: mtk-cci: Fix potential error pointer dereference in probe()

PATCH New Dan Carpenter 1 participant 1 message Aug 7, 2025

Subsystems (3)

Kernel janitors Arm MediaTek Device frequency (devfreq)

lore

Share & tools

lore

Dan Carpenter

author

2025-08-07 15:58 UTC #0 lore raw

PATCH 1/1 PM / devfreq: mtk-cci: Fix potential error pointer dereference in probe()

The drv->sram_reg pointer could be set to ERR_PTR(-EPROBE_DEFER) which would lead to a error pointer dereference. Use IS_ERR_OR_NULL() to check that the pointer is valid.

Fixes e09bd5757b52 ("PM / devfreq: mtk-cci: Handle sram regulator probe deferral")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/devfreq/mtk-cci-devfreq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/devfreq/mtk-cci-devfreq.c +2 -1

index 22fe9e631f8a..5730076846e1 100644
@@ -386,7 +386,8 @@ static int mtk_ccifreq_probe(struct platform_device *pdev)
 out_free_resources:
 	if (regulator_is_enabled(drv->proc_reg))
 		regulator_disable(drv->proc_reg);
-	if (drv->sram_reg && regulator_is_enabled(drv->sram_reg))
+	if (!IS_ERR_OR_NULL(drv->sram_reg) &&
+	    regulator_is_enabled(drv->sram_reg))
 		regulator_disable(drv->sram_reg);
 
 	return ret;

Signature · 1 line

2.47.2